Patch Detail
Show a patch.
GET /api/1.1/patches/3717/?format=api
{ "id": 3717, "url": "https://patchwork.libcamera.org/api/1.1/patches/3717/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3717/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200508100158.3437161-7-jacopo@jmondi.org>", "date": "2020-05-08T10:01:51", "name": "[libcamera-devel,v10,06/13] media: v4l2-ctrls: Add camera orientation and rotation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8452826796eb48886f2c7fdfd3238ad13308a2e8", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3717/mbox/", "series": [ { "id": 888, "url": "https://patchwork.libcamera.org/api/1.1/series/888/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=888", "date": "2020-05-08T10:01:45", "name": "media: report camera properties", "version": 10, "mbox": "https://patchwork.libcamera.org/series/888/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3717/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3717/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50C87603E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 May 2020 11:59:19 +0200 (CEST)", "from localhost.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 014C7FF805;\n\tFri, 8 May 2020 09:59:14 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE\n\t(V4L/DVB)), libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab <mchehab@kernel.org>,\n\tHans Verkuil <hverkuil-cisco@xs4all.nl>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo@jmondi.org>,\n\ttfiga@google.com,\n\tpavel@ucw.cz", "Date": "Fri, 8 May 2020 12:01:51 +0200", "Message-Id": "<20200508100158.3437161-7-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.26.1", "In-Reply-To": "<20200508100158.3437161-1-jacopo@jmondi.org>", "References": "<20200508100158.3437161-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v10 06/13] media: v4l2-ctrls: Add camera\n\torientation and rotation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 08 May 2020 09:59:19 -0000" }, "content": "Add support for the newly defined V4L2_CID_CAMERA_ORIENTATION\nand V4L2_CID_CAMERA_SENSOR_ROTATION read-only controls used to report\nthe camera device mounting position and orientation respectively.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n drivers/media/v4l2-core/v4l2-ctrls.c | 15 +++++++++++++++\n include/uapi/linux/v4l2-controls.h | 7 +++++++\n 2 files changed, 22 insertions(+)", "diff": "diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c\nindex 1c617b42a944d..97765a57654d2 100644\n--- a/drivers/media/v4l2-core/v4l2-ctrls.c\n+++ b/drivers/media/v4l2-core/v4l2-ctrls.c\n@@ -583,6 +583,12 @@ const char * const *v4l2_ctrl_get_menu(u32 id)\n \t\t\"Annex B Start Code\",\n \t\tNULL,\n \t};\n+\tstatic const char * const camera_orientation[] = {\n+\t\t\"Front Camera\",\n+\t\t\"Back Camera\",\n+\t\t\"External Camera\",\n+\t\tNULL,\n+\t};\n \n \tswitch (id) {\n \tcase V4L2_CID_MPEG_AUDIO_SAMPLING_FREQ:\n@@ -708,6 +714,8 @@ const char * const *v4l2_ctrl_get_menu(u32 id)\n \t\treturn hevc_decode_mode;\n \tcase V4L2_CID_MPEG_VIDEO_HEVC_START_CODE:\n \t\treturn hevc_start_code;\n+\tcase V4L2_CID_CAMERA_ORIENTATION:\n+\t\treturn camera_orientation;\n \tdefault:\n \t\treturn NULL;\n \t}\n@@ -1020,6 +1028,8 @@ const char *v4l2_ctrl_get_name(u32 id)\n \tcase V4L2_CID_PAN_SPEED:\t\treturn \"Pan, Speed\";\n \tcase V4L2_CID_TILT_SPEED:\t\treturn \"Tilt, Speed\";\n \tcase V4L2_CID_UNIT_CELL_SIZE:\t\treturn \"Unit Cell Size\";\n+\tcase V4L2_CID_CAMERA_ORIENTATION:\treturn \"Camera Orientation\";\n+\tcase V4L2_CID_CAMERA_SENSOR_ROTATION:\treturn \"Camera Sensor Rotation\";\n \n \t/* FM Radio Modulator controls */\n \t/* Keep the order of the 'case's the same as in v4l2-controls.h! */\n@@ -1295,6 +1305,10 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,\n \tcase V4L2_CID_MPEG_VIDEO_HEVC_START_CODE:\n \t\t*type = V4L2_CTRL_TYPE_MENU;\n \t\tbreak;\n+\tcase V4L2_CID_CAMERA_ORIENTATION:\n+\t\t*type = V4L2_CTRL_TYPE_MENU;\n+\t\t*flags |= V4L2_CTRL_FLAG_READ_ONLY;\n+\t\tbreak;\n \tcase V4L2_CID_LINK_FREQ:\n \t\t*type = V4L2_CTRL_TYPE_INTEGER_MENU;\n \t\tbreak;\n@@ -1346,6 +1360,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,\n \t\tbreak;\n \tcase V4L2_CID_MIN_BUFFERS_FOR_CAPTURE:\n \tcase V4L2_CID_MIN_BUFFERS_FOR_OUTPUT:\n+\tcase V4L2_CID_CAMERA_SENSOR_ROTATION:\n \t\t*type = V4L2_CTRL_TYPE_INTEGER;\n \t\t*flags |= V4L2_CTRL_FLAG_READ_ONLY;\n \t\tbreak;\ndiff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h\nindex 0ba1005c96519..3da37c9cf5046 100644\n--- a/include/uapi/linux/v4l2-controls.h\n+++ b/include/uapi/linux/v4l2-controls.h\n@@ -923,6 +923,13 @@ enum v4l2_auto_focus_range {\n #define V4L2_CID_PAN_SPEED\t\t\t(V4L2_CID_CAMERA_CLASS_BASE+32)\n #define V4L2_CID_TILT_SPEED\t\t\t(V4L2_CID_CAMERA_CLASS_BASE+33)\n \n+#define V4L2_CID_CAMERA_ORIENTATION\t\t(V4L2_CID_CAMERA_CLASS_BASE+34)\n+#define V4L2_ORIENTATION_FRONT\t\t\t0\n+#define V4L2_ORIENTATION_BACK\t\t\t1\n+#define V4L2_ORIENTATION_EXTERNAL\t\t2\n+\n+#define V4L2_CID_CAMERA_SENSOR_ROTATION\t\t(V4L2_CID_CAMERA_CLASS_BASE+35)\n+\n /* FM Modulator class control IDs */\n \n #define V4L2_CID_FM_TX_CLASS_BASE\t\t(V4L2_CTRL_CLASS_FM_TX | 0x900)\n", "prefixes": [ "libcamera-devel", "v10", "06/13" ] }