Patch Detail
Show a patch.
GET /api/1.1/patches/3678/?format=api
{ "id": 3678, "url": "https://patchwork.libcamera.org/api/1.1/patches/3678/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3678/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200503002755.1367555-1-niklas.soderlund@ragnatech.se>", "date": "2020-05-03T00:27:55", "name": "[libcamera-devel] qcam: dng_writer: Add support for IPU3 Bayer formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6ffe88b16975d3df5719ed42ee0b888b15dd3032", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3678/mbox/", "series": [ { "id": 876, "url": "https://patchwork.libcamera.org/api/1.1/series/876/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=876", "date": "2020-05-03T00:27:55", "name": "[libcamera-devel] qcam: dng_writer: Add support for IPU3 Bayer formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/876/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3678/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3678/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7130603F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 3 May 2020 02:27:59 +0200 (CEST)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid ed441b3d-8cd4-11ea-89d0-0050569116f7;\n\tSun, 03 May 2020 02:27:55 +0200 (CEST)" ], "X-Halon-ID": "ed441b3d-8cd4-11ea-89d0-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 3 May 2020 02:27:55 +0200", "Message-Id": "<20200503002755.1367555-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] qcam: dng_writer: Add support for IPU3\n\tBayer formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 03 May 2020 00:28:00 -0000" }, "content": "Add support for the Bayer formats produced on the IPU3. The format uses\na memory layout that is hard to repack and keep the 10-bit sample size,\ntherefore scale the samples to 16-bit when creating the scanlines.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/qcam/dng_writer.cpp | 45 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 45 insertions(+)", "diff": "diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\nindex f0d6f5f473e3d680..7ad52592d4449929 100644\n--- a/src/qcam/dng_writer.cpp\n+++ b/src/qcam/dng_writer.cpp\n@@ -56,6 +56,31 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n \t}\n }\n \n+void packScanlineIPU3(void *output, const void *input, unsigned int width)\n+{\n+\tconst uint8_t *in = static_cast<const uint8_t *>(input);\n+\tuint16_t *out = static_cast<uint16_t *>(output);\n+\n+\t/*\n+\t * Upsacle the 10-bit format to 16-bit as it's none trivial to pack it\n+\t * it as 10-bits without gaps.\n+\t *\n+\t * \\todo Improve packig to keep the 10-bit sample size.\n+\t */\n+\tfor (unsigned int x = 0; x < width; x += 25) {\n+\t\tfor (unsigned int i = 0; i < 6; i++) {\n+\t\t\t*out++ = ((in[1] & 0x02) << 8 | in[0]) << 6;\n+\t\t\t*out++ = ((in[2] & 0x0f) << 6 | in[1] >> 2) << 6;\n+\t\t\t*out++ = ((in[3] & 0x3f) << 4 | in[2] >> 4) << 6;\n+\t\t\t*out++ = ((in[4] & 0xff) << 2 | in[3] >> 6) << 6;\n+\t\t\tin += 5;\n+\t\t}\n+\n+\t\t*out++ = ((in[1] & 0x02) << 8 | in[0]) << 6;\n+\t\tin += 2;\n+\t}\n+}\n+\n static const std::map<PixelFormat, FormatInfo> formatInfo = {\n \t{ PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n \t\t.bitsPerSample = 10,\n@@ -97,6 +122,26 @@ static const std::map<PixelFormat, FormatInfo> formatInfo = {\n \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n \t\t.packScanline = packScanlineSBGGR12P,\n \t} },\n+\t{ PixelFormat(DRM_FORMAT_SBGGR10, IPU3_FORMAT_MOD_PACKED), {\n+\t\t.bitsPerSample = 16,\n+\t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n+\t\t.packScanline = packScanlineIPU3,\n+\t} },\n+\t{ PixelFormat(DRM_FORMAT_SGBRG10, IPU3_FORMAT_MOD_PACKED), {\n+\t\t.bitsPerSample = 16,\n+\t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n+\t\t.packScanline = packScanlineIPU3,\n+\t} },\n+\t{ PixelFormat(DRM_FORMAT_SGRBG10, IPU3_FORMAT_MOD_PACKED), {\n+\t\t.bitsPerSample = 16,\n+\t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n+\t\t.packScanline = packScanlineIPU3,\n+\t} },\n+\t{ PixelFormat(DRM_FORMAT_SRGGB10, IPU3_FORMAT_MOD_PACKED), {\n+\t\t.bitsPerSample = 16,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineIPU3,\n+\t} },\n };\n \n int DNGWriter::write(const char *filename, const Camera *camera,\n", "prefixes": [ "libcamera-devel" ] }