Patch Detail
Show a patch.
GET /api/1.1/patches/3634/?format=api
{ "id": 3634, "url": "https://patchwork.libcamera.org/api/1.1/patches/3634/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3634/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200430141433.6776-2-email@uajain.com>", "date": "2020-04-30T14:15:01", "name": "[libcamera-devel,1/2] qcam: main_window: Make cameraCombo_ private", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1e501e90ef751908eb15098861f49378e8453c0b", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3634/mbox/", "series": [ { "id": 860, "url": "https://patchwork.libcamera.org/api/1.1/series/860/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=860", "date": "2020-04-30T14:15:01", "name": "Fix combo-box entry selection on startup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/860/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3634/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3634/checks/", "tags": {}, "headers": { "Return-Path": "<bounces+15657259-5c31-libcamera-devel=lists.libcamera.org@em7280.uajain.com>", "Received": [ "from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD43E613F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 16:15:02 +0200 (CEST)", "by filterdrecv-p3mdw1-6dbfd75bfd-s4r2z with SMTP id\n\tfilterdrecv-p3mdw1-6dbfd75bfd-s4r2z-18-5EAADD65-17\n\t2020-04-30 14:15:01.37816804 +0000 UTC m=+3071257.358681003", "from mail.uajain.com (unknown)\n\tby ismtpd0004p1maa1.sendgrid.net (SG) with ESMTP id\n\tKDpipkqITA21P0cOAW0Kfg for <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 14:15:00.982 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"oX6j8eHE\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=fcGHvtiKkcH+1hWtGe6A9fNmiLJKXhQA3S/q+ATkGG4=;\n\tb=oX6j8eHEApGPfUQlybMmS951xId0wts2/YggZgKq/5R873Jxrn7E8pQbqgMm+mGrwlXn\n\tNs/llRaRD1NcXZe4gON+BK+6n66cZsYyOse0iA3XlaI+Hhq9bsPK2+HRvoVciFN+dq/X/r\n\trgZTVQ4aDj0XQUQe0lDk3grqp9Zha3OuU=", "From": "Umang Jain <email@uajain.com>", "Date": "Thu, 30 Apr 2020 14:15:01 +0000 (UTC)", "Message-Id": "<20200430141433.6776-2-email@uajain.com>", "In-Reply-To": "<20200430141433.6776-1-email@uajain.com>", "References": "<20200430141433.6776-1-email@uajain.com>", "Mime-Version": "1.0", "X-SG-EID": "1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcclL1jEi7n/kJwGMQDXxjoXcmppJDacV3imlgOtTm+65kfEqbc3cuGP78AIE/CnR/bpC+zvJ+TFueE0u0CgO/XOBXytApa7iT4lIo/6sr5cv64skmIrCw8O/Q/VoIjTa5L0XBccWCvPfgs+OqlRr4hWNYhx09O+WsP/0Ls5BW8mWqMqMHtMbC83gIciBxPIfjkNF6F6qkjrpGCWkuwrJ2HA==", "To": "libcamera-devel <libcamera-devel@lists.libcamera.org>", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain; charset=us-ascii", "Subject": "[libcamera-devel] [PATCH 1/2] qcam: main_window: Make cameraCombo_\n\tprivate", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 30 Apr 2020 14:15:04 -0000" }, "content": "This commit introduces no functional changes.\nThis is required so that the combo-box list can be managed\nconveniently from various private functions in subsequent\ncommit.\n\nSigned-off-by: Umang Jain <email@uajain.com>\n---\n src/qcam/main_window.cpp | 9 ++++-----\n src/qcam/main_window.h | 2 ++\n 2 files changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex d021fa9..344b7ec 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -11,7 +11,6 @@\n #include <string>\n #include <sys/mman.h>\n \n-#include <QComboBox>\n #include <QCoreApplication>\n #include <QFileDialog>\n #include <QImage>\n@@ -114,14 +113,14 @@ int MainWindow::createToolbars()\n \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n \n \t/* Camera selector. */\n-\tQComboBox *cameraCombo = new QComboBox();\n-\tconnect(cameraCombo, QOverload<int>::of(&QComboBox::activated),\n+\tcameraCombo_ = new QComboBox();\n+\tconnect(cameraCombo_, QOverload<int>::of(&QComboBox::activated),\n \t\tthis, &MainWindow::switchCamera);\n \n \tfor (const std::shared_ptr<Camera> &cam : cm_->cameras())\n-\t\tcameraCombo->addItem(QString::fromStdString(cam->name()));\n+\t\tcameraCombo_->addItem(QString::fromStdString(cam->name()));\n \n-\ttoolbar_->addWidget(cameraCombo);\n+\ttoolbar_->addWidget(cameraCombo_);\n \n \ttoolbar_->addSeparator();\n \ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex 5d6251c..28c325f 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -9,6 +9,7 @@\n \n #include <memory>\n \n+#include <QComboBox>\n #include <QElapsedTimer>\n #include <QIcon>\n #include <QMainWindow>\n@@ -72,6 +73,7 @@ private:\n \t/* UI elements */\n \tQToolBar *toolbar_;\n \tQAction *startStopAction_;\n+\tQComboBox *cameraCombo_;\n \tViewFinder *viewfinder_;\n \n \tQIcon iconPlay_;\n", "prefixes": [ "libcamera-devel", "1/2" ] }