Patch Detail
Show a patch.
GET /api/1.1/patches/3613/?format=api
{ "id": 3613, "url": "https://patchwork.libcamera.org/api/1.1/patches/3613/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3613/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200429214450.27676-1-dafna.hirschfeld@collabora.com>", "date": "2020-04-29T21:44:50", "name": "[libcamera-devel] libcamera: pipeline: rkisp1: don't fail if sensorInfo fails", "commit_ref": "80551b8754ddb822151576189050f9c7a8aa5ac2", "pull_url": null, "state": "accepted", "archived": false, "hash": "272a7a49ed290a1a1d6e7aee8f7ac8f952ffdd01", "submitter": { "id": 46, "url": "https://patchwork.libcamera.org/api/1.1/people/46/?format=api", "name": "Dafna Hirschfeld", "email": "dafna.hirschfeld@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3613/mbox/", "series": [ { "id": 854, "url": "https://patchwork.libcamera.org/api/1.1/series/854/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=854", "date": "2020-04-29T21:44:50", "name": "[libcamera-devel] libcamera: pipeline: rkisp1: don't fail if sensorInfo fails", "version": 1, "mbox": "https://patchwork.libcamera.org/series/854/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3613/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3613/checks/", "tags": {}, "headers": { "Return-Path": "<dafna.hirschfeld@collabora.com>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E97B603F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Apr 2020 23:44:57 +0200 (CEST)", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: dafna) with ESMTPSA id BC92926D296" ], "From": "Dafna Hirschfeld <dafna.hirschfeld@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "helen.koike@collabora.com, dafna.hirschfeld@collabora.com,\n\tezequiel@collabora.com, dafna3@gmail.com", "Date": "Wed, 29 Apr 2020 23:44:50 +0200", "Message-Id": "<20200429214450.27676-1-dafna.hirschfeld@collabora.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: don't fail\n\tif sensorInfo fails", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 29 Apr 2020 21:44:57 -0000" }, "content": "When starting the streaming, it might be that the call\nto sensorInfo fails. This does not mean that the camera can't\nstream so set 'ret' to 0\n\nSigned-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 1a34ffe..6aa3178 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -828,6 +828,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \t\t/* \\todo Turn this in an hard failure. */\n \t\tLOG(RkISP1, Warning) << \"Camera sensor information not available\";\n \t\tsensorInfo = {};\n+\t\tret = 0;\n \t}\n \n \tstd::map<unsigned int, IPAStream> streamConfig;\n", "prefixes": [ "libcamera-devel" ] }