Patch Detail
Show a patch.
GET /api/1.1/patches/3606/?format=api
{ "id": 3606, "url": "https://patchwork.libcamera.org/api/1.1/patches/3606/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3606/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200429002835.29597-1-laurent.pinchart@ideasonboard.com>", "date": "2020-04-29T00:28:35", "name": "[libcamera-devel] libcamera: ipa_module: Add log prefix", "commit_ref": "bcf986d07b1faf5412304cf63a0dfd05dbd91472", "pull_url": null, "state": "accepted", "archived": false, "hash": "c29f6a076b7785bda8945191dbc9cddd35237317", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3606/mbox/", "series": [ { "id": 847, "url": "https://patchwork.libcamera.org/api/1.1/series/847/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=847", "date": "2020-04-29T00:28:35", "name": "[libcamera-devel] libcamera: ipa_module: Add log prefix", "version": 1, "mbox": "https://patchwork.libcamera.org/series/847/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3606/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3606/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58C6F603F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Apr 2020 02:28:39 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5125521\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Apr 2020 02:28:38 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RSMgg8Mq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588120118;\n\tbh=qONyBi27O9ZtCTDtb5vr1kmVpdiAXHE94QbN6wpXg/o=;\n\th=From:To:Subject:Date:From;\n\tb=RSMgg8Mq4hbvkW1hrcjER2nHJW0OHTfDE/lTsCkxohwTfQYAVCIG2wKYdl6IPxULs\n\tUbH7sj831AUzrLg2DSu4hHQXQCndCR316OPXahOdHquB/G6FboAiz6+zqB86rkqdvK\n\tAL3eIsoYpsMD8Z494VpCJqfFu4ukd1qIHwufzVQQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 29 Apr 2020 03:28:35 +0300", "Message-Id": "<20200429002835.29597-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: ipa_module: Add log prefix", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 29 Apr 2020 00:28:39 -0000" }, "content": "Make the IPAModule class inherit from Loggable to log the IPA module\nname in all messages.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/include/ipa_module.h | 6 +++++-\n src/libcamera/ipa_module.cpp | 5 +++++\n 2 files changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/include/ipa_module.h b/src/libcamera/include/ipa_module.h\nindex a9a3511701d4..15022e19edce 100644\n--- a/src/libcamera/include/ipa_module.h\n+++ b/src/libcamera/include/ipa_module.h\n@@ -14,11 +14,12 @@\n #include <ipa/ipa_interface.h>\n #include <ipa/ipa_module_info.h>\n \n+#include \"log.h\"\n #include \"pipeline_handler.h\"\n \n namespace libcamera {\n \n-class IPAModule\n+class IPAModule : public Loggable\n {\n public:\n \texplicit IPAModule(const std::string &libPath);\n@@ -37,6 +38,9 @@ public:\n \tbool match(PipelineHandler *pipe,\n \t\t uint32_t minVersion, uint32_t maxVersion) const;\n \n+protected:\n+\tstd::string logPrefix() const override;\n+\n private:\n \tstruct IPAModuleInfo info_;\n \tstd::vector<uint8_t> signature_;\ndiff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex 52823e88a508..3444a788b855 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -471,4 +471,9 @@ bool IPAModule::match(PipelineHandler *pipe,\n \t !strcmp(info_.pipelineName, pipe->name());\n }\n \n+std::string IPAModule::logPrefix() const\n+{\n+\treturn utils::basename(libPath_.c_str());\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel" ] }