Patch Detail
Show a patch.
GET /api/1.1/patches/3579/?format=api
{ "id": 3579, "url": "https://patchwork.libcamera.org/api/1.1/patches/3579/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3579/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200427220529.1085074-3-niklas.soderlund@ragnatech.se>", "date": "2020-04-27T22:05:26", "name": "[libcamera-devel,v2,2/5] cam: options: Add public method to invalided options", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a0750afd165d656bc754372bd97fd7b4403449ed", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3579/mbox/", "series": [ { "id": 838, "url": "https://patchwork.libcamera.org/api/1.1/series/838/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=838", "date": "2020-04-27T22:05:24", "name": "{cam, qcam}: Unify stream option parsing", "version": 2, "mbox": "https://patchwork.libcamera.org/series/838/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3579/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3579/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 691B060AFA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Apr 2020 00:06:17 +0200 (CEST)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 40a2af04-88d3-11ea-b7d8-005056917a89;\n\tTue, 28 Apr 2020 00:05:49 +0200 (CEST)" ], "X-Halon-ID": "40a2af04-88d3-11ea-b7d8-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 28 Apr 2020 00:05:26 +0200", "Message-Id": "<20200427220529.1085074-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200427220529.1085074-1-niklas.soderlund@ragnatech.se>", "References": "<20200427220529.1085074-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/5] cam: options: Add public method to\n\tinvalided options", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 27 Apr 2020 22:06:17 -0000" }, "content": "Extend OptionsBase<T> with a public invalidate() method. This allows\nsub-classes to continue the interpreting of parsed options and\ninvalidate them if they find problems with the result.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/cam/options.cpp | 6 ++++++\n src/cam/options.h | 2 ++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex 2c56eacf006e9857..77b3cc1f8c5a59e9 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -64,6 +64,12 @@ const OptionValue &OptionsBase<T>::operator[](const T &opt) const\n \treturn values_.find(opt)->second;\n }\n \n+template<typename T>\n+void OptionsBase<T>::invalidate()\n+{\n+\tvalid_ = false;\n+}\n+\n template<typename T>\n bool OptionsBase<T>::parseValue(const T &opt, const Option &option,\n \t\t\t\tconst char *optarg)\ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex 5060fee0c26b896f..8ccbfee48f7ca0b5 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -54,6 +54,8 @@ public:\n \tbool isSet(const T &opt) const;\n \tconst OptionValue &operator[](const T &opt) const;\n \n+\tvoid invalidate();\n+\n private:\n \tfriend class KeyValueParser;\n \tfriend class OptionsParser;\n", "prefixes": [ "libcamera-devel", "v2", "2/5" ] }