Patch Detail
Show a patch.
GET /api/1.1/patches/357/?format=api
{ "id": 357, "url": "https://patchwork.libcamera.org/api/1.1/patches/357/?format=api", "web_url": "https://patchwork.libcamera.org/patch/357/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190124101651.9993-3-laurent.pinchart@ideasonboard.com>", "date": "2019-01-24T10:16:43", "name": "[libcamera-devel,02/10] libcamera: pipeline_handler: Declare factory children classes as final", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a1d9c6effbddb29c71adc25ccaffd5dfb34fdf0f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/357/mbox/", "series": [ { "id": 125, "url": "https://patchwork.libcamera.org/api/1.1/series/125/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=125", "date": "2019-01-24T10:16:41", "name": "Hotplug support and object lifetime management", "version": 1, "mbox": "https://patchwork.libcamera.org/series/125/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/357/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/357/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0EDC60C78\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Jan 2019 11:16:57 +0100 (CET)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35B3A2F7;\n\tThu, 24 Jan 2019 11:16:57 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548325017;\n\tbh=qq4iBObw1ANHFHTo6gmT0APE6NV95bwtWEDhW1jtsb8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XTWtJz4SUajONPuabJd9WXKSoE1m6xM45IDrUwkRrSBXv2XzcKXj6e3lJnRkvSMNf\n\tlmwz+yorZsaWFSC3za1v3o+J2uwglIYkW7fcE0jVEttJim6C8x+7tsdZfA9YPPL3Es\n\tyNyX6doKgeUDYG0RUnXnhlG+xrC8XHXQ4GEwI86c=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Jan 2019 12:16:43 +0200", "Message-Id": "<20190124101651.9993-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20190124101651.9993-1-laurent.pinchart@ideasonboard.com>", "References": "<20190124101651.9993-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 02/10] libcamera: pipeline_handler:\n\tDeclare factory children classes as final", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jan 2019 10:16:57 -0000" }, "content": "Nothing should inherit from the factory classes created by the\nREGISTER_PIPELINE_HANDLER() macro. Declare them as final instead of only\ndeclaring their create() method final.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/include/pipeline_handler.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex 7bb07d1ec5c7..1da6dc758ca6 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -46,11 +46,11 @@ private:\n };\n \n #define REGISTER_PIPELINE_HANDLER(handler)\t\t\t\t\\\n-class handler##Factory : public PipelineHandlerFactory\t\t\t\\\n+class handler##Factory final : public PipelineHandlerFactory\t\t\\\n {\t\t\t\t\t\t\t\t\t\\\n public:\t\t\t\t\t\t\t\t\t\\\n \thandler##Factory() : PipelineHandlerFactory(#handler) {}\t\\\n-\tPipelineHandler *create(CameraManager *manager) final\t\t\\\n+\tPipelineHandler *create(CameraManager *manager) \t\t\\\n \t{\t\t\t\t\t\t\t\t\\\n \t\treturn new handler(manager);\t\t\t\t\\\n \t}\t\t\t\t\t\t\t\t\\\n", "prefixes": [ "libcamera-devel", "02/10" ] }