Patch Detail
Show a patch.
GET /api/1.1/patches/3568/?format=api
{ "id": 3568, "url": "https://patchwork.libcamera.org/api/1.1/patches/3568/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3568/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200427181034.10388-1-laurent.pinchart@ideasonboard.com>", "date": "2020-04-27T18:10:34", "name": "[libcamera-devel] test: Use float values for brightness, contrast and saturation", "commit_ref": "256d0a4098aa4c4e9f87db46cecbd66f693dd9bf", "pull_url": null, "state": "accepted", "archived": false, "hash": "2cb5963e4467146c36b6b0575cf11eb32bafffaa", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3568/mbox/", "series": [ { "id": 836, "url": "https://patchwork.libcamera.org/api/1.1/series/836/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=836", "date": "2020-04-27T18:10:34", "name": "[libcamera-devel] test: Use float values for brightness, contrast and saturation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/836/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3568/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3568/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AD3B603FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Apr 2020 20:10:53 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC4B172C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Apr 2020 20:10:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JXBjqYRm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588011052;\n\tbh=9+7C1zfMHzseZH+4uNNYegz1yG3Zs2H65y4pxbIvJzo=;\n\th=From:To:Subject:Date:From;\n\tb=JXBjqYRm+iI0EDxDClxUaX9L4rGsJgix81s8ltbJiAOKEdwKeWtAkM0arPspM46mg\n\t3tYhPduzE2p0IvdG+ITpEeoHPudE68zUU4VKe9KuQ4U04L4eLdiGHM7jfS4qyfSMb7\n\tO3zo6GePE03ir+D1RIHkQ+7+rX71CSEniiPv9JCY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Apr 2020 21:10:34 +0300", "Message-Id": "<20200427181034.10388-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] test: Use float values for brightness,\n\tcontrast and saturation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 27 Apr 2020 18:10:53 -0000" }, "content": "Two tests use the brightness, contrast and saturation controls with\ninteger failures. They were not updated by commit eff4b1aa01c1 which\nturned those controls into floats. This doesn't cause test failures as\nthe control API converts the value types. For correctness, update the\ntests to use float values.\n\nFixes: eff4b1aa01c1 (\"libcamera: controls: Reorder and update description of existing controls\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/controls/control_list.cpp | 20 ++++++++++----------\n test/serialization/control_serialization.cpp | 6 +++---\n 2 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp\nindex 5374c6f99f80..d51ec47d61d3 100644\n--- a/test/controls/control_list.cpp\n+++ b/test/controls/control_list.cpp\n@@ -68,7 +68,7 @@ protected:\n \t\t * Set a control, and verify that the list now contains it, and\n \t\t * nothing else.\n \t\t */\n-\t\tlist.set(controls::Brightness, 255);\n+\t\tlist.set(controls::Brightness, -0.5f);\n \n \t\tif (list.empty()) {\n \t\t\tcout << \"List should not be empty\" << endl;\n@@ -94,7 +94,7 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tif (list.get(controls::Brightness) != 255) {\n+\t\tif (list.get(controls::Brightness) != -0.5f) {\n \t\t\tcout << \"Incorrest Brightness control value\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n@@ -105,8 +105,8 @@ protected:\n \t\t}\n \n \t\t/* Update the first control and set a second one. */\n-\t\tlist.set(controls::Brightness, 64);\n-\t\tlist.set(controls::Contrast, 128);\n+\t\tlist.set(controls::Brightness, 0.0f);\n+\t\tlist.set(controls::Contrast, 1.5f);\n \n \t\tif (!list.contains(controls::Contrast) ||\n \t\t !list.contains(controls::Contrast)) {\n@@ -114,8 +114,8 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tif (list.get(controls::Brightness) != 64 ||\n-\t\t list.get(controls::Contrast) != 128) {\n+\t\tif (list.get(controls::Brightness) != 0.0f ||\n+\t\t list.get(controls::Contrast) != 1.5f) {\n \t\t\tcout << \"Failed to retrieve control value\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n@@ -124,11 +124,11 @@ protected:\n \t\t * Update both controls and verify that the container doesn't\n \t\t * grow.\n \t\t */\n-\t\tlist.set(controls::Brightness, 10);\n-\t\tlist.set(controls::Contrast, 20);\n+\t\tlist.set(controls::Brightness, 0.5f);\n+\t\tlist.set(controls::Contrast, 1.1f);\n \n-\t\tif (list.get(controls::Brightness) != 10 ||\n-\t\t list.get(controls::Contrast) != 20) {\n+\t\tif (list.get(controls::Brightness) != 0.5f ||\n+\t\t list.get(controls::Contrast) != 1.1f) {\n \t\t\tcout << \"Failed to update control value\" << endl;\n \t\t\treturn TestFail;\n \t\t}\ndiff --git a/test/serialization/control_serialization.cpp b/test/serialization/control_serialization.cpp\nindex 2989b52774fb..111365241eb8 100644\n--- a/test/serialization/control_serialization.cpp\n+++ b/test/serialization/control_serialization.cpp\n@@ -42,9 +42,9 @@ protected:\n \t\tconst ControlInfoMap &infoMap = camera_->controls();\n \t\tControlList list(infoMap);\n \n-\t\tlist.set(controls::Brightness, 255);\n-\t\tlist.set(controls::Contrast, 128);\n-\t\tlist.set(controls::Saturation, 50);\n+\t\tlist.set(controls::Brightness, 0.5f);\n+\t\tlist.set(controls::Contrast, 1.2f);\n+\t\tlist.set(controls::Saturation, 0.2f);\n \n \t\t/*\n \t\t * Serialize the control list, this should fail as the control\n", "prefixes": [ "libcamera-devel" ] }