Patch Detail
Show a patch.
GET /api/1.1/patches/3562/?format=api
{ "id": 3562, "url": "https://patchwork.libcamera.org/api/1.1/patches/3562/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3562/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200427031713.14013-11-laurent.pinchart@ideasonboard.com>", "date": "2020-04-27T03:17:12", "name": "[libcamera-devel,10/11] test: ipa: ipa_interface: Pass configuration file to IPA init()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "00f94c746b49d49686369f6633bdd57dca5adc71", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3562/mbox/", "series": [ { "id": 831, "url": "https://patchwork.libcamera.org/api/1.1/series/831/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=831", "date": "2020-04-27T03:17:02", "name": "libcamera: Add support for IPA configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/831/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3562/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3562/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8738B60AFB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Apr 2020 05:17:36 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C93A98D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Apr 2020 05:17:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OIM4nOYA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587957456;\n\tbh=sputzHIH3iwI3MjFrOYYVXcbfQ+IzAxG9ZlE8SM5WrU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=OIM4nOYAPVsJ5DvzdUg0jekQ7/+w79+sKpmce8KjhruUlCienjdEFuatzfyXicXTu\n\tqjPbsCBJiyAgyBG5dJQmTB7J0Y8A4xNAqTXgu8l86sP6VMN6HCwaLoxaoRl1CtndhL\n\t1CwJOGnk+AS8/pcX8anNy7k7h55aAagiNRCx8WCA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Apr 2020 06:17:12 +0300", "Message-Id": "<20200427031713.14013-11-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "In-Reply-To": "<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>", "References": "<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 10/11] test: ipa: ipa_interface: Pass\n\tconfiguration file to IPA init()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 27 Apr 2020 03:17:39 -0000" }, "content": "Pass the vimc IPA dummy configuration file to the IPA init() function.\nThis will be used by the IPA to validate the init() call.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/ipa/ipa_interface_test.cpp | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\nindex 2e2dfb8d1ebd..7fa88efee089 100644\n--- a/test/ipa/ipa_interface_test.cpp\n+++ b/test/ipa/ipa_interface_test.cpp\n@@ -98,8 +98,13 @@ protected:\n \t\t}\n \n \t\t/* Test initialization of IPA module. */\n-\t\tIPASettings settings;\n-\t\tipa_->init(settings);\n+\t\tstd::string conf = ipa_->configurationFile(\"vimc.conf\");\n+\t\tint ret = ipa_->init(IPASettings{ conf });\n+\t\tif (ret < 0) {\n+\t\t\tcerr << \"IPA interface init() failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n \t\ttimer.start(1000);\n \t\twhile (timer.isRunning() && trace_ != IPAOperationInit)\n \t\t\tdispatcher->processEvents();\n@@ -155,7 +160,7 @@ private:\n \t}\n \n \tstd::shared_ptr<PipelineHandler> pipe_;\n-\tstd::unique_ptr<IPAInterface> ipa_;\n+\tstd::unique_ptr<IPAProxy> ipa_;\n \tenum IPAOperationCode trace_;\n \tEventNotifier *notifier_;\n \tint fd_;\n", "prefixes": [ "libcamera-devel", "10/11" ] }