Patch Detail
Show a patch.
GET /api/1.1/patches/3561/?format=api
{ "id": 3561, "url": "https://patchwork.libcamera.org/api/1.1/patches/3561/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3561/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200427031713.14013-10-laurent.pinchart@ideasonboard.com>", "date": "2020-04-27T03:17:11", "name": "[libcamera-devel,09/11] libcamera: pipeline: vimc: Pass configuration file to IPA init()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0f71983aa681d7fc46787cfb2a64e8577fe24954", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3561/mbox/", "series": [ { "id": 831, "url": "https://patchwork.libcamera.org/api/1.1/series/831/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=831", "date": "2020-04-27T03:17:02", "name": "libcamera: Add support for IPA configuration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/831/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3561/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3561/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3853860AF8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Apr 2020 05:17:36 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C972272C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Apr 2020 05:17:35 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AdWkkMyM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587957455;\n\tbh=XxIr00FoNnsz5gVRWHpiQJEwQ6zWN3rNCXKODoLdKME=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=AdWkkMyMU9zJin7vEIb4DkbR8Sby04GYATvS10Eb1GTzBaAFvrp6gFjmwcB3huP5/\n\t1OxD4ejHkRk09Al8Q/z0AXIIAi6K+rU1CEaJHttmwC8vVLiRr93aROrjTtQmRMRxLb\n\tYUlszIs89gvgddor0zBuYqThSRjVPkc9iFFNwEeI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Apr 2020 06:17:11 +0300", "Message-Id": "<20200427031713.14013-10-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "In-Reply-To": "<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>", "References": "<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 09/11] libcamera: pipeline: vimc: Pass\n\tconfiguration file to IPA init()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 27 Apr 2020 03:17:39 -0000" }, "content": "Pass the vimc IPA dummy configuration file to the IPA init() function.\nThis will be used by the IPA to validate the init() call.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/vimc/vimc.cpp | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 699f788aa1b8..ec3ee7241cdf 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -371,10 +371,12 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n \tstd::unique_ptr<VimcCameraData> data = std::make_unique<VimcCameraData>(this);\n \n \tdata->ipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n-\tif (data->ipa_ == nullptr)\n+\tif (data->ipa_ != nullptr) {\n+\t\tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n+\t\tdata->ipa_->init(IPASettings{ conf });\n+\t} else {\n \t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n-\telse\n-\t\tdata->ipa_->init(IPASettings{});\n+\t}\n \n \t/* Locate and open the capture video node. */\n \tif (data->init(media))\n", "prefixes": [ "libcamera-devel", "09/11" ] }