Patch Detail
Show a patch.
GET /api/1.1/patches/3516/?format=api
{ "id": 3516, "url": "https://patchwork.libcamera.org/api/1.1/patches/3516/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3516/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200424104700.26819-5-naush@raspberrypi.com>", "date": "2020-04-24T10:46:59", "name": "[libcamera-devel,v4,4/5] libcamera: controls: Add AE related controls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3ba68de88c09feadc95dc9fc1322a32c1e0a916a", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3516/mbox/", "series": [ { "id": 821, "url": "https://patchwork.libcamera.org/api/1.1/series/821/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=821", "date": "2020-04-24T10:46:55", "name": "Patchset for libcamera controls", "version": 4, "mbox": "https://patchwork.libcamera.org/series/821/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3516/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3516/checks/", "tags": {}, "headers": { "Return-Path": "<naush@raspberrypi.com>", "Received": [ "from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1327662E4D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2020 12:47:16 +0200 (CEST)", "by mail-wm1-x342.google.com with SMTP id h2so9922625wmb.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2020 03:47:16 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tj68sm7884997wrj.32.2020.04.24.03.47.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Apr 2020 03:47:14 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"LmaJOJc4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=+zSZHtzXchYfw0fqgz7s1r72uZCsipbTAkT1AW69Vaw=;\n\tb=LmaJOJc4ao00m2oe2txYpdTiXa4bqiX+Otv6X4SLBLJ8j05mIyfGX19WGjLcuVIZQT\n\tnupHrvmwJ+PsnpVNiwqXRK66ZoYj4DYkOMCfrkE1klFr3nIlWjHZYgVK8uimf7P04l8o\n\tGDraNfD33YozEkM6PC6l0+C4m9whjgU6BS3x2NgL2iWD1uwLt4XHlaSef55gP0qG+rW4\n\tb75KKdoiNuyHeotqBBUiC0Ef1atvg2Q3N8wZkBfBKoFov+mg/Gzolsd/C5PMghR1IqW0\n\t9aOC0ffBia6QYi8FtcCJGZ0tgHS2Fcvj1tkBct8hI1ge38N8VeLc/mzais4ThroIZKvZ\n\tZANw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=+zSZHtzXchYfw0fqgz7s1r72uZCsipbTAkT1AW69Vaw=;\n\tb=Ai8cwyWXRtuBt7GZTaPwm909O+FpT2j0h9nNPgMisn92dJz5iuD0sZdYgPBPSFL2BG\n\tsg8u+pP7Imor/2EAnhfbmUJ98A8j+Lk+97Dfb3/dsi1Xgd0raU6jO/gMLNY8I1xTjCQv\n\txyB9yTWNETYG85Qku2c54QT7m9uGew1VInYgeyMrnw+rNC9et3CvzczRQPL7JCiUhNfe\n\tFUR/kh5ng4B6Pcl0O1HCPDYgh7eTiq37rAvcGAlbYSmqVkHN+TDgFZVtn9mSlir7h7rv\n\ta1SbvPkdo5gtTjUtwFammC1EBwjQMHTIOpJaUBRmxRaWrallnQOTfWWNRACtsZzDWMlw\n\tgz+Q==", "X-Gm-Message-State": "AGi0PuaGTc4gNRthY2fOfBBCdhFr8/lOSne5qpjmbgxUufj1PhyP/Kac\n\tND2up7mCehDj5V7qkJLR1EkQJpXO/sPlNw==", "X-Google-Smtp-Source": "APiQypLV7lLpQhjq7LPnGgGxYpAdpbryxOo1mCg6SXYGslQ7SbjPlGEUCvfQw5iX3wIkeABNW+aLDQ==", "X-Received": "by 2002:a05:600c:214b:: with SMTP id\n\tv11mr9967224wml.151.1587725235368; \n\tFri, 24 Apr 2020 03:47:15 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Apr 2020 11:46:59 +0100", "Message-Id": "<20200424104700.26819-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200424104700.26819-1-naush@raspberrypi.com>", "References": "<20200424104700.26819-1-naush@raspberrypi.com>", "Subject": "[libcamera-devel] [PATCH v4 4/5] libcamera: controls: Add AE\n\trelated controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 24 Apr 2020 10:47:16 -0000" }, "content": "AeMeteringMode, AeConstraintMode, and AeExposureMode are new enum type\ncontrols used to specify operating modes in the AE algorithm. All modes\nmay not be supported by all platforms.\n\nExposureValue is a new control used to set the log2 exposure adjustment\nfor the AE algorithm.\n\nLux is a new control that returns the current lux estimate.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 109 +++++++++++++++++++++++++++++++++\n 1 file changed, 109 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex f7403081..f66b851b 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -25,6 +25,109 @@ controls:\n \n \\sa AeEnable\n \n+ # AeMeteringMode needs further attention:\n+ # - Auto-generate max enum value.\n+ # - Better handling of custom types.\n+ - AeMeteringMode:\n+ type: int32_t\n+ description: |\n+ Specify a metering mode for the AE algorithm to use. The metering\n+ modes determine which parts of the image are used to determine the\n+ scene brightness. Metering modes may be platform specific and not\n+ all metering modes may be supported.\n+ enum:\n+ - name: MeteringCentreWeighted\n+ value: 0\n+ description: Centre-weighted metering mode.\n+ - name: MeteringSpot\n+ value: 1\n+ description: Spot metering mode.\n+ - name: MeteringMatrix\n+ value: 2\n+ description: Matrix metering mode.\n+ - name: MeteringCustom\n+ value: 3\n+ description: Custom metering mode.\n+ - name: MeteringModeMax\n+ value: 3\n+ description: Maximum allowed value (place any new values above here).\n+\n+ # AeConstraintMode needs further attention:\n+ # - Auto-generate max enum value.\n+ # - Better handling of custom types.\n+ - AeConstraintMode:\n+ type: int32_t\n+ description: |\n+ Specify a constraint mode for the AE algorithm to use. These determine\n+ how the measured scene brightness is adjusted to reach the desired\n+ target exposure. Constraint modes may be platform specific, and not\n+ all constraint modes may be supported.\n+ enum:\n+ - name: ConstraintNormal\n+ value: 0\n+ description: Default constraint mode.\n+ This mode aims to balance the exposure of different parts of the\n+ image so as to reach a reasonable average level. However, highlights\n+ in the image may appear over-exposed and lowlights may appear\n+ under-exposed.\n+ - name: ConstraintHighlight\n+ value: 1\n+ description: Highlight constraint mode.\n+ This mode adjusts the exposure levels in order to try and avoid\n+ over-exposing the brightest parts (highlights) of an image.\n+ Other non-highlight parts of the image may appear under-exposed.\n+ - name: ConstraintShadows\n+ value: 2\n+ description: Shadows constraint mode.\n+ This mode adjusts the exposure levels in order to try and avoid\n+ under-exposing the dark parts (shadows) of an image. Other normally\n+ exposed parts of the image may appear over-exposed.\n+ - name: ConstraintCustom\n+ value: 3\n+ description: Custom constraint mode.\n+ - name: ConstraintModeMax\n+ value: 3\n+ description: Maximum allowed value (place any new values above here).\n+\n+ # AeExposureMode needs further attention:\n+ # - Auto-generate max enum value.\n+ # - Better handling of custom types.\n+ - AeExposureMode:\n+ type: int32_t\n+ description: |\n+ Specify an exposure mode for the AE algorithm to use. These specify\n+ how the desired total exposure is divided between the shutter time\n+ and the sensor's analogue gain. The exposure modes are platform\n+ specific, and not all exposure modes may be supported.\n+ enum:\n+ - name: ExposureNormal\n+ value: 0\n+ description: Default exposure mode.\n+ - name: ExposureShort\n+ value: 1\n+ description: Exposure mode allowing only short exposure times.\n+ - name: ExposureLong\n+ value: 2\n+ description: Exposure mode allowing long exposure times.\n+ - name: ExposureCustom\n+ value: 3\n+ description: Custom exposure mode.\n+ - name: ExposureModeMax\n+ value: 3\n+ description: Maximum allowed value (place any new values above here).\n+\n+ - ExposureValue:\n+ type: float\n+ description: |\n+ Specify an Exposure Value (EV) parameter. The EV parameter will only be\n+ applied if the AE algorithm is currently enabled.\n+\n+ By convention EV adjusts the exposure as log2. For example\n+ EV = [-2, -1, 0.5, 0, 0.5, 1, 2] results in an exposure adjustment\n+ of [1/4x, 1/2x, 1/sqrt(2)x, 1x, sqrt(2)x, 2x, 4x].\n+\n+ \\sa AeEnable\n+\n - ExposureTime:\n type: int32_t\n description: |\n@@ -55,6 +158,12 @@ controls:\n Specify a fixed contrast parameter. Normal contrast is given by the\n value 1.0; larger values produce images with more contrast.\n \n+ - Lux:\n+ type: float\n+ description: |\n+ Report an estimate of the current illuminance level in lux. The Lux\n+ control can only be returned in metadata.\n+\n - AwbEnable:\n type: bool\n description: |\n", "prefixes": [ "libcamera-devel", "v4", "4/5" ] }