Patch Detail
Show a patch.
GET /api/1.1/patches/3506/?format=api
{ "id": 3506, "url": "https://patchwork.libcamera.org/api/1.1/patches/3506/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3506/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200421203954.15585-3-andrey.konovalov@linaro.org>", "date": "2020-04-21T20:39:54", "name": "[libcamera-devel,2/2] libcamera: pipeline: simple: try next mbus code if setupFormats() fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "727abbd4fba48004d230ef1b06611a9d05fba01b", "submitter": { "id": 25, "url": "https://patchwork.libcamera.org/api/1.1/people/25/?format=api", "name": "Andrey Konovalov", "email": "andrey.konovalov@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3506/mbox/", "series": [ { "id": 818, "url": "https://patchwork.libcamera.org/api/1.1/series/818/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=818", "date": "2020-04-21T20:39:52", "name": "Simple pipeline: skip broken pipeline configurations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/818/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3506/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3506/checks/", "tags": {}, "headers": { "Return-Path": "<andrey.konovalov@linaro.org>", "Received": [ "from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFAB462E67\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Apr 2020 22:40:15 +0200 (CEST)", "by mail-lf1-x142.google.com with SMTP id x23so12232885lfq.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 21 Apr 2020 13:40:15 -0700 (PDT)", "from localhost.localdomain (37-144-159-139.broadband.corbina.ru.\n\t[37.144.159.139]) by smtp.googlemail.com with ESMTPSA id\n\tg6sm476176ljj.78.2020.04.21.13.40.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 21 Apr 2020 13:40:14 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"WgZKmtnS\"; \n\tdkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Km8odjCrSkpyc4WjaccZ2TZziaQHbv4cKBm5v4L6khc=;\n\tb=WgZKmtnSQcz72xytlB4WAVjzocijojULiEnS0b0fnxkzMvsIEn5WtEfonCrufxzVgm\n\t888icIIVPszySHZclPL/DOZcWi/tqydYF7uKpchGmSESWZLsoZexSa5/praIEoWpA/GX\n\tzI2QGoncBjCkr5nWSUL/zOWmpkgY21VyLlYg7g8ckR6CC0k+dCKYiKQ5zzb9NMKLSNGF\n\tpgyzT8Ml/pbyuUSw7Es8QZcYHF0KdwssklW6NXlec1G/Hl/8IMvBqCT0jzJ+sIo/x0oK\n\t6vQ1Z649dpTKrG9E9SDdaSlMAMzCGdYKW4LHC0x/qk104manN2o2k5wkVTgEI9JusyZA\n\tsNuA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Km8odjCrSkpyc4WjaccZ2TZziaQHbv4cKBm5v4L6khc=;\n\tb=m/MMoxf4iUzlKcicFpLILkRVwAjjPya0B5nKyWviM4x0F5Pnj5md/kVGCbKNXHMRlo\n\tuWOk4mCRCir9VWQw1IcL0Ay+B7vYQ8Hm8uMm9y0MSSr6tzY8wfHxAu1bVI7nYxqp98CY\n\t+oo2FA1ci9EBPqunOsNHfts0cbOsTs9DcmM3Frxom8ZS6UvZlRxO8EG2Lm/cxWE0OqIO\n\tkQcKZRt3RAJZaEOU3kVIYB0DPsiwENOhAf0ObE2bpARcsNd7ysJSgjF5eCpM8KwCwS2D\n\tknQywezHbsSu+kIBwHrahRyiFYoSh0yiXlSGtBXAPjggCyoAaduvWD2Xbf60kRu1kb/+\n\t9oiQ==", "X-Gm-Message-State": "AGi0PuaE2SQXJ89yeDDYhgFRr2f9TIS89SKyw2r5eg5dTQDF8SHDodWq\n\tmJYf89mI4vGfn8sC/O0BgPgiROGp6XI=", "X-Google-Smtp-Source": "APiQypKZBEI3mKPkRYIeZo3j22Dg/myA3KUVUVMKApHORjnLdJvRKWEIVZyGrJAE3ca20hVtyeZe0Q==", "X-Received": "by 2002:a19:f614:: with SMTP id\n\tx20mr14806309lfe.84.1587501614791; \n\tTue, 21 Apr 2020 13:40:14 -0700 (PDT)", "From": "Andrey Konovalov <andrey.konovalov@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 21 Apr 2020 23:39:54 +0300", "Message-Id": "<20200421203954.15585-3-andrey.konovalov@linaro.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200421203954.15585-1-andrey.konovalov@linaro.org>", "References": "<20200421203954.15585-1-andrey.konovalov@linaro.org>", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: pipeline: simple: try next\n\tmbus code if setupFormats() fails", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 21 Apr 2020 20:40:16 -0000" }, "content": "Now SimpleCameraData::setupFormats() can fail if the camera sensor\nsupports media bus code which some entities down the pipeline don't.\n\nWhen this happens continue with the next media bus code instead of aborting\nthe enumeration of the possible pipeline configurations.\n\nSigned-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>\n---\n src/libcamera/pipeline/simple/simple.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 8212bd9..1a31e18 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -265,10 +265,11 @@ int SimpleCameraData::init()\n \n \t\tret = setupFormats(&format, V4L2Subdevice::TryFormat);\n \t\tif (ret < 0) {\n-\t\t\tLOG(SimplePipeline, Error)\n+\t\t\tLOG(SimplePipeline, Warning)\n \t\t\t\t<< \"Failed to setup pipeline for media bus code \"\n \t\t\t\t<< utils::hex(code, 4);\n-\t\t\treturn ret;\n+\t\t\t/* Try next mbus_code supported by the sensor */\n+\t\t\tcontinue;\n \t\t}\n \n \t\tstd::map<V4L2PixelFormat, std::vector<SizeRange>> videoFormats =\n", "prefixes": [ "libcamera-devel", "2/2" ] }