Patch Detail
Show a patch.
GET /api/1.1/patches/3503/?format=api
{ "id": 3503, "url": "https://patchwork.libcamera.org/api/1.1/patches/3503/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3503/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200419213341.18925-1-laurent.pinchart@ideasonboard.com>", "date": "2020-04-19T21:33:41", "name": "[libcamera-devel] libcamera: device_enumerator_udev: Log the right number of missing deps", "commit_ref": "058407bb9ba4e122f464b3515f30ae1205ff803d", "pull_url": null, "state": "accepted", "archived": false, "hash": "dda7098a5a17bdc7db94e3d8fbe438627a517f75", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3503/mbox/", "series": [ { "id": 817, "url": "https://patchwork.libcamera.org/api/1.1/series/817/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=817", "date": "2020-04-19T21:33:41", "name": "[libcamera-devel] libcamera: device_enumerator_udev: Log the right number of missing deps", "version": 1, "mbox": "https://patchwork.libcamera.org/series/817/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3503/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3503/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A596860400\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 Apr 2020 23:33:57 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B148528\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 Apr 2020 23:33:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oeHH0wBc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587332037;\n\tbh=MW5l7KG96oACxPw12TBLfAr9rot42GS+8akrHqNLCzU=;\n\th=From:To:Subject:Date:From;\n\tb=oeHH0wBc7+TQN8angTnAuiYO9yfVoSuQgtasDyBPOJyEmDv2gpFqo2va7dWYxnIQ7\n\tNFM0c8a+/AkYsRT+IeRIwJMYU9ZUwQGvmS92qhIlgWK3Xe2wJSSLyITJMykEHrFld9\n\tu3cZeg9ldmA/m6uk82l8u3VgCxTyZLX4k9OOPOek=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Apr 2020 00:33:41 +0300", "Message-Id": "<20200419213341.18925-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: device_enumerator_udev: Log\n\tthe right number of missing deps", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 19 Apr 2020 21:33:58 -0000" }, "content": "Since commit e75ef59e028e (\"libcamera: device_enumerator_udev: Update\npending list in addUdevDevice\") the populateMediaDevice() function\nreturns 0 on success instead of the number of missing dependencies,\nresulting in a wrong number being logged. Fix it.\n\nFixes: e75ef59e028e (\"libcamera: device_enumerator_udev: Update pending list in addUdevDevice\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/device_enumerator_udev.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\nindex 9cbc7e47d2d9..2e33c898aeef 100644\n--- a/src/libcamera/device_enumerator_udev.cpp\n+++ b/src/libcamera/device_enumerator_udev.cpp\n@@ -94,7 +94,8 @@ int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev)\n \t\tif (!deps.empty()) {\n \t\t\tLOG(DeviceEnumerator, Debug)\n \t\t\t\t<< \"Defer media device \" << media->deviceNode()\n-\t\t\t\t<< \" due to \" << ret << \" missing dependencies\";\n+\t\t\t\t<< \" due to \" << deps.size()\n+\t\t\t\t<< \" missing dependencies\";\n \n \t\t\tpending_.emplace_back(std::move(media), std::move(deps));\n \t\t\tMediaDeviceDeps *mediaDeps = &pending_.back();\n", "prefixes": [ "libcamera-devel" ] }