Patch Detail
Show a patch.
GET /api/1.1/patches/3450/?format=api
{ "id": 3450, "url": "https://patchwork.libcamera.org/api/1.1/patches/3450/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3450/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200413212700.1373247-5-niklas.soderlund@ragnatech.se>", "date": "2020-04-13T21:26:56", "name": "[libcamera-devel,v4,4/8] libcamera: pipeline: rkisp1: Add clear() to RkISP1Frames", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bebeb41802b4ee653b9a762d2206ea0e90317b85", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3450/mbox/", "series": [ { "id": 805, "url": "https://patchwork.libcamera.org/api/1.1/series/805/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=805", "date": "2020-04-13T21:26:52", "name": "libcamera: ipa_manager: Proxy open-source IPAs to a thread", "version": 4, "mbox": "https://patchwork.libcamera.org/series/805/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3450/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3450/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5DD062DD9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2020 23:27:09 +0200 (CEST)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 838d85e6-7dcd-11ea-aeed-005056917f90;\n\tMon, 13 Apr 2020 23:27:01 +0200 (CEST)" ], "X-Halon-ID": "838d85e6-7dcd-11ea-aeed-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 13 Apr 2020 23:26:56 +0200", "Message-Id": "<20200413212700.1373247-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.26.0", "In-Reply-To": "<20200413212700.1373247-1-niklas.soderlund@ragnatech.se>", "References": "<20200413212700.1373247-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 4/8] libcamera: pipeline: rkisp1: Add\n\tclear() to RkISP1Frames", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 13 Apr 2020 21:27:11 -0000" }, "content": "When the camera is stopping the helper that keeps track of which buffers\nare associated with a request is not cleared. Add a clear operation and\ncall it when the camera is stopped.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex de90615edf217cca..c4e46bea1cc9a47f 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -64,6 +64,7 @@ public:\n \n \tRkISP1FrameInfo *create(unsigned int frame, Request *request, Stream *stream);\n \tint destroy(unsigned int frame);\n+\tvoid clear();\n \n \tRkISP1FrameInfo *find(unsigned int frame);\n \tRkISP1FrameInfo *find(FrameBuffer *buffer);\n@@ -279,6 +280,21 @@ int RkISP1Frames::destroy(unsigned int frame)\n \treturn 0;\n }\n \n+void RkISP1Frames::clear()\n+{\n+\tauto it = frameInfo_.cbegin();\n+\twhile (it != frameInfo_.cend()) {\n+\t\tRkISP1FrameInfo *info = it->second;\n+\n+\t\tpipe_->availableParamBuffers_.push(info->paramBuffer);\n+\t\tpipe_->availableStatBuffers_.push(info->statBuffer);\n+\n+\t\tit = frameInfo_.erase(it);\n+\n+\t\tdelete info;\n+\t}\n+}\n+\n RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)\n {\n \tauto itInfo = frameInfo_.find(frame);\n@@ -832,6 +848,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n \n \tdata->timeline_.reset();\n \n+\tdata->frameInfo_.clear();\n+\n \tfreeBuffers(camera);\n \n \tactiveCamera_ = nullptr;\n", "prefixes": [ "libcamera-devel", "v4", "4/8" ] }