Patch Detail
Show a patch.
GET /api/1.1/patches/3334/?format=api
{ "id": 3334, "url": "https://patchwork.libcamera.org/api/1.1/patches/3334/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3334/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200326145927.324919-7-jacopo@jmondi.org>", "date": "2020-03-26T14:59:27", "name": "[libcamera-devel,v4,6/6] DNI: libcamera: sensor: ov5670: Add lens properties", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "2d0031d0b783ef13a002a21ab8524f7f89c63602", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/3334/mbox/", "series": [ { "id": 782, "url": "https://patchwork.libcamera.org/api/1.1/series/782/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=782", "date": "2020-03-26T14:59:21", "name": "Camera properties and camera sensor factory", "version": 4, "mbox": "https://patchwork.libcamera.org/series/782/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3334/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3334/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 012AD62684\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Mar 2020 15:56:36 +0100 (CET)", "from localhost.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id B875A20015\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Mar 2020 14:56:35 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 26 Mar 2020 15:59:27 +0100", "Message-Id": "<20200326145927.324919-7-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200326145927.324919-1-jacopo@jmondi.org>", "References": "<20200326145927.324919-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 6/6] DNI: libcamera: sensor: ov5670:\n\tAdd lens properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 26 Mar 2020 14:56:36 -0000" }, "content": "Register lens properties in the ov5670 sensor handler.\n\nThis patch is not intended for merge as we know lens properties do no\nbelong to the sensor handler, but I am including it anyhow to trigger\ndiscussions on where they would be more appropriately defined.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/sensor/ov5670.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp\nindex d7339b9792e1..8c6a6114c9bf 100644\n--- a/src/libcamera/sensor/ov5670.cpp\n+++ b/src/libcamera/sensor/ov5670.cpp\n@@ -46,6 +46,12 @@ int OV5670::initProperties()\n \t\t\tproperties::BayerFilterGRBG);\n \tproperties_.set(properties::ISOSensitivityRange, { 50, 800 });\n \n+\t/* Lens Properties. */\n+\tproperties_.set(properties::LensApertures, { 0.0f });\n+\tproperties_.set(properties::LensFocalLengths, { 3.69f });\n+\tproperties_.set(properties::LensHyperfocalDistances, { 0.0f });\n+\tproperties_.set(properties::LensMinimumFocusDistance, 3.69f);\n+\n \treturn CameraSensor::initProperties();\n }\n \n", "prefixes": [ "libcamera-devel", "v4", "6/6" ] }