Patch Detail
Show a patch.
GET /api/1.1/patches/3320/?format=api
{ "id": 3320, "url": "https://patchwork.libcamera.org/api/1.1/patches/3320/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3320/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200325102355.3969245-1-niklas.soderlund@ragnatech.se>", "date": "2020-03-25T10:23:55", "name": "[libcamera-devel] libcamera: pipeline: rkisp1: Do not wait for param buffer it it's not used", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1e06739198bd09957ca0f94578682e936d454e44", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": { "id": 16, "url": "https://patchwork.libcamera.org/api/1.1/users/16/?format=api", "username": "neg", "first_name": "Niklas", "last_name": "Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "mbox": "https://patchwork.libcamera.org/patch/3320/mbox/", "series": [ { "id": 774, "url": "https://patchwork.libcamera.org/api/1.1/series/774/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=774", "date": "2020-03-25T10:23:55", "name": "[libcamera-devel] libcamera: pipeline: rkisp1: Do not wait for param buffer it it's not used", "version": 1, "mbox": "https://patchwork.libcamera.org/series/774/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3320/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3320/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2610F60410\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Mar 2020 11:24:03 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid b98abb11-6e82-11ea-b7d8-005056917a89;\n\tWed, 25 Mar 2020 11:23:56 +0100 (CET)" ], "X-Halon-ID": "b98abb11-6e82-11ea-b7d8-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 25 Mar 2020 11:23:55 +0100", "Message-Id": "<20200325102355.3969245-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Do not wait\n\tfor param buffer it it's not used", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 25 Mar 2020 10:24:03 -0000" }, "content": "If the parameter buffer is not filled in by the IPA and therefor not\nused, mark it as already dequeued. If not a request without a parameter\nbuffer will never complete.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 2f909cef7c75ba0f..6f4eafa1523a4a39 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -351,12 +351,15 @@ protected:\n \t\tif (!info)\n \t\t\tLOG(RkISP1, Fatal) << \"Frame not known\";\n \n-\t\tif (info->paramFilled)\n+\t\tif (info->paramFilled) {\n \t\t\tpipe_->param_->queueBuffer(info->paramBuffer);\n-\t\telse\n+\t\t} else {\n+\t\t\t/* No need to dequeue param if it's never queued. */\n+\t\t\tinfo->paramDequeued = true;\n \t\t\tLOG(RkISP1, Error)\n \t\t\t\t<< \"Parameters not ready on time for frame \"\n \t\t\t\t<< frame() << \", ignore parameters.\";\n+\t\t}\n \n \t\tpipe_->stat_->queueBuffer(info->statBuffer);\n \t\tpipe_->video_->queueBuffer(info->videoBuffer);\n", "prefixes": [ "libcamera-devel" ] }