Patch Detail
Show a patch.
GET /api/1.1/patches/3304/?format=api
{ "id": 3304, "url": "https://patchwork.libcamera.org/api/1.1/patches/3304/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3304/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200324155145.3896183-6-niklas.soderlund@ragnatech.se>", "date": "2020-03-24T15:51:43", "name": "[libcamera-devel,5/7] libcamera: FrameBuffer: Add a setRequest() interface", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "adbcafe49d80f86a02ec7a639274bd78e9b2e9fa", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3304/mbox/", "series": [ { "id": 770, "url": "https://patchwork.libcamera.org/api/1.1/series/770/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=770", "date": "2020-03-24T15:51:39", "name": "libcamera: Add support for a RAW still capture", "version": 1, "mbox": "https://patchwork.libcamera.org/series/770/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3304/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3304/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2ABA62D18\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Mar 2020 16:51:55 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 609056eb-6de7-11ea-b7d8-005056917a89;\n\tTue, 24 Mar 2020 16:51:51 +0100 (CET)" ], "X-Halon-ID": "609056eb-6de7-11ea-b7d8-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 24 Mar 2020 16:51:43 +0100", "Message-Id": "<20200324155145.3896183-6-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200324155145.3896183-1-niklas.soderlund@ragnatech.se>", "References": "<20200324155145.3896183-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 5/7] libcamera: FrameBuffer: Add a\n\tsetRequest() interface", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 24 Mar 2020 15:51:58 -0000" }, "content": "Add the ability to set the Request a buffer is associated with. This is\nneeded for buffers that live inside a pipeline handler and is\ntemporarily associated with a request as it's being processed inside the\npipeline.\n\nWhile we are at it delete a stray semicolon.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/buffer.h | 3 ++-\n src/libcamera/buffer.cpp | 11 +++++++++++\n 2 files changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex ef3a3b36cd4e4e17..6bb2e4f8558f03ac 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -52,7 +52,8 @@ public:\n \tconst std::vector<Plane> &planes() const { return planes_; }\n \n \tRequest *request() const { return request_; }\n-\tconst FrameMetadata &metadata() const { return metadata_; };\n+\tvoid setRequest(Request *request) { request_ = request; }\n+\tconst FrameMetadata &metadata() const { return metadata_; }\n \n \tunsigned int cookie() const { return cookie_; }\n \tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\ndiff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\nindex 0352917e9f2a3202..e9ee4debbf33bdf6 100644\n--- a/src/libcamera/buffer.cpp\n+++ b/src/libcamera/buffer.cpp\n@@ -182,6 +182,17 @@ FrameBuffer::FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie)\n * not associated with a request\n */\n \n+/**\n+ * \\fn FrameBuffer::setRequest()\n+ * \\brief Set the request this buffer belongs to\n+ * \\param[in] request Request to set\n+ *\n+ * The intended callers of this method are pipeline handlers and only for\n+ * buffers that are internal to the pipeline.\n+ *\n+ * \\todo Shall be hidden from applications with a d-pointer design.\n+ */\n+\n /**\n * \\fn FrameBuffer::metadata()\n * \\brief Retrieve the dynamic metadata\n", "prefixes": [ "libcamera-devel", "5/7" ] }