Patch Detail
Show a patch.
GET /api/1.1/patches/3294/?format=api
{ "id": 3294, "url": "https://patchwork.libcamera.org/api/1.1/patches/3294/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3294/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323232901.29169-4-kgupta@es.iitr.ac.in>", "date": "2020-03-23T23:29:01", "name": "[libcamera-devel,3/3] libcamera: pipeline: ipu3: Use parameterized StreamConfiguration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d49d0230805c08f568bdf5b7bf9f11177aa92b2f", "submitter": { "id": 39, "url": "https://patchwork.libcamera.org/api/1.1/people/39/?format=api", "name": "Kaaira Gupta", "email": "kgupta@es.iitr.ac.in" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3294/mbox/", "series": [ { "id": 766, "url": "https://patchwork.libcamera.org/api/1.1/series/766/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=766", "date": "2020-03-23T23:28:58", "name": "Use StreamFormats in pipelines", "version": 1, "mbox": "https://patchwork.libcamera.org/series/766/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3294/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3294/checks/", "tags": {}, "headers": { "Return-Path": "<kgupta@es.iitr.ac.in>", "Received": [ "from mail-pl1-x642.google.com (mail-pl1-x642.google.com\n\t[IPv6:2607:f8b0:4864:20::642])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B782860417\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Mar 2020 00:30:50 +0100 (CET)", "by mail-pl1-x642.google.com with SMTP id h11so6597028plk.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 16:30:50 -0700 (PDT)", "from kaaira-HP-Pavilion-Notebook ([103.113.213.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tx4sm12783546pgi.76.2020.03.23.16.30.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 Mar 2020 16:30:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=1vG2OcOONhiCi516JQ58atnaISi+UA4wXON7pv1Ssck=;\n\tb=EZkdel9Wam2ErzeSCkDHrsO+zKtvHSAJoanTNYVIIjnvPnQ6NXUp5U81skBXs/AvD8\n\tHW31fF+BhkIseZ5sv55hNR2aMyC1LU2K/YpXFijjc7Gp7I1OGxCY8LkXlrjl84HKcuGa\n\tjr8hsrvj1NrCPo+cl4/AiB2RTw+92Fnn58pjuKJ32tFd07B22ffY7RVUWxcLg7U0smfQ\n\txrbBA+nEiM8nP8VD6i1m+0MruyfhPM4+JXpsIV5J3cfZgEkzjbhSZGRhtJ27RES1ax1L\n\tNEolqYQCi9anj+CIyh6A9r+fLnSV+rIFTAOdH4/WaEmFm0Rt48iQchwo0/OOGXmifd3E\n\tHbJQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=1vG2OcOONhiCi516JQ58atnaISi+UA4wXON7pv1Ssck=;\n\tb=V7TZUHl9+Pv+TlD2CP+wMIkN24C2Y9WFOggCug0x8V5Vtwc27gPYWp2EptPKk5TjZw\n\tPTq36WAOV/yWhf4hjv0f/3p6HYtQTHl7Gkc6AVUYMe67NCbplSJyjC79DU0W9Uobub6B\n\tZJnQ4XW1YSidchQgH0aA+RVjBpxfL1zjfm7ykA4vYBJWamdjZ5FMuAAihOVrOosVry0l\n\twnnb47yvn+WHbKSMAJxO9e+nLzvkZKVNaUklSgDA2eVnYEd5HEp39GTcUZ0npuaR104j\n\tDDdCWdTWAfFPDusrvqNW/0dH78Rm82oO6nO4AdhGUsFp46iOzGL5qn0zZpYAxokT7ZL1\n\tH86Q==", "X-Gm-Message-State": "ANhLgQ1eCVNVcA7iWq1jYoT4V9dmXbufFWNwRoU+JjKYX4tObvKrdEs/\n\ty/+MbG+bjavGAvvI0vINO3vV3g==", "X-Google-Smtp-Source": "ADFU+vv+V0LEwPqsqDmjMEDUOsnGSejo4aiDD1EkEInzRLI0zP3qjWP2HsOoggDSgUzc2OZrGIvUrA==", "X-Received": "by 2002:a17:90a:364d:: with SMTP id\n\ts71mr1814998pjb.185.1585006249314; \n\tMon, 23 Mar 2020 16:30:49 -0700 (PDT)", "From": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "To": "libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tHelen Koike <helen.koike@collabora.com>,\n\tVaishali Thakkar <vthakkar@vaishalithakkar.in>", "Cc": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "Date": "Tue, 24 Mar 2020 04:59:01 +0530", "Message-Id": "<20200323232901.29169-4-kgupta@es.iitr.ac.in>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200323232901.29169-1-kgupta@es.iitr.ac.in>", "References": "<20200323232901.29169-1-kgupta@es.iitr.ac.in>", "Subject": "[libcamera-devel] [PATCH 3/3] libcamera: pipeline: ipu3: Use\n\tparameterized StreamConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 23:30:50 -0000" }, "content": "Replace default constructor StreamConfiguration() by it's parameterized\ncounterpart by using StreamFormats in generateConfiguration() in\nipu3.\n\nSigned-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 7feb44c..fe25cab 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -400,9 +400,17 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n \t};\n \n \tconfig = new IPU3CameraConfiguration(camera, data);\n+\tstd::map<PixelFormat, std::vector<SizeRange>> pixelformats;\n+\n+\t/*\n+\t * The driver supports only one pixel format.\n+\t * Size range is kept maximum.\n+\t */\n+\tpixelformats[PixelFormat(DRM_FORMAT_NV12)] = {SizeRange{{ 2560, 1920 }}};\n \n \tfor (const StreamRole role : roles) {\n-\t\tStreamConfiguration cfg = {};\n+\t\tStreamFormats format(pixelformats);\n+\t\tStreamConfiguration cfg(format);\n \t\tIPU3Stream *stream = nullptr;\n \n \t\tcfg.pixelFormat = PixelFormat(DRM_FORMAT_NV12);\n", "prefixes": [ "libcamera-devel", "3/3" ] }