Patch Detail
Show a patch.
GET /api/1.1/patches/3292/?format=api
{ "id": 3292, "url": "https://patchwork.libcamera.org/api/1.1/patches/3292/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3292/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323232901.29169-2-kgupta@es.iitr.ac.in>", "date": "2020-03-23T23:28:59", "name": "[libcamera-devel,1/3] libcamera: pipeline: Replace resize() with erase() in validate()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "83174da100a1ba8e6878309124fb875038832ba3", "submitter": { "id": 39, "url": "https://patchwork.libcamera.org/api/1.1/people/39/?format=api", "name": "Kaaira Gupta", "email": "kgupta@es.iitr.ac.in" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3292/mbox/", "series": [ { "id": 766, "url": "https://patchwork.libcamera.org/api/1.1/series/766/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=766", "date": "2020-03-23T23:28:58", "name": "Use StreamFormats in pipelines", "version": 1, "mbox": "https://patchwork.libcamera.org/series/766/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3292/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3292/checks/", "tags": {}, "headers": { "Return-Path": "<kgupta@es.iitr.ac.in>", "Received": [ "from mail-pf1-x441.google.com (mail-pf1-x441.google.com\n\t[IPv6:2607:f8b0:4864:20::441])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8EAD60417\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Mar 2020 00:29:58 +0100 (CET)", "by mail-pf1-x441.google.com with SMTP id 23so8333615pfj.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 16:29:58 -0700 (PDT)", "from kaaira-HP-Pavilion-Notebook ([103.113.213.154])\n\tby smtp.gmail.com with ESMTPSA id\n\td206sm13816336pfd.160.2020.03.23.16.29.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 Mar 2020 16:29:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=3J5D7TFPdLOULzPBNeyi1SvzT2BqMrZXa+z/CdzZtIM=;\n\tb=tqgWokWkhGppTaw3RTCuC2kdORsvduUaVFDF9KIHKmFJ5fbvxXKJKUDjlS3pdv2f9J\n\tB9l90I6Twp6fcKWgF4/2HBiAfUIBAfj2eFqHf5VczLovjn2Y6IFwXjeC3jv7zAKL5/3q\n\tctmmJBNUluqd1Byp+VYgiWEcEP8cyLtgywvWI+W0dKp4Gl/zpV8dfY+DWL2/q/cEWDlJ\n\t+/NmRdTYV5ZGIKeORkDyl0H0GZl0N3RvAJPr5SBrr4N33mkaIJXKzFYpw9vJwl4CKpdm\n\t8R20yeFfkHa6Nam9a7SbUnEqqgnABhW0u+SLHijdxXlah24M0VlDsOraWofsQQTrV+QZ\n\teRsg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=3J5D7TFPdLOULzPBNeyi1SvzT2BqMrZXa+z/CdzZtIM=;\n\tb=M6Bm5vpbGi5Jv0Q31ytd7joxcb0iuUFCcaKoRh/j1dXPxUZ0ga6+MGqLLIJjta2ZSD\n\tpnfc1ILZDNA/Mvl3VOqRJ6m5s0rgEx6BvQNcaV6Qa0xIhb4uCTnx4WI3v/iJAWi2YLK0\n\tTRnaSICMOfMQ72KWp6mD2vS5KA7NpG2X23oWu1WjF1wc3md+XxllszwG2X3N4se/fwJ5\n\tmk6vsoPri8SzSoT4S+CElIDiAJcFNxhFOkZZlIjt5/uIWNbomh+5I5oVw/LEN+2UnwZM\n\tR/qOF0JuN0ENYVhr0qKCo+BYCuSPBN/efTVM+YdLfKxP1+2Cl2S5A6sd787bYqLkcS1X\n\tkX4w==", "X-Gm-Message-State": "ANhLgQ3yQxx7nDGx8LwhleSdt/iLbfpy+0C+6usgXggx/gfF1m+Bu++u\n\tv7+g3NRjcQ3j3q2niRUv6vEpiA==", "X-Google-Smtp-Source": "ADFU+vvYHp69x8cjJEuUYsdZkVTQw4Jsd5iDSbEKq9GwrHOkknRn5Cp3ZtnlosKXSpZEaclNmUhxRw==", "X-Received": "by 2002:aa7:988f:: with SMTP id\n\tr15mr27219764pfl.252.1585006197027; \n\tMon, 23 Mar 2020 16:29:57 -0700 (PDT)", "From": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "To": "libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tHelen Koike <helen.koike@collabora.com>,\n\tVaishali Thakkar <vthakkar@vaishalithakkar.in>", "Cc": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "Date": "Tue, 24 Mar 2020 04:58:59 +0530", "Message-Id": "<20200323232901.29169-2-kgupta@es.iitr.ac.in>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200323232901.29169-1-kgupta@es.iitr.ac.in>", "References": "<20200323232901.29169-1-kgupta@es.iitr.ac.in>", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: pipeline: Replace resize()\n\twith erase() in validate()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 23:29:58 -0000" }, "content": "Replace .resize() with .erase() in validate() calls in all pipelines,\nbecause resize() calls default constructor StreamConfiguration() when it\ntries to increase the size.\n\nSigned-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +++++++--\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 ++++++--\n src/libcamera/pipeline/uvcvideo.cpp | 8 ++++++--\n src/libcamera/pipeline/vimc.cpp | 8 ++++++--\n 4 files changed, 25 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 1b44460..7feb44c 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -298,9 +298,14 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \tif (config_.empty())\n \t\treturn Invalid;\n \n-\t/* Cap the number of entries to the available streams. */\n+\t/*\n+\t * Cap the number of entries to the available streams.\n+\t * Use erase() instead of resize() because resize() uses default constructor\n+\t * when it increases config_'s size, which we wish to avoid.\n+\t */\n+\n \tif (config_.size() > 2) {\n-\t\tconfig_.resize(2);\n+\t\tconfig_.erase(config_.begin() + 2, config_.end());\n \t\tstatus = Adjusted;\n \t}\n \ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 2f909ce..04b0ed3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -447,9 +447,13 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \tif (config_.empty())\n \t\treturn Invalid;\n \n-\t/* Cap the number of entries to the available streams. */\n+\t/*\n+\t * Cap the number of entries to the available streams.\n+\t * Use erase() instead of resize() because resize() uses default constructor\n+\t * when it increases config_'s size, which we wish to avoid.\n+\t */\n \tif (config_.size() > 1) {\n-\t\tconfig_.resize(1);\n+\t\tconfig_.erase(config_.begin() + 1, config_.end());\n \t\tstatus = Adjusted;\n \t}\n \ndiff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex ffbddf2..462eae2 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -97,9 +97,13 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n \tif (config_.empty())\n \t\treturn Invalid;\n \n-\t/* Cap the number of entries to the available streams. */\n+\t/*\n+\t * Cap the number of entries to the available streams.\n+\t * Use erase() instead of resize() because resize() uses default constructor\n+\t * when it increases config_'s size, which we wish to avoid.\n+\t */\n \tif (config_.size() > 1) {\n-\t\tconfig_.resize(1);\n+\t\tconfig_.erase(config_.begin() + 1, config_.end());\n \t\tstatus = Adjusted;\n \t}\n \ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex b04a972..4c991ff 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -123,9 +123,13 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n \tif (config_.empty())\n \t\treturn Invalid;\n \n-\t/* Cap the number of entries to the available streams. */\n+\t/*\n+\t * Cap the number of entries to the available streams.\n+\t * Use erase() instead of resize() because resize() uses default constructor\n+\t * when it increases config_'s size, which we wish to avoid.\n+\t */\n \tif (config_.size() > 1) {\n-\t\tconfig_.resize(1);\n+\t\tconfig_.erase(config_.begin() + 1, config_.end());\n \t\tstatus = Adjusted;\n \t}\n \n", "prefixes": [ "libcamera-devel", "1/3" ] }