Patch Detail
Show a patch.
GET /api/1.1/patches/3288/?format=api
{ "id": 3288, "url": "https://patchwork.libcamera.org/api/1.1/patches/3288/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3288/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323230024.9761-1-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T23:00:24", "name": "[libcamera-devel] libcamera: v4l2_videodevice: Add support for all 32-bit ARGB formats", "commit_ref": "45f248da7dbd0dc6df02142bfdf99a5d7f5f80a2", "pull_url": null, "state": "accepted", "archived": false, "hash": "5d8cf6f79fd0d4d7cc1c332688729a04b1f17a1c", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3288/mbox/", "series": [ { "id": 763, "url": "https://patchwork.libcamera.org/api/1.1/series/763/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=763", "date": "2020-03-23T23:00:24", "name": "[libcamera-devel] libcamera: v4l2_videodevice: Add support for all 32-bit ARGB formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/763/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3288/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3288/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1008E60414\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Mar 2020 00:00:45 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84EB9308\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Mar 2020 00:00:44 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585004444;\n\tbh=+V1xdjbwvabV7cmzYTaNKHcoXDoC8/RHHUCGSwXDInQ=;\n\th=From:To:Subject:Date:From;\n\tb=iRMJN3ESMb03YBzYCbVJbdacQ1zWAwoablC20fkR35sthZJhC5f9tKNjpMe4Hcdjt\n\t6WyL7CiFjpLynbEKez56ed1qCOh901VySd7T9jbChLitIcGBDdwpCwd5DnKgRN3uIe\n\tMH5nkEx9G1QGoFtZUAwRH68JZkRssm8jCybmMM68=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 24 Mar 2020 01:00:24 +0200", "Message-Id": "<20200323230024.9761-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Add support\n\tfor all 32-bit ARGB formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 23:00:45 -0000" }, "content": "The V4L2VideoDevice class implements conversion between PixelFormat and\nV4L2PixelFormat for a single flavour of the 32-bit ARGB formats. Add the\nthree missing ones.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex b20c8c77260f..b778181a48a4 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1636,8 +1636,14 @@ PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n \t\treturn PixelFormat(DRM_FORMAT_BGR888);\n \tcase V4L2_PIX_FMT_BGR24:\n \t\treturn PixelFormat(DRM_FORMAT_RGB888);\n+\tcase V4L2_PIX_FMT_RGBA32:\n+\t\treturn PixelFormat(DRM_FORMAT_ABGR8888);\n+\tcase V4L2_PIX_FMT_ABGR32:\n+\t\treturn PixelFormat(DRM_FORMAT_ARGB8888);\n \tcase V4L2_PIX_FMT_ARGB32:\n \t\treturn PixelFormat(DRM_FORMAT_BGRA8888);\n+\tcase V4L2_PIX_FMT_BGRA32:\n+\t\treturn PixelFormat(DRM_FORMAT_RGBA8888);\n \n \t/* YUV packed formats. */\n \tcase V4L2_PIX_FMT_YUYV:\n@@ -1720,8 +1726,14 @@ V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelForma\n \t\treturn V4L2PixelFormat(V4L2_PIX_FMT_RGB24);\n \tcase DRM_FORMAT_RGB888:\n \t\treturn V4L2PixelFormat(V4L2_PIX_FMT_BGR24);\n+\tcase DRM_FORMAT_ABGR8888:\n+\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_RGBA32);\n+\tcase DRM_FORMAT_ARGB8888:\n+\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_ABGR32);\n \tcase DRM_FORMAT_BGRA8888:\n \t\treturn V4L2PixelFormat(V4L2_PIX_FMT_ARGB32);\n+\tcase DRM_FORMAT_RGBA8888:\n+\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_BGRA32);\n \n \t/* YUV packed formats. */\n \tcase DRM_FORMAT_YUYV:\n", "prefixes": [ "libcamera-devel" ] }