Patch Detail
Show a patch.
GET /api/1.1/patches/3270/?format=api
{ "id": 3270, "url": "https://patchwork.libcamera.org/api/1.1/patches/3270/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3270/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323173559.21109-5-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T17:35:42", "name": "[libcamera-devel,v2,04/21] qcam: main_window: Move request queuing to a separate function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "66618c9cd7f3303ebf13f7adb11d9025216564de", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3270/mbox/", "series": [ { "id": 762, "url": "https://patchwork.libcamera.org/api/1.1/series/762/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=762", "date": "2020-03-23T17:35:38", "name": "qcam: Bypass format conversion when not required", "version": 2, "mbox": "https://patchwork.libcamera.org/series/762/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3270/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3270/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C150862C75\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:36:17 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B4C6308\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:36:17 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584984977;\n\tbh=sJeSFFq7Y3wN1fGa3MDVBAIi56divZ7+/mskXvU77Kg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=rnqgalPKEtBIYH3EoWijkwDGozrbiqZzFCuK/BC1Ix9cI+vM6H2v+L40MXj8m2Nwo\n\t6A3gEkBCD8Bm7jXiiFH5piQAz0KANwEEXJCz+IyT4zUJKjTbMAxB0p5JCelbuw3FOD\n\t5KLGJ0TaVf1A1cA3t3TRZssOSAHIlbS+Z3a0okA8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Mar 2020 19:35:42 +0200", "Message-Id": "<20200323173559.21109-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>", "References": "<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 04/21] qcam: main_window: Move request\n\tqueuing to a separate function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 17:36:17 -0000" }, "content": "Requests are requeued synchronously from the completion handler. To\nprepare for delayed requeuing, move the queuing to a separate function.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 29 +++++++++++++++--------------\n src/qcam/main_window.h | 1 +\n 2 files changed, 16 insertions(+), 14 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex e0668176e427..354a53367d0f 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -389,20 +389,7 @@ void MainWindow::requestComplete(Request *request)\n \n \tdisplay(buffer);\n \n-\trequest = camera_->createRequest();\n-\tif (!request) {\n-\t\tstd::cerr << \"Can't create request\" << std::endl;\n-\t\treturn;\n-\t}\n-\n-\tfor (auto it = buffers.begin(); it != buffers.end(); ++it) {\n-\t\tStream *stream = it->first;\n-\t\tFrameBuffer *buffer = it->second;\n-\n-\t\trequest->addBuffer(stream, buffer);\n-\t}\n-\n-\tcamera_->queueRequest(request);\n+\tqueueRequest(buffer);\n }\n \n int MainWindow::display(FrameBuffer *buffer)\n@@ -417,3 +404,17 @@ int MainWindow::display(FrameBuffer *buffer)\n \n \treturn 0;\n }\n+\n+void MainWindow::queueRequest(FrameBuffer *buffer)\n+{\n+\tRequest *request = camera_->createRequest();\n+\tif (!request) {\n+\t\tstd::cerr << \"Can't create request\" << std::endl;\n+\t\treturn;\n+\t}\n+\n+\tStream *stream = config_->at(0).stream();\n+\trequest->addBuffer(stream, buffer);\n+\n+\tcamera_->queueRequest(request);\n+}\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex 40aa10aaea8e..720a3393e3dc 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -58,6 +58,7 @@ private:\n \n \tvoid requestComplete(Request *request);\n \tint display(FrameBuffer *buffer);\n+\tvoid queueRequest(FrameBuffer *buffer);\n \n \tQString title_;\n \tQTimer titleTimer_;\n", "prefixes": [ "libcamera-devel", "v2", "04/21" ] }