Patch Detail
Show a patch.
GET /api/1.1/patches/3261/?format=api
{ "id": 3261, "url": "https://patchwork.libcamera.org/api/1.1/patches/3261/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3261/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323142205.28342-19-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T14:22:02", "name": "[libcamera-devel,18/21] qcam: viewfinder: Reorder methods to match header file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7cdb55c217dada6041d7bf764cccf5245610fd82", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3261/mbox/", "series": [ { "id": 760, "url": "https://patchwork.libcamera.org/api/1.1/series/760/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=760", "date": "2020-03-23T14:21:44", "name": "qcam: Bypass format conversion when not required", "version": 1, "mbox": "https://patchwork.libcamera.org/series/760/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3261/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3261/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D51FA62C50\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 15:22:24 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71EDB308\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 15:22:24 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584973344;\n\tbh=GzYLsl6eyJQx444+3aSSH2NunyC0uV2+2hTdSCK3uso=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=FByki+Ffp5tbYOpppDe1IpUbTeR5AC3ivNj11hHg+NkEEgRNrem/X78naqO0HYzp8\n\tyh5PDeM5WtI/MbrDPPaH33VjibN1Q0ShTtRmOcD3A11Flr1trHqVgZYdgjxUTchblF\n\t1FUt1IGXhxtYGPz/hmm3e5gALJicVrHB4mRChC0s=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Mar 2020 16:22:02 +0200", "Message-Id": "<20200323142205.28342-19-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>", "References": "<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 18/21] qcam: viewfinder: Reorder methods\n\tto match header file", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 14:22:28 -0000" }, "content": "Reorder the methods in viewfinder.cpp to match the order in\nviewfinder.h. No code change.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/viewfinder.cpp | 36 ++++++++++++++++++------------------\n 1 file changed, 18 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\nindex c4471ffa4a06..31b358da47dc 100644\n--- a/src/qcam/viewfinder.cpp\n+++ b/src/qcam/viewfinder.cpp\n@@ -24,6 +24,24 @@ ViewFinder::~ViewFinder()\n {\n }\n \n+int ViewFinder::setFormat(const libcamera::PixelFormat &format,\n+\t\t\t const QSize &size)\n+{\n+\tint ret;\n+\n+\tret = converter_.configure(format, size);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tformat_ = format;\n+\tsize_ = size;\n+\n+\timage_ = QImage(size_, QImage::Format_RGB32);\n+\n+\tupdateGeometry();\n+\treturn 0;\n+}\n+\n void ViewFinder::render(libcamera::FrameBuffer *buffer, MappedBuffer *map)\n {\n \tif (buffer->planes().size() != 1) {\n@@ -53,24 +71,6 @@ QImage ViewFinder::getCurrentImage()\n \treturn image_.copy();\n }\n \n-int ViewFinder::setFormat(const libcamera::PixelFormat &format,\n-\t\t\t const QSize &size)\n-{\n-\tint ret;\n-\n-\tret = converter_.configure(format, size);\n-\tif (ret < 0)\n-\t\treturn ret;\n-\n-\tformat_ = format;\n-\tsize_ = size;\n-\n-\timage_ = QImage(size_, QImage::Format_RGB32);\n-\n-\tupdateGeometry();\n-\treturn 0;\n-}\n-\n void ViewFinder::paintEvent(QPaintEvent *)\n {\n \tQPainter painter(this);\n", "prefixes": [ "libcamera-devel", "18/21" ] }