Patch Detail
Show a patch.
GET /api/1.1/patches/3260/?format=api
{ "id": 3260, "url": "https://patchwork.libcamera.org/api/1.1/patches/3260/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3260/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200323142205.28342-18-laurent.pinchart@ideasonboard.com>", "date": "2020-03-23T14:22:01", "name": "[libcamera-devel,17/21] qcam: viewfinder: Use PixelFormat default constructor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "43b2f868515b6d561bcae94e4db981b9b0d81e2d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3260/mbox/", "series": [ { "id": 760, "url": "https://patchwork.libcamera.org/api/1.1/series/760/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=760", "date": "2020-03-23T14:21:44", "name": "qcam: Bypass format conversion when not required", "version": 1, "mbox": "https://patchwork.libcamera.org/series/760/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3260/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3260/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E44662C2B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 15:22:24 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB676A31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 15:22:23 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584973344;\n\tbh=Q4UdvPFVtoI31fxhYLw/8tgK0UG7RFoZBa6ByFz7KL4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=wU3Hg419AdyGmX7X6APrCg1ywgXZeJNfB8GeXaUKrfL23J8gqjuhmG1SOiv4opeYK\n\tyaVMwycDB26bDQPoSoBg4SLDR5Ib0sGt2PA6TxVM+7lbZEflhNYXqOXoE6+HuwJ7IN\n\tNRdVIcIkSN0fXBVgIgOAEx62Cz1flJMGkn/VuvaQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Mar 2020 16:22:01 +0200", "Message-Id": "<20200323142205.28342-18-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>", "References": "<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 17/21] qcam: viewfinder: Use PixelFormat\n\tdefault constructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 23 Mar 2020 14:22:28 -0000" }, "content": "There's no need to initialize the PixelFormat stored in ViewFinder\nexplicitly, as PixelFormat is now a class with a default constructor.\nRemove the initialization.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/viewfinder.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\nindex e7b12015d8f6..c4471ffa4a06 100644\n--- a/src/qcam/viewfinder.cpp\n+++ b/src/qcam/viewfinder.cpp\n@@ -16,7 +16,7 @@\n #include \"format_converter.h\"\n \n ViewFinder::ViewFinder(QWidget *parent)\n-\t: QWidget(parent), format_(0)\n+\t: QWidget(parent)\n {\n }\n \n", "prefixes": [ "libcamera-devel", "17/21" ] }