Patch Detail
Show a patch.
GET /api/1.1/patches/3224/?format=api
{ "id": 3224, "url": "https://patchwork.libcamera.org/api/1.1/patches/3224/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3224/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200320210435.8876-1-laurent.pinchart@ideasonboard.com>", "date": "2020-03-20T21:04:34", "name": "[libcamera-devel,1/2] Revert \"libcamera: controls: Don't over-optimize ControlValue layout\"", "commit_ref": "d6f5621e1501d236e0e1762e5cd055eb3c8af25d", "pull_url": null, "state": "accepted", "archived": false, "hash": "c3c593f93af2c128fa545fb8b2296e3ec9f12108", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3224/mbox/", "series": [ { "id": 751, "url": "https://patchwork.libcamera.org/api/1.1/series/751/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=751", "date": "2020-03-20T21:04:34", "name": "[libcamera-devel,1/2] Revert \"libcamera: controls: Don't over-optimize ControlValue layout\"", "version": 1, "mbox": "https://patchwork.libcamera.org/series/751/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3224/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3224/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57F7960416\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Mar 2020 22:04:45 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF7BC504;\n\tFri, 20 Mar 2020 22:04:44 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584738284;\n\tbh=1lBy6fvpAnsk0xcwQFO4HBmg/T4GaSqsVJcqf55oAcU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=wIhzLgcPDU6HKQL3C6aNLWi0A6+Gn1+O9SVy+PWY33mSvSHXzDneVEVy4+KZ5hv/X\n\tIxx+kTe2WxD0HQKfFxOPYcJtAZBIQdgUH3YF//fCuqCFVbJX2cgxfo1RJGhl9s8Ujj\n\tN6vYm3tmtbXtgWjpkgvYzfq+qkw+IUwlIGTxChnQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 20 Mar 2020 23:04:34 +0200", "Message-Id": "<20200320210435.8876-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] Revert \"libcamera: controls: Don't\n\tover-optimize ControlValue layout\"", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 20 Mar 2020 21:04:45 -0000" }, "content": "This is a partial revert of commit 0028536d70c7, removing a change that\nwas incorrectly squashed.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/device_enumerator_udev.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\nindex f5a482e35b86..87638c59761c 100644\n--- a/src/libcamera/device_enumerator_udev.cpp\n+++ b/src/libcamera/device_enumerator_udev.cpp\n@@ -90,8 +90,7 @@ int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev)\n \t\t\treturn ret;\n \t\t}\n \n-\t\tif (!ret)\n-\t\t\taddDevice(media);\n+\t\taddDevice(media);\n \t\treturn 0;\n \t}\n \n", "prefixes": [ "libcamera-devel", "1/2" ] }