Patch Detail
Show a patch.
GET /api/1.1/patches/3216/?format=api
{ "id": 3216, "url": "https://patchwork.libcamera.org/api/1.1/patches/3216/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3216/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200320014839.14683-9-laurent.pinchart@ideasonboard.com>", "date": "2020-03-20T01:48:36", "name": "[libcamera-devel,v3,08/11] libcamera: v4l2_videodevice: Map V4L2_PIX_FMT_GREY to DRM FourCC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "997dd83e263f9eb7e3ec00bde0d7b51037bfbf88", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3216/mbox/", "series": [ { "id": 749, "url": "https://patchwork.libcamera.org/api/1.1/series/749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=749", "date": "2020-03-20T01:48:28", "name": "Simple pipeline handler", "version": 3, "mbox": "https://patchwork.libcamera.org/series/749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3216/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3216/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E323F62BC2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Mar 2020 02:48:55 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 597EA18AB;\n\tFri, 20 Mar 2020 02:48:55 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584668935;\n\tbh=mP8fGJzMW09w+sz4Yzq5tIo7BkI++ua/d5218B8eAUI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ValTTv2t9Q1hNSg2MxZogi5sbfnCv3YnPVRBv6SmGTtu9TcX6iTlVhKl2lvtSbkAQ\n\tJbTeNTddZ3ki0y+y58xwnm4tSwxHaUNIHeU56teC5HIf+dIdECfWN/LWXctkYfzNot\n\t1AJhP0/0ezpNBzUcykPCaAR4I+JV5o1INHtD9h28=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Martijn Braam <martijn@brixit.nl>,\n\tBenjamin GAIGNARD <benjamin.gaignard@st.com>,\n\tAndrey Konovalov <andrey.konovalov@linaro.org>", "Date": "Fri, 20 Mar 2020 03:48:36 +0200", "Message-Id": "<20200320014839.14683-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>", "References": "<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 08/11] libcamera: v4l2_videodevice: Map\n\tV4L2_PIX_FMT_GREY to DRM FourCC", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 20 Mar 2020 01:48:56 -0000" }, "content": "DRM has a format for 8-bit greyscale data, DRM_FORMAT_R8. Despite the\n'R' name, which comes from GL/Vulkan to mean single-channel data, the\nformat maps to greyscale for display. We can thus map it to\nV4L2_PIX_FMT_GREY.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v2:\n\n- Rebase on top of PixelFormat class\n---\n src/libcamera/v4l2_videodevice.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 180eb192a951..d0fb3fa2ffe4 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1679,12 +1679,15 @@ PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n \tcase V4L2_PIX_FMT_NV21M:\n \t\treturn PixelFormat(DRM_FORMAT_NV21);\n \n+\t/* Greyscale formats. */\n+\tcase V4L2_PIX_FMT_GREY:\n+\t\treturn PixelFormat(DRM_FORMAT_R8);\n+\n \t/* Compressed formats. */\n \tcase V4L2_PIX_FMT_MJPEG:\n \t\treturn PixelFormat(DRM_FORMAT_MJPEG);\n \n \t/* V4L2 formats not yet supported by DRM. */\n-\tcase V4L2_PIX_FMT_GREY:\n \tdefault:\n \t\t/*\n \t\t * \\todo We can't use LOG() in a static method of a Loggable\n@@ -1764,6 +1767,10 @@ V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelForma\n \tcase DRM_FORMAT_NV21:\n \t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV21);\n \n+\t/* Greyscale formats. */\n+\tcase DRM_FORMAT_R8:\n+\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_GREY);\n+\n \t/* Compressed formats. */\n \tcase DRM_FORMAT_MJPEG:\n \t\treturn V4L2PixelFormat(V4L2_PIX_FMT_MJPEG);\n", "prefixes": [ "libcamera-devel", "v3", "08/11" ] }