Patch Detail
Show a patch.
GET /api/1.1/patches/3174/?format=api
{ "id": 3174, "url": "https://patchwork.libcamera.org/api/1.1/patches/3174/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3174/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200318152427.13126-5-kgupta@es.iitr.ac.in>", "date": "2020-03-18T15:24:26", "name": "[libcamera-devel,v4,4/5] libcamera: ipa_proxy: search for proxy in build tree", "commit_ref": "250df52bd914ac6af287035e1adcd497c36a38f0", "pull_url": null, "state": "accepted", "archived": false, "hash": "7df9a2108d53751a34b323ac87e80d6f54472711", "submitter": { "id": 39, "url": "https://patchwork.libcamera.org/api/1.1/people/39/?format=api", "name": "Kaaira Gupta", "email": "kgupta@es.iitr.ac.in" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3174/mbox/", "series": [ { "id": 733, "url": "https://patchwork.libcamera.org/api/1.1/series/733/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=733", "date": "2020-03-18T15:24:22", "name": "libcamera: determine IPA_PROXY_PATH at runtime", "version": 4, "mbox": "https://patchwork.libcamera.org/series/733/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3174/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3174/checks/", "tags": {}, "headers": { "Return-Path": "<kgupta@es.iitr.ac.in>", "Received": [ "from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com\n\t[IPv6:2607:f8b0:4864:20::1041])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D239A60418\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Mar 2020 16:26:02 +0100 (CET)", "by mail-pj1-x1041.google.com with SMTP id q16so1218734pje.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Mar 2020 08:26:02 -0700 (PDT)", "from kaaira-HP-Pavilion-Notebook ([103.113.213.153])\n\tby smtp.gmail.com with ESMTPSA id\n\tu5sm7214223pfb.153.2020.03.18.08.26.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 18 Mar 2020 08:26:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=TPOnO1Baqw2NxGiMYoMTR+sB7IXQHbkW77ALodIj+fg=;\n\tb=YA0O2C5v5+Zx0SFeBLgNGTbM3oyIZ8+Hqg6r9y0gfw9F7APw6nC4iZTEwBH5JZ7UlX\n\tEaSMBtweGEaHon5egBKEakTinF81DtdTNg+X2wp8Z21+vv7umuY4KXnEcd2DIFGUGvnl\n\tW1VHypiIwIpiTpoY3Yki0ebkjEOuohj+/TTsjpW1UXW/coFdTohrPkjJM0rV2mAKahzl\n\tNw4XF4FseKFclUaOlQXKyhFayDY1rd6eZfSvTnrLBXg8fj76WwuU1CGulzCCoDyuYde8\n\tFrcZoiy8NaRKuvuVXEpWtNvlgol2RnlEQsRQqNtbGDEG15GbkNgdF0+5UQtfVmvvv5O5\n\t0P0A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=TPOnO1Baqw2NxGiMYoMTR+sB7IXQHbkW77ALodIj+fg=;\n\tb=HuiziyxAZXMmOEMOtShRLJxkpGVonPUkLilq01hCJUXZG/fa83l0khlaZbnBr5Wo4k\n\tS8MX2GT30a2LPaRldrt5bga12kdwb4PI2mkGDxKE5LKJrVtuGO1SLHED5azFvWmyJLI4\n\tmsFmdiKhwSkRFcpqyHTsQHa/sWHI/mnRsWZjt2y6H0ZdHUKb0OzPkJdaGdeVu/wAxBrK\n\tXARyBVFK5ZYmy3BS9iRFDcdC45HKe7dhCECzE6feap4raQMEgeGCagv+b6brZgC5u3XP\n\tQ/CLN/+eFJBaR/GZWPNxOYRXd+0nU8irt08DhXFezEgaoZG0pIhi3vTf2k9WDIwaJHyZ\n\t2Gpg==", "X-Gm-Message-State": "ANhLgQ0P2nY8lH2ucADRly7TrpowO1xlGNidfUZ2DVcXvVCOPkisKLTH\n\tut6DYHxXMekq8vZAYzAmbK4Z2g==", "X-Google-Smtp-Source": "ADFU+vvtkFfPnNf8KkKiDl14CTpzHgJ9l+ZJifLQFgUFWp+c1PlwvgE/z+6baelTR/ZrvTwSqzhVmQ==", "X-Received": "by 2002:a17:90a:22a9:: with SMTP id\n\ts38mr5033980pjc.3.1584545161394; \n\tWed, 18 Mar 2020 08:26:01 -0700 (PDT)", "From": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "To": "Vaishali Thakkar <vthakkar@vaishalithakkar.in>,\n\tHelen Koike <helen.koike@collabora.com>,\n\tkieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org", "Cc": "Kaaira Gupta <kgupta@es.iitr.ac.in>", "Date": "Wed, 18 Mar 2020 20:54:26 +0530", "Message-Id": "<20200318152427.13126-5-kgupta@es.iitr.ac.in>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200318152427.13126-1-kgupta@es.iitr.ac.in>", "References": "<20200318152427.13126-1-kgupta@es.iitr.ac.in>", "Subject": "[libcamera-devel] [PATCH LIBCAMERA v4 4/5] libcamera: ipa_proxy:\n\tsearch for proxy in build tree", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 18 Mar 2020 15:26:03 -0000" }, "content": "When libcamera is built and tested before installing, it will\nbe unable to locate the path to proxy workers, or previously\ninstalled files in the system path may be incorrect to load.\n\nHence, when libcamera is not installed, but is running from a build\ntree, identify the location of that tree by using libcameraPath(), and\nfrom that point add relative path to the proxy workers directory.\n\nSigned-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>\n---\n src/libcamera/ipa_proxy.cpp | 23 ++++++++++++++++++++++-\n 1 file changed, 22 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex b409e1d..2f866cc 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -91,7 +91,28 @@ std::string IPAProxy::resolvePath(const std::string &file) const\n \t\t}\n \t}\n \n-\t/* Try finding the exec target from the install directory. */\n+\t/*\n+\t * When libcamera is used before it is installed, load proxy workers\n+\t * from the same build directory as the libcamera directory itself.\n+\t * This requires identifying the path of the libcamera.so, and\n+\t * referencing a relative path for the proxy workers from that point.\n+\t */\n+\tif (!utils::isLibcameraInstalled()) {\n+\t\tstd::string ipaProxyDir = utils::dirname(utils::libcameraPath())\n+\t\t\t\t\t + \"/proxy/worker\";\n+\n+\t\tLOG(IPAProxy, Info)\n+\t\t\t<< \"libcamera is not installed. Loading proxy workers from'\"\n+\t\t\t<< ipaProxyDir << \"'\";\n+\n+\t\tstd::string proxyPath = ipaProxyDir + proxyFile;\n+\t\tif (!access(proxyPath.c_str(), X_OK))\n+\t\t\treturn proxyPath;\n+\n+\t\treturn std::string();\n+\t}\n+\n+\t/* Else try finding the exec target from the install directory. */\n \tstd::string proxyPath = std::string(IPA_PROXY_DIR) + proxyFile;\n \tif (!access(proxyPath.c_str(), X_OK))\n \t\treturn proxyPath;\n", "prefixes": [ "libcamera-devel", "v4", "4/5" ] }