Patch Detail
Show a patch.
GET /api/1.1/patches/3133/?format=api
{ "id": 3133, "url": "https://patchwork.libcamera.org/api/1.1/patches/3133/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3133/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200317035239.2697679-3-niklas.soderlund@ragnatech.se>", "date": "2020-03-17T03:52:33", "name": "[libcamera-devel,v2,2/8] test: v4l2_videodevice: buffer_cache: Use DRM pixel format", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0412a204574d5dd7ad68aa4d805c9cc2b860e1a4", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3133/mbox/", "series": [ { "id": 726, "url": "https://patchwork.libcamera.org/api/1.1/series/726/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=726", "date": "2020-03-17T03:52:31", "name": "libcamera: PixelFormat: Turn into a class", "version": 2, "mbox": "https://patchwork.libcamera.org/series/726/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3133/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3133/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4350262992\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Mar 2020 04:53:37 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid da6e2ac4-6802-11ea-aa6d-005056917f90;\n\tTue, 17 Mar 2020 04:53:25 +0100 (CET)" ], "X-Halon-ID": "da6e2ac4-6802-11ea-aa6d-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 17 Mar 2020 04:52:33 +0100", "Message-Id": "<20200317035239.2697679-3-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200317035239.2697679-1-niklas.soderlund@ragnatech.se>", "References": "<20200317035239.2697679-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/8] test: v4l2_videodevice:\n\tbuffer_cache: Use DRM pixel format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 17 Mar 2020 03:53:37 -0000" }, "content": "The pixel format used in the stream configuration is from V4L2 but\nshould be from DRM, fix it.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n test/v4l2_videodevice/buffer_cache.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp\nindex 0a8cb0d28ca9b204..c951bc9650dc4e0e 100644\n--- a/test/v4l2_videodevice/buffer_cache.cpp\n+++ b/test/v4l2_videodevice/buffer_cache.cpp\n@@ -11,6 +11,8 @@\n \n #include <libcamera/stream.h>\n \n+#include <linux/drm_fourcc.h>\n+\n #include \"buffer_source.h\"\n \n #include \"test.h\"\n@@ -142,7 +144,7 @@ public:\n \t\tconst unsigned int numBuffers = 8;\n \n \t\tStreamConfiguration cfg;\n-\t\tcfg.pixelFormat = V4L2_PIX_FMT_YUYV;\n+\t\tcfg.pixelFormat = DRM_FORMAT_YUYV;\n \t\tcfg.size = Size(600, 800);\n \t\tcfg.bufferCount = numBuffers;\n \n", "prefixes": [ "libcamera-devel", "v2", "2/8" ] }