Patch Detail
Show a patch.
GET /api/1.1/patches/3090/?format=api
{ "id": 3090, "url": "https://patchwork.libcamera.org/api/1.1/patches/3090/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3090/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200313233856.25202-7-laurent.pinchart@ideasonboard.com>", "date": "2020-03-13T23:38:54", "name": "[libcamera-devel,6/8] libcamera: v4l2_videodevice: Downgrade 4CC conversion errors to warnings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e7ca8d46ae58afc8c1c9218728a0afed65278925", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3090/mbox/", "series": [ { "id": 718, "url": "https://patchwork.libcamera.org/api/1.1/series/718/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=718", "date": "2020-03-13T23:38:48", "name": "Simple pipeline handler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/718/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3090/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3090/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E1EC62826\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 14 Mar 2020 00:39:08 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C272F1854;\n\tSat, 14 Mar 2020 00:39:07 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584142748;\n\tbh=ntkBsA9pLZuz2jgxwEgP5mGrgPBqce/PuPPjrfLPvdw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dQn0AqDPrgpuzJibZvGnynjnjmr8CiVh/jEP3MgCn9J+L9lBdCDa98vZcOSTsrEsR\n\tGXzen8yg2v0Qy9LIWig+xuMm7stYDO8fjVqKAdnwTX9jfpfx0dBdVaiEu0R0EgQN70\n\tMbl1vYqtnzl3W3WNXKRImrlmp7l/oljJTXjEDEKA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Martijn Braam <martijn@brixit.nl>,\n\tAndrey Konovalov <andrey.konovalov@linaro.org>,\n\tMickael GUENE <mickael.guene@st.com>,\n\tBenjamin GAIGNARD <benjamin.gaignard@st.com>", "Date": "Sat, 14 Mar 2020 01:38:54 +0200", "Message-Id": "<20200313233856.25202-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200313233856.25202-1-laurent.pinchart@ideasonboard.com>", "References": "<20200313233856.25202-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 6/8] libcamera: v4l2_videodevice:\n\tDowngrade 4CC conversion errors to warnings", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 13 Mar 2020 23:39:09 -0000" }, "content": "Failing to convert between V4L2 and DRM 4CCs indicates something is\nlikely wrong, but doesn't necessarily prevent the camera from being\nusable. It may for instance only limit the number of supported formats.\nDowngrade the related log messages from LogError to LogWarning.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 86b262ba2436..f68b67b33293 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1485,7 +1485,7 @@ PixelFormat V4L2VideoDevice::toPixelFormat(uint32_t v4l2Fourcc)\n \t\t * class. Until we fix the logger, work around it.\n \t\t */\n \t\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n-\t\t\t\tLogError).stream()\n+\t\t\t\tLogWarning).stream()\n \t\t\t<< \"Unsupported V4L2 pixel format \"\n \t\t\t<< utils::hex(v4l2Fourcc);\n \t\treturn 0;\n@@ -1566,7 +1566,8 @@ uint32_t V4L2VideoDevice::toV4L2Fourcc(PixelFormat pixelFormat, bool multiplanar\n \t * \\todo We can't use LOG() in a static method of a Loggable\n \t * class. Until we fix the logger, work around it.\n \t */\n-\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(), LogError).stream()\n+\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n+\t\t\tLogWarning).stream()\n \t\t<< \"Unsupported V4L2 pixel format \"\n \t\t<< utils::hex(pixelFormat);\n \treturn 0;\n", "prefixes": [ "libcamera-devel", "6/8" ] }