Patch Detail
Show a patch.
GET /api/1.1/patches/3083/?format=api
{ "id": 3083, "url": "https://patchwork.libcamera.org/api/1.1/patches/3083/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3083/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200309180444.725757-7-jacopo@jmondi.org>", "date": "2020-03-09T18:04:44", "name": "[libcamera-devel,v3,6/6] DNI: libcamera: sensor: ov5670: Add lens properties", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2d0031d0b783ef13a002a21ab8524f7f89c63602", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3083/mbox/", "series": [ { "id": 717, "url": "https://patchwork.libcamera.org/api/1.1/series/717/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=717", "date": "2020-03-09T18:04:38", "name": "Camera properties and camera sensor factory", "version": 3, "mbox": "https://patchwork.libcamera.org/series/717/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3083/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3083/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28F4A62923\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Mar 2020 19:02:11 +0100 (CET)", "from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DE9B54000C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Mar 2020 18:02:10 +0000 (UTC)" ], "X-Originating-IP": "93.34.114.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 9 Mar 2020 19:04:44 +0100", "Message-Id": "<20200309180444.725757-7-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200309180444.725757-1-jacopo@jmondi.org>", "References": "<20200309180444.725757-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 6/6] DNI: libcamera: sensor: ov5670:\n\tAdd lens properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 09 Mar 2020 18:02:12 -0000" }, "content": "Register lens properties in the ov5670 sensor handler.\n\nThis patch is not intended for merge as we know lens properties do no\nbelong to the sensor handler, but I am including it anyhow to trigger\ndiscussions on where they would be more appropriately defined.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nv2 -> v3:\n- Update to use new properties names\n---\n src/libcamera/sensor/ov5670.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp\nindex a027a0816e58..75ad1f3ce81f 100644\n--- a/src/libcamera/sensor/ov5670.cpp\n+++ b/src/libcamera/sensor/ov5670.cpp\n@@ -52,6 +52,12 @@ int OV5670::initProperties()\n \t\t\tproperties::BayerFilterGRBG);\n \tproperties_.set(properties::ISOSensitivityRange, { 50, 800 });\n \n+\t/* Lens Properties. */\n+\tproperties_.set(properties::LensApertures, { 0.0f });\n+\tproperties_.set(properties::LensFocalLengths, { 3.69f });\n+\tproperties_.set(properties::LensHyperfocalDistances, { 0.0f });\n+\tproperties_.set(properties::LensMinimumFocusDistance, 3.69f);\n+\n \treturn CameraSensor::initProperties();\n }\n \n", "prefixes": [ "libcamera-devel", "v3", "6/6" ] }