Patch Detail
Show a patch.
GET /api/1.1/patches/3078/?format=api
{ "id": 3078, "url": "https://patchwork.libcamera.org/api/1.1/patches/3078/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3078/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200309180444.725757-2-jacopo@jmondi.org>", "date": "2020-03-09T18:04:39", "name": "[libcamera-devel,v3,1/6] libcamera: properties: Define pixel array properties", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "62f27aedc927f48c6ee449ad2b5c11f04f0483cd", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3078/mbox/", "series": [ { "id": 717, "url": "https://patchwork.libcamera.org/api/1.1/series/717/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=717", "date": "2020-03-09T18:04:38", "name": "Camera properties and camera sensor factory", "version": 3, "mbox": "https://patchwork.libcamera.org/series/717/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3078/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3078/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8127628BD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Mar 2020 19:02:08 +0100 (CET)", "from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 7FADE40005\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Mar 2020 18:02:08 +0000 (UTC)" ], "X-Originating-IP": "93.34.114.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 9 Mar 2020 19:04:39 +0100", "Message-Id": "<20200309180444.725757-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200309180444.725757-1-jacopo@jmondi.org>", "References": "<20200309180444.725757-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/6] libcamera: properties: Define\n\tpixel array properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 09 Mar 2020 18:02:08 -0000" }, "content": "Add definition of pixel array related properties.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nv2 -> v3:\n- Pluralize PixelAreaSizes\n- Use the new 'size' property in place of 'compound'.\n I tried to set meaningful values but it's not easy to get them right..\n---\n src/libcamera/property_ids.yaml | 177 ++++++++++++++++++++++++++++++++\n 1 file changed, 177 insertions(+)", "diff": "diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex ce627fa042ba..4cecb5ad9ac3 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -386,4 +386,181 @@ controls:\n | |\n | |\n +--------------------+\n+\n+ - PixelArraySize:\n+ type: float\n+ size: [2]\n+ description: |\n+ The physical sizes of the pixel array (width and height), in\n+ millimeters.\n+\n+ - PixelArrayBounds:\n+ type: int32_t\n+ size: [2]\n+ description: |\n+ The camera sensor pixel array bounding rectangle vertical and\n+ horizontal sizes.\n+\n+ For image sensors with a rectangular pixel array the sizes described by\n+ this property are the same as the PixelAreaSize property size.\n+\n+ For image sensors with more complex pixel array displacements (such as\n+ cross-shaped pixel arrays, non symmetrical pixel arrays etc) this\n+ property represents the bounding rectangle in which all pixel array\n+ dimensions are inscribed into.\n+\n+ In example, the bounding rectangle sizes for image sensor with a\n+ cross-shaped pixel array is described as\n+\n+\n+ PixelArrayBound(0) = width\n+ /-----------------/\n+\n+ (0,0)-> +----+------+----+ /\n+ | |//////| | |\n+ +----+//////+----+ |\n+ |////////////////| | PixelArrayBound(1) = height\n+ +----+//////+----+ |\n+ | |//////| | |\n+ +----+------+----+ /\n+ |\n+ -> Cross-shaped pixel area\n+\n+ - PixelArrays:\n+ type: int32_t\n+ size: [8]\n+ description: |\n+ The sensor pixel array rectangles, relative to the rectangle described\n+ by the PixelArrayBounds property.\n+\n+ This property describes an arbitrary number of (likely overlapping)\n+ rectangles, representing the pixel array areas the sensor is composed\n+ of.\n+\n+ Each rectangle is defined by its displacement from pixel (0, 0) of\n+ the bounding rectangle described by the PixelArrayBound property.\n+\n+ For image sensors with a rectangular pixel array, a single rectangle\n+ is required. For sensors with more complex pixel array displacements\n+ multiple rectangles shall be specified, ordered from the tallest to the\n+ shorter one.\n+\n+ For each rectangle, this property reports the full pixel array size,\n+ including non-active pixels, black level calibration pixels etc.\n+\n+ In example, a simple sensor with a rectangular pixel array is described\n+ as\n+\n+ PixelArrayBound(0) = width\n+ /-----------------/\n+ x1 x2\n+ (0,0)-> +-o------------o-+ /\n+ y1 o +------------+ | |\n+ | |////////////| | |\n+ | |////////////| | | PixelArrayBound(1) = height\n+ | |////////////| | |\n+ y2 o +------------+ | |\n+ +----------------+ /\n+\n+ PixelArray = (x1, y1, (x2 - x1), (y2 - y1))\n+\n+ A more complex sensor, with a cross shaped pixel array displacement\n+ is described with 2 rectangles, with the vertical rectangle\n+ described first\n+\n+ PixelArrayBound(0) = width\n+ /-----------------/\n+ x1 x2 x3 x4 W\n+ (0,0)-> +o---o------o---o+ /\n+ | |//////| | |\n+ y1 o+---+------+---+| |\n+ ||///|//////|///|| | PixelArrayBound(1) = height\n+ y2 o+---+------+---+| |\n+ | |//////| | |\n+ H +----+------+----+ /\n+\n+\n+ PixelArray = ( (x2, 0, (x3 - x2), H),\n+ (x1, y1, (x4 - x1), (y2 - y1))\n+\n+ - ActiveAreaSizes:\n+ type: int32_t\n+ size: [8]\n+ description: |\n+ The sensor active pixel area sizes, represented as rectangles\n+ inscribed in the ones described by the PixelArrays property.\n+\n+ One ActiveAreaSize rectangle per each rectangle described in the\n+ PixelArrays property is required. As a consequence, the two properties\n+ shall transport the same number of elements.\n+\n+ The ActiveAreaSize rectangles represent the maximum image sizes the\n+ sensor can produce.\n+\n+ - BayerFilterArrangement:\n+ type: int32_t\n+ description: |\n+ The pixel array color filter displacement.\n+\n+ This property describes the arrangement and readout sequence of the\n+ three RGB color components of the sensor's Bayer Color Filter Array\n+ (CFA).\n+\n+ Color filters are usually displaced in line-alternating fashion on the\n+ sensor pixel array. In example, one line might be composed of Red-Green\n+ while the successive is composed of Blue-Green color information.\n+\n+ The value of this property represent the arrangement of color filters\n+ in the top-left 2x2 pixel square.\n+\n+ In example, for a sensor with the following color filter displacement\n+\n+ (0, 0) (max-col)\n+ +---+ +--------------...---+\n+ |B|G|<---|B|G|B|G|B|G|B|...B|G|\n+ |G|R|<---|G|R|G|R|G|R|G|...G|R|\n+ +---+ |B|G|B|G|B|G|B|...B|G|\n+ ... ..\n+ ... ..\n+ |G|R|G|R|G|R|G|...G|R|\n+ |B|G|B|G|B|G|B|...B|G| (max-lines)\n+ +--------------...---+\n+\n+ The filer arrangement is represented by the BGGR value, which correspond\n+ to the pixel readout sequence in line interleaved mode.\n+\n+ enum:\n+ - name: BayerFilterRGGB\n+ value: 0\n+ description: |\n+ Color filter array displacement is Red-Green/Green-Blue\n+\n+ - name: BayerFilterGRBG\n+ value: 1\n+ description: |\n+ Color filter array displacement is Green-Red/Blue-Green\n+\n+ - name: BayerFilterGBRG\n+ value: 2\n+ description: |\n+ Color filter array displacement is Green-Blue/Red-Green\n+\n+ - name: BayerFilterBGGR\n+ value: 3\n+ description: |\n+ Color filter array displacement is Blue-Green/Green-Red\n+\n+ - name: BayerFilterNonStandard\n+ value: 4\n+ description: |\n+ The pixel array color filter does not use the standard Bayer RGB\n+ color model\n+\n+ - ISOSensitivityRange:\n+ type: int32_t\n+ size: [2]\n+ description: |\n+ The range of supported ISO sensitivities, as documented by the\n+ ISO 12232:2006 standard\n+\n ...\n", "prefixes": [ "libcamera-devel", "v3", "1/6" ] }