Patch Detail
Show a patch.
GET /api/1.1/patches/3038/?format=api
{ "id": 3038, "url": "https://patchwork.libcamera.org/api/1.1/patches/3038/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3038/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200307191634.9320-2-laurent.pinchart@ideasonboard.com>", "date": "2020-03-07T19:16:33", "name": "[libcamera-devel,v2,1/2] gst: Turn the top-level plugin file gstlibcamera.c into a C++ file", "commit_ref": "f36ecf98247a81a322faded4f9b25f06fcbe4ccd", "pull_url": null, "state": "accepted", "archived": false, "hash": "5dd0b94cac9baf3be11c2fb93fb268e18d051fc9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3038/mbox/", "series": [ { "id": 709, "url": "https://patchwork.libcamera.org/api/1.1/series/709/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=709", "date": "2020-03-07T19:16:32", "name": "Fix GStreamer element compilation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/709/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3038/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3038/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A7F560425\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 7 Mar 2020 20:16:42 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70D7924B;\n\tSat, 7 Mar 2020 20:16:41 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583608601;\n\tbh=GW9zIz5zcgUVY3b4ID2/FOJcEVpeoE9tedqFnR8bV8c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ttv5VydLDA/J15VSBYFR4K5hHgMvcZT6FMEWXjPbOpD2s07viaXnrm1jJsr5yIh8r\n\tZnlVlTL1AttZ2EJtRThDbO4KZBWulEXRwzd6rgz/EdbAFvZFWE0r2hMmHQyWl4EQNx\n\tNpzpfdHj+j5YZRwQeWeyFyw2ss9b13kvZHhoAhJ4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "Cc": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 7 Mar 2020 21:16:33 +0200", "Message-Id": "<20200307191634.9320-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200307191634.9320-1-laurent.pinchart@ideasonboard.com>", "References": "<20200307191634.9320-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/2] gst: Turn the top-level plugin\n\tfile gstlibcamera.c into a C++ file", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 07 Mar 2020 19:16:42 -0000" }, "content": "The top-level plugin file gstlibcamera.c is the only C source file in\nthe whole libcamera GStreamer element. To avoid specifying both C and\nC++ compiler arguments in the future, turn it into a C++ file.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/{gstlibcamera.c => gstlibcamera.cpp} | 0\n src/gstreamer/meson.build | 8 ++++----\n 2 files changed, 4 insertions(+), 4 deletions(-)\n rename src/gstreamer/{gstlibcamera.c => gstlibcamera.cpp} (100%)", "diff": "diff --git a/src/gstreamer/gstlibcamera.c b/src/gstreamer/gstlibcamera.cpp\nsimilarity index 100%\nrename from src/gstreamer/gstlibcamera.c\nrename to src/gstreamer/gstlibcamera.cpp\ndiff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\nindex 1965b5041132..8759a12205fa 100644\n--- a/src/gstreamer/meson.build\n+++ b/src/gstreamer/meson.build\n@@ -1,6 +1,6 @@\n libcamera_gst_sources = [\n 'gstlibcamera-utils.cpp',\n- 'gstlibcamera.c',\n+ 'gstlibcamera.cpp',\n 'gstlibcameraallocator.cpp',\n 'gstlibcamerapad.cpp',\n 'gstlibcamerapool.cpp',\n@@ -8,7 +8,7 @@ libcamera_gst_sources = [\n 'gstlibcamerasrc.cpp',\n ]\n \n-libcamera_gst_c_args = [\n+libcamera_gst_cpp_args = [\n '-DVERSION=\"@0@\"'.format(libcamera_git_version),\n '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n ]\n@@ -27,12 +27,12 @@ if glib_dep.found() and gstvideo_dep.found() and gstallocator_dep.found()\n # complain about the ones we are not using. Silence the -Wunused-function\n # warning in that case.\n if cc.get_id() == 'clang' and glib_dep.version().version_compare('<2.63.0')\n- libcamera_gst_c_args += [ '-Wno-unused-function' ]\n+ libcamera_gst_cpp_args += [ '-Wno-unused-function' ]\n endif\n \n libcamera_gst = shared_library('gstlibcamera',\n libcamera_gst_sources,\n- c_args : libcamera_gst_c_args,\n+ cpp_args : libcamera_gst_cpp_args,\n dependencies : [libcamera_dep, gstvideo_dep, gstallocator_dep],\n install: true,\n install_dir : '@0@/gstreamer-1.0'.format(get_option('libdir')),\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }