Patch Detail
Show a patch.
GET /api/1.1/patches/3036/?format=api
{ "id": 3036, "url": "https://patchwork.libcamera.org/api/1.1/patches/3036/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3036/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200307003310.29372-1-laurent.pinchart@ideasonboard.com>", "date": "2020-03-07T00:33:10", "name": "[libcamera-devel] gst: Fix GLib detection and warning disabling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f55801641f69ea712c599a120e1ddba3b6d95599", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/1.1/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/3036/mbox/", "series": [ { "id": 708, "url": "https://patchwork.libcamera.org/api/1.1/series/708/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=708", "date": "2020-03-07T00:33:10", "name": "[libcamera-devel] gst: Fix GLib detection and warning disabling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/708/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3036/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3036/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 631F060427\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 7 Mar 2020 01:33:18 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B611D24B;\n\tSat, 7 Mar 2020 01:33:17 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583541197;\n\tbh=M4wXYx8+hpyUTwzJ0Wt9Wkov2DR7LMSEXVzXBUXr/aI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=UnP1yUrc2DkgHtFOr1LH4Z26DYIHnnnenfH/roUhxjJVzMvKtgwC/uIP6kAL9feWh\n\thJGlcBkQat45Y2jtwtlvJ32KMyERhnc3xh//AP72ja+kBQ0JIF7FlLTNm5ahjqBbPD\n\tAC2wLPnDy0w/oNBaiJkQ5bdS+3BkNmR4LqdGs4uI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "Cc": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 7 Mar 2020 02:33:10 +0200", "Message-Id": "<20200307003310.29372-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] gst: Fix GLib detection and warning\n\tdisabling", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 07 Mar 2020 00:33:18 -0000" }, "content": "Commit 17cccc68a88f (\"Add GStreamer plugin and element skeleton\") has\ngained a last minute fix for a clang compilation error with GLib prior\nto v2.63.0. The fix wasn't properly tested, and not only did it try to\nsilence the affected compiler warning for C files only, it also failed\nto check the GLib dependency correctly. This resulted in compilation of\nthe GStreamer element to always be disabled.\n\nFix this by changing the GLib package name from 'glib' to 'glib-2.0',\nand silence the compiler warning for C++ files.\n\nFixes: 17cccc68a88f (\"Add GStreamer plugin and element skeleton\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/meson.build | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\nindex 1965b5041132..1b9dedd2528e 100644\n--- a/src/gstreamer/meson.build\n+++ b/src/gstreamer/meson.build\n@@ -12,8 +12,9 @@ libcamera_gst_c_args = [\n '-DVERSION=\"@0@\"'.format(libcamera_git_version),\n '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n ]\n+libcamera_gst_cpp_args = []\n \n-glib_dep = dependency('glib', required : get_option('gstreamer'))\n+glib_dep = dependency('glib-2.0', required : get_option('gstreamer'))\n \n gst_dep_version = '>=1.14.0'\n gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_dep_version,\n@@ -27,12 +28,13 @@ if glib_dep.found() and gstvideo_dep.found() and gstallocator_dep.found()\n # complain about the ones we are not using. Silence the -Wunused-function\n # warning in that case.\n if cc.get_id() == 'clang' and glib_dep.version().version_compare('<2.63.0')\n- libcamera_gst_c_args += [ '-Wno-unused-function' ]\n+ libcamera_gst_cpp_args += [ '-Wno-unused-function' ]\n endif\n \n libcamera_gst = shared_library('gstlibcamera',\n libcamera_gst_sources,\n c_args : libcamera_gst_c_args,\n+ cpp_args : libcamera_gst_cpp_args,\n dependencies : [libcamera_dep, gstvideo_dep, gstallocator_dep],\n install: true,\n install_dir : '@0@/gstreamer-1.0'.format(get_option('libdir')),\n", "prefixes": [ "libcamera-devel" ] }