Patch Detail
Show a patch.
GET /api/1.1/patches/3025/?format=api
{ "id": 3025, "url": "https://patchwork.libcamera.org/api/1.1/patches/3025/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3025/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306202637.525587-20-nicolas@ndufresne.ca>", "date": "2020-03-06T20:26:29", "name": "[libcamera-devel,v3,19/27] gst: libcamerasrc: Allocate and release buffers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "864a952b5f687a8b60331e846bb1eb714308883a", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/1.1/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3025/mbox/", "series": [ { "id": 705, "url": "https://patchwork.libcamera.org/api/1.1/series/705/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=705", "date": "2020-03-06T20:26:10", "name": "GStreamer Element for libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/705/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3025/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3025/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0C83628F2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 21:27:09 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 53773297189;\n\tFri, 6 Mar 2020 20:27:09 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "Date": "Fri, 6 Mar 2020 15:26:29 -0500", "Message-Id": "<20200306202637.525587-20-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "References": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 19/27] gst: libcamerasrc: Allocate and\n\trelease buffers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 20:27:10 -0000" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nSetup the allocation and the release of buffers in the\nelement. We have one pooling GstAllocator that wraps the\nFrameBufferAllocator and tracks the lifetime of FrameBuffer\nobjects. Then, for each pad we have a GstBufferPool object\nwhich is only used to avoid re-allocating the GstBuffer\nstructure every time we push a buffer.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 28 ++++++++++++++++++++++++++++\n 1 file changed, 28 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 540a094..5ffc004 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -19,7 +19,9 @@\n #include <libcamera/camera.h>\n #include <libcamera/camera_manager.h>\n \n+#include \"gstlibcameraallocator.h\"\n #include \"gstlibcamerapad.h\"\n+#include \"gstlibcamerapool.h\"\n #include \"gstlibcamera-utils.h\"\n \n using namespace libcamera;\n@@ -44,6 +46,7 @@ struct _GstLibcameraSrc {\n \tgchar *camera_name;\n \n \tGstLibcameraSrcState *state;\n+\tGstLibcameraAllocator *allocator;\n };\n \n enum {\n@@ -221,6 +224,23 @@ gst_libcamera_src_task_enter(GstTask *task, GThread *thread, gpointer user_data)\n \t\treturn;\n \t}\n \n+\tself->allocator = gst_libcamera_allocator_new(state->cam_);\n+\tif (!self->allocator) {\n+\t\tGST_ELEMENT_ERROR(self, RESOURCE, NO_SPACE_LEFT,\n+\t\t\t\t (\"Failed to allocate memory\"),\n+\t\t\t\t (\"gst_libcamera_allocator_new() failed.\"));\n+\t\tgst_task_stop(task);\n+\t\treturn;\n+\t}\n+\n+\tfor (gsize i = 0; i < state->srcpads_.size(); i++) {\n+\t\tGstPad *srcpad = state->srcpads_[i];\n+\t\tconst StreamConfiguration &stream_cfg = state->config_->at(i);\n+\t\tGstLibcameraPool *pool = gst_libcamera_pool_new(self->allocator,\n+\t\t\t\t\t\t\t\tstream_cfg.stream());\n+\t\tgst_libcamera_pad_set_pool(srcpad, pool);\n+\t}\n+\n done:\n \tswitch (flow_ret) {\n \tcase GST_FLOW_NOT_NEGOTIATED:\n@@ -236,8 +256,14 @@ static void\n gst_libcamera_src_task_leave(GstTask *task, GThread *thread, gpointer user_data)\n {\n \tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(user_data);\n+\tGstLibcameraSrcState *state = self->state;\n \n \tGST_DEBUG_OBJECT(self, \"Streaming thread is about to stop\");\n+\n+\tfor (GstPad *srcpad : state->srcpads_)\n+\t\tgst_libcamera_pad_set_pool(srcpad, NULL);\n+\n+\tg_clear_object(&self->allocator);\n }\n \n static void\n@@ -246,6 +272,8 @@ gst_libcamera_src_close(GstLibcameraSrc *self)\n \tGstLibcameraSrcState *state = self->state;\n \tgint ret;\n \n+\tGST_DEBUG_OBJECT(self, \"Releasing resources\");\n+\n \tret = state->cam_->release();\n \tif (ret) {\n \t\tGST_ELEMENT_WARNING(self, RESOURCE, BUSY,\n", "prefixes": [ "libcamera-devel", "v3", "19/27" ] }