Patch Detail
Show a patch.
GET /api/1.1/patches/3018/?format=api
{ "id": 3018, "url": "https://patchwork.libcamera.org/api/1.1/patches/3018/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3018/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306202637.525587-13-nicolas@ndufresne.ca>", "date": "2020-03-06T20:26:22", "name": "[libcamera-devel,v3,12/27] gst: libcamerasrc: Store the srcpad in a vector", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7a3f2f04907f34a9c1d280d9e9b0531cea41ea80", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/1.1/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3018/mbox/", "series": [ { "id": 705, "url": "https://patchwork.libcamera.org/api/1.1/series/705/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=705", "date": "2020-03-06T20:26:10", "name": "GStreamer Element for libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/705/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3018/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3018/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28C1C62899\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 21:27:06 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 7CD812970E7;\n\tFri, 6 Mar 2020 20:27:05 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Fri, 6 Mar 2020 15:26:22 -0500", "Message-Id": "<20200306202637.525587-13-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "References": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 12/27] gst: libcamerasrc: Store the\n\tsrcpad in a vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 20:27:06 -0000" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThis will allow implementing generic algorithm even if we cannot\nrequest pads yet.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 35f7512..aa91619 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -8,6 +8,8 @@\n \n #include \"gstlibcamerasrc.h\"\n \n+#include <vector>\n+\n #include <libcamera/camera.h>\n #include <libcamera/camera_manager.h>\n \n@@ -23,6 +25,7 @@ GST_DEBUG_CATEGORY_STATIC(source_debug);\n struct GstLibcameraSrcState {\n \tstd::unique_ptr<CameraManager> cm_;\n \tstd::shared_ptr<Camera> cam_;\n+\tstd::vector<GstPad *> srcpads_;\n };\n \n struct _GstLibcameraSrc {\n@@ -30,7 +33,6 @@ struct _GstLibcameraSrc {\n \n \tGRecMutex stream_lock;\n \tGstTask *task;\n-\tGstPad *srcpad;\n \n \tgchar *camera_name;\n \n@@ -265,8 +267,8 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n \tgst_task_set_leave_callback(self->task, gst_libcamera_src_task_leave, self, nullptr);\n \tgst_task_set_lock(self->task, &self->stream_lock);\n \n-\tself->srcpad = gst_pad_new_from_template(templ, \"src\");\n-\tgst_element_add_pad(GST_ELEMENT(self), self->srcpad);\n+\tstate->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n+\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n \tself->state = state;\n }\n \n", "prefixes": [ "libcamera-devel", "v3", "12/27" ] }