Patch Detail
Show a patch.
GET /api/1.1/patches/3017/?format=api
{ "id": 3017, "url": "https://patchwork.libcamera.org/api/1.1/patches/3017/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3017/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306202637.525587-12-nicolas@ndufresne.ca>", "date": "2020-03-06T20:26:21", "name": "[libcamera-devel,v3,11/27] gst: libcamerapad: Add a method to access the role", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "825951f39f8bd6a561dc83068885738243fa5a00", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/1.1/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3017/mbox/", "series": [ { "id": 705, "url": "https://patchwork.libcamera.org/api/1.1/series/705/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=705", "date": "2020-03-06T20:26:10", "name": "GStreamer Element for libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/705/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3017/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3017/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E8C3628CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 21:27:05 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id EC87C297190;\n\tFri, 6 Mar 2020 20:27:04 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Fri, 6 Mar 2020 15:26:21 -0500", "Message-Id": "<20200306202637.525587-12-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "References": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 11/27] gst: libcamerapad: Add a method\n\tto access the role", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 20:27:05 -0000" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nEach pad can have a different roles. Users will have to request and configure\ntheir pads role before moving to a higher state.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 8 ++++++++\n src/gstreamer/gstlibcamerapad.h | 10 ++++++----\n 2 files changed, 14 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex ca5c820..ed24557 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -100,3 +100,11 @@ gst_libcamera_pad_class_init(GstLibcameraPadClass *klass)\n \t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n \tg_object_class_install_property(object_class, PROP_STREAM_ROLE, spec);\n }\n+\n+StreamRole\n+gst_libcamera_pad_get_role(GstPad *pad)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\tGLibLocker lock(GST_OBJECT(self));\n+\treturn self->role;\n+}\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 2e745f1..f0a5e32 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -6,14 +6,16 @@\n * gstlibcamerapad.h - GStreamer Capture Element\n */\n \n-#include <gst/gst.h>\n-\n #ifndef __GST_LIBCAMERA_PAD_H__\n #define __GST_LIBCAMERA_PAD_H__\n \n+#include <gst/gst.h>\n+\n+#include <libcamera/stream.h>\n+\n #define GST_TYPE_LIBCAMERA_PAD gst_libcamera_pad_get_type()\n-G_DECLARE_FINAL_TYPE(GstLibcameraPad, gst_libcamera_pad,\n-\t\t GST_LIBCAMERA, PAD, GstPad)\n+G_DECLARE_FINAL_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_LIBCAMERA, PAD, GstPad)\n \n+libcamera::StreamRole gst_libcamera_pad_get_role(GstPad *pad);\n \n #endif /* __GST_LIBCAMERA_PAD_H__ */\n", "prefixes": [ "libcamera-devel", "v3", "11/27" ] }