Patch Detail
Show a patch.
GET /api/1.1/patches/3010/?format=api
{ "id": 3010, "url": "https://patchwork.libcamera.org/api/1.1/patches/3010/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3010/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306202637.525587-5-nicolas@ndufresne.ca>", "date": "2020-03-06T20:26:14", "name": "[libcamera-devel,v3,04/27] gst: utils: Add simple scoped lockers for GMutex and GRectMutex", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "943656c295c68347a61a7437e8ac06050f53e4e5", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/1.1/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3010/mbox/", "series": [ { "id": 705, "url": "https://patchwork.libcamera.org/api/1.1/series/705/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=705", "date": "2020-03-06T20:26:10", "name": "GStreamer Element for libcamera", "version": 3, "mbox": "https://patchwork.libcamera.org/series/705/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3010/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3010/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE31C60424\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 21:27:01 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 26CF4297189;\n\tFri, 6 Mar 2020 20:27:01 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Fri, 6 Mar 2020 15:26:14 -0500", "Message-Id": "<20200306202637.525587-5-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "References": "<20200306202637.525587-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/27] gst: utils: Add simple scoped\n\tlockers for GMutex and GRectMutex", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 20:27:02 -0000" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nWhile GLib has locker implementation already using g_autoptr(), recursive mutex\nlocker was only introduced in recent GLib. Implement a simple locker for GMutex\nand GRectMutex in order to allow making locking simpler and safer.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamera-utils.h | 50 ++++++++++++++++++++++++++++++\n 1 file changed, 50 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex 2e4e304..562ffe9 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -16,4 +16,54 @@\n \n GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats);\n \n+/**\n+ * \\class GLibLocker\n+ * \\brief A simple scoped mutex locker for GMutex\n+ */\n+class GLibLocker\n+{\n+public:\n+\tGLibLocker(GMutex *mutex)\n+\t\t: mutex_(mutex)\n+\t{\n+\t\tg_mutex_lock(mutex_);\n+\t}\n+\n+\tGLibLocker(GstObject *object)\n+\t\t: mutex_(GST_OBJECT_GET_LOCK(object))\n+\t{\n+\t\tg_mutex_lock(mutex_);\n+\t}\n+\n+\t~GLibLocker()\n+\t{\n+\t\tg_mutex_unlock(mutex_);\n+\t}\n+\n+private:\n+\tGMutex *mutex_;\n+};\n+\n+/**\n+ * \\class GLibRecLocker\n+ * \\brief A simple scoped mutex locker for GRecMutex\n+ */\n+class GLibRecLocker\n+{\n+public:\n+\tGLibRecLocker(GRecMutex *mutex)\n+\t\t: mutex_(mutex)\n+\t{\n+\t\tg_rec_mutex_lock(mutex_);\n+\t}\n+\n+\t~GLibRecLocker()\n+\t{\n+\t\tg_rec_mutex_unlock(mutex_);\n+\t}\n+\n+private:\n+\tGRecMutex *mutex_;\n+};\n+\n #endif /* __GST_LIBCAMERA_UTILS_H__ */\n", "prefixes": [ "libcamera-devel", "v3", "04/27" ] }