Patch Detail
Show a patch.
GET /api/1.1/patches/3004/?format=api
{ "id": 3004, "url": "https://patchwork.libcamera.org/api/1.1/patches/3004/?format=api", "web_url": "https://patchwork.libcamera.org/patch/3004/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306160002.30549-33-laurent.pinchart@ideasonboard.com>", "date": "2020-03-06T16:00:02", "name": "[libcamera-devel,v2,32/32] cam: Add option to list camera properties", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e0faf9bcafc914ad50975b3058f7b8210450a8ce", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/3004/mbox/", "series": [ { "id": 703, "url": "https://patchwork.libcamera.org/api/1.1/series/703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=703", "date": "2020-03-06T15:59:30", "name": "libcamera: Add support for array controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/3004/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/3004/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D671628F6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 17:00:28 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F8E1312;\n\tFri, 6 Mar 2020 17:00:28 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510428;\n\tbh=OjAhBx/e7LOXNzLPldOlU4fjLMb8ZaO1XbSkeO9tjUM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QI0YFBpOnERaQwP6w76bevOc9FgrmoecGluhAI3YoL1TR/uWTvCvl8LBrXF28MHVk\n\tElQArV9bVM2zbFTvr9MiCKKugrVETbc03x6JIelwqnNKhVXRS8I24LMRmW80/fQ6dF\n\tr9TUSW3yBaapRU2Gz/JLCNTVLd2ffQQaJ/SD0+nA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Mar 2020 18:00:02 +0200", "Message-Id": "<20200306160002.30549-33-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "References": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 32/32] cam: Add option to list camera\n\tproperties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 16:00:28 -0000" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nAdd the '-p'|'--list-properties' option to the cam application to list\nthe properties of a camera.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/cam/main.cpp | 28 ++++++++++++++++++++++++++++\n src/cam/main.h | 1 +\n 2 files changed, 29 insertions(+)", "diff": "diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex a38cca959aca..ea6f7914839c 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -11,6 +11,7 @@\n #include <string.h>\n \n #include <libcamera/libcamera.h>\n+#include <libcamera/property_ids.h>\n \n #include \"capture.h\"\n #include \"event_loop.h\"\n@@ -36,6 +37,7 @@ public:\n private:\n \tint parseOptions(int argc, char *argv[]);\n \tint prepareConfig();\n+\tint listProperties();\n \tint infoConfiguration();\n \tint run();\n \n@@ -180,6 +182,8 @@ int CamApp::parseOptions(int argc, char *argv[])\n \tparser.addOption(OptInfo, OptionNone,\n \t\t\t \"Display information about stream(s)\", \"info\");\n \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n+\tparser.addOption(OptProps, OptionNone, \"List cameras properties\",\n+\t\t\t \"list-properties\");\n \n \toptions_ = parser.parse(argc, argv);\n \tif (!options_.valid())\n@@ -268,6 +272,24 @@ int CamApp::prepareConfig()\n \treturn 0;\n }\n \n+int CamApp::listProperties()\n+{\n+\tif (!camera_) {\n+\t\tstd::cout << \"Cannot list properties without a camera\"\n+\t\t\t << std::endl;\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (const auto &prop : camera_->properties()) {\n+\t\tconst ControlId *id = properties::properties.at(prop.first);\n+\t\tconst ControlValue &value = prop.second;\n+\n+\t\tstd::cout << \"Property: \" << id->name() << \" = \" << value.toString();\n+\t}\n+\n+\treturn 0;\n+}\n+\n int CamApp::infoConfiguration()\n {\n \tif (!config_) {\n@@ -312,6 +334,12 @@ int CamApp::run()\n \t\t}\n \t}\n \n+\tif (options_.isSet(OptProps)) {\n+\t\tret = listProperties();\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n \tif (options_.isSet(OptInfo)) {\n \t\tret = infoConfiguration();\n \t\tif (ret)\ndiff --git a/src/cam/main.h b/src/cam/main.h\nindex 0997476bb335..afcad4353b7d 100644\n--- a/src/cam/main.h\n+++ b/src/cam/main.h\n@@ -14,6 +14,7 @@ enum {\n \tOptHelp = 'h',\n \tOptInfo = 'I',\n \tOptList = 'l',\n+\tOptProps = 'p',\n \tOptStream = 's',\n };\n \n", "prefixes": [ "libcamera-devel", "v2", "32/32" ] }