Patch Detail
Show a patch.
GET /api/1.1/patches/2999/?format=api
{ "id": 2999, "url": "https://patchwork.libcamera.org/api/1.1/patches/2999/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2999/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306160002.30549-28-laurent.pinchart@ideasonboard.com>", "date": "2020-03-06T15:59:57", "name": "[libcamera-devel,v2,27/32] libcamera: control_serializer: Simplify serialization of ControlValue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7d63a7948cc52bdc6eedcb5095d20956e531baa8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2999/mbox/", "series": [ { "id": 703, "url": "https://patchwork.libcamera.org/api/1.1/series/703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=703", "date": "2020-03-06T15:59:30", "name": "libcamera: Add support for array controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2999/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2999/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C71D0628B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 17:00:26 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E1F71265\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 17:00:26 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510426;\n\tbh=oFiLAcNlTeOM8OlPjueQgF0oovjVB0y8QA5hKJv6BSA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=aiFPG34V04MgtezYw5+T3iBNa2bE32p8P2EsGIZhtyRx2+I5OiFG9Y0zGxsuoB07c\n\t9i8R38Emu99wBwDC7Ix1ho8uqt5XsI/80weiXh2YPYjj39aUY+lAVE8ZUrEb3a5ear\n\trSWI+9jIareN/e+lZSpshk+b9isAQ0nQrubH4I+I=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Mar 2020 17:59:57 +0200", "Message-Id": "<20200306160002.30549-28-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "References": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 27/32] libcamera: control_serializer:\n\tSimplify serialization of ControlValue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 16:00:28 -0000" }, "content": "Use the ControlValue::data() function to access raw data stored in the\ncontrol value and simplify serialization.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.binghm@ideasonboard.com>\n---\n src/libcamera/control_serializer.cpp | 35 +---------------------------\n 1 file changed, 1 insertion(+), 34 deletions(-)", "diff": "diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\nindex edf3e5cab09f..997e87bec817 100644\n--- a/src/libcamera/control_serializer.cpp\n+++ b/src/libcamera/control_serializer.cpp\n@@ -146,40 +146,7 @@ size_t ControlSerializer::binarySize(const ControlList &list)\n void ControlSerializer::store(const ControlValue &value,\n \t\t\t ByteStreamBuffer &buffer)\n {\n-\tswitch (value.type()) {\n-\tcase ControlTypeBool: {\n-\t\tbool data = value.get<bool>();\n-\t\tbuffer.write(&data);\n-\t\tbreak;\n-\t}\n-\n-\tcase ControlTypeByte: {\n-\t\tuint8_t data = value.get<uint8_t>();\n-\t\tbuffer.write(&data);\n-\t\tbreak;\n-\t}\n-\n-\tcase ControlTypeInteger32: {\n-\t\tint32_t data = value.get<int32_t>();\n-\t\tbuffer.write(&data);\n-\t\tbreak;\n-\t}\n-\n-\tcase ControlTypeInteger64: {\n-\t\tuint64_t data = value.get<int64_t>();\n-\t\tbuffer.write(&data);\n-\t\tbreak;\n-\t}\n-\n-\tcase ControlTypeFloat: {\n-\t\tfloat data = value.get<float>();\n-\t\tbuffer.write(&data);\n-\t\tbreak;\n-\t}\n-\n-\tdefault:\n-\t\tbreak;\n-\t}\n+\tbuffer.write(value.data());\n }\n \n void ControlSerializer::store(const ControlRange &range,\n", "prefixes": [ "libcamera-devel", "v2", "27/32" ] }