Patch Detail
Show a patch.
GET /api/1.1/patches/2976/?format=api
{ "id": 2976, "url": "https://patchwork.libcamera.org/api/1.1/patches/2976/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2976/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200306160002.30549-5-laurent.pinchart@ideasonboard.com>", "date": "2020-03-06T15:59:34", "name": "[libcamera-devel,v2,04/32] libcamera: ipa: Remove unused IPA control types", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d562e09b8f9a3874589f855d5a2442fb1c254a23", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2976/mbox/", "series": [ { "id": 703, "url": "https://patchwork.libcamera.org/api/1.1/series/703/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=703", "date": "2020-03-06T15:59:30", "name": "libcamera: Add support for array controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/703/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2976/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2976/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AC366285C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Mar 2020 17:00:13 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B43A61265;\n\tFri, 6 Mar 2020 17:00:12 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510413;\n\tbh=OaP47GfKzwc/o9/d1YeQVQuGEMYh5zgzJkooIYzWXMU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jCRxTqjBs60Wd03Pv0wJuy1+iCPBb8uLP/fPvBVdzPe2Zb4d/74S0pm/9el+kP5c6\n\tYCJDURAnLQvbIgkuTQWKAVLEFfqL77rD7hPE1+k2JuNjdCtzloQXfJV1pRMt3AGO84\n\t9T9hciDe4tHgjwJANhf1nLBcTp8/WHuysKIkwOAs=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Mar 2020 17:59:34 +0200", "Message-Id": "<20200306160002.30549-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "References": "<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 04/32] libcamera: ipa: Remove unused\n\tIPA control types", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 06 Mar 2020 16:00:13 -0000" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nThe ipa_control_range_data structure is only used to document the IPA\ncontrol serialization format, but isn't used in code at all as the\nControlRange entries are directly serialized to a byte stream buffer.\nThis applies to the ipa_control_value_data structure that is solely used\nby ipa_control_range_data.\n\nExpand the documentation of the IPA control serialization format to\ndescribe the layout of the control range data in words and diagrams\ninstead of through a C structure. Remove the unused structures as a\nresult.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/ipa/ipa_controls.h | 11 ----------\n src/libcamera/ipa_controls.cpp | 38 ++++++++++++++--------------------\n 2 files changed, 16 insertions(+), 33 deletions(-)", "diff": "diff --git a/include/ipa/ipa_controls.h b/include/ipa/ipa_controls.h\nindex de3a017b0179..426d99689de2 100644\n--- a/include/ipa/ipa_controls.h\n+++ b/include/ipa/ipa_controls.h\n@@ -36,17 +36,6 @@ struct ipa_control_range_entry {\n \tuint32_t padding[1];\n };\n \n-union ipa_control_value_data {\n-\tbool b;\n-\tint32_t i32;\n-\tint64_t i64;\n-};\n-\n-struct ipa_control_range_data {\n-\tunion ipa_control_value_data min;\n-\tunion ipa_control_value_data max;\n-};\n-\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\nindex ed12830c0d9e..6ea71bc6dc46 100644\n--- a/src/libcamera/ipa_controls.cpp\n+++ b/src/libcamera/ipa_controls.cpp\n@@ -100,8 +100,22 @@\n *\n * Entries are described by the ipa_control_range_entry structure. They contain\n * the numerical ID and type of the control. The control range data is stored\n- * in the data section as described by the ipa_control_range_data structure.\n- * The ipa_control_range_entry::offset field stores the offset from the\n+ * in the data section as described by the following diagram.\n+ *\n+ * ~~~~\n+ * +-------------------------+ .\n+ * / | ... | | entry[n].offset\n+ * | +-------------------------+ <-----´\n+ * Data | | minimum value (#n) | \\\n+ * section | +-------------------------+ | Entry #n\n+ * | | maximum value (#n) | /\n+ * | +-------------------------+\n+ * \\ | ... |\n+ * +-------------------------+\n+ * ~~~~\n+ *\n+ * The minimum and maximum value are stored in the platform's native data\n+ * format. The ipa_control_range_entry::offset field stores the offset from the\n * beginning of the data section to the range data.\n *\n * Range data in the data section shall be stored in the same order as the\n@@ -164,23 +178,3 @@\n * \\var ipa_control_range_entry::padding\n * Padding bytes (shall be set to 0)\n */\n-\n-/**\n- * \\union ipa_control_value_data\n- * \\brief Serialized control value\n- * \\var ipa_control_value_data::b\n- * Value for ControlTypeBool controls\n- * \\var ipa_control_value_data::i32\n- * Value for ControlTypeInteger32 controls\n- * \\var ipa_control_value_data::i64\n- * Value for ControlTypeInteger64 controls\n- */\n-\n-/**\n- * \\struct ipa_control_range_data\n- * \\brief Serialized control range\n- * \\var ipa_control_range_data::min\n- * The control minimum value\n- * \\var ipa_control_range_data::max\n- * The control maximum value\n- */\n", "prefixes": [ "libcamera-devel", "v2", "04/32" ] }