Patch Detail
Show a patch.
GET /api/1.1/patches/2968/?format=api
{ "id": 2968, "url": "https://patchwork.libcamera.org/api/1.1/patches/2968/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2968/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200305203808.536050-5-niklas.soderlund@ragnatech.se>", "date": "2020-03-05T20:38:05", "name": "[libcamera-devel,v4,4/7] libcamera: V4L2BufferCache: Use the entry reference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cd3c886ba8cfdcf053d4240eb29ca14128772e7e", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2968/mbox/", "series": [ { "id": 702, "url": "https://patchwork.libcamera.org/api/1.1/series/702/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=702", "date": "2020-03-05T20:38:01", "name": "libcamera: V4L2BufferCache: Improve cache eviction strategy", "version": 4, "mbox": "https://patchwork.libcamera.org/series/702/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2968/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2968/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7924560427\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Mar 2020 21:38:22 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 40f1f818-5f21-11ea-9f85-005056917a89;\n\tThu, 05 Mar 2020 21:38:21 +0100 (CET)" ], "X-Halon-ID": "40f1f818-5f21-11ea-9f85-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 5 Mar 2020 21:38:05 +0100", "Message-Id": "<20200305203808.536050-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200305203808.536050-1-niklas.soderlund@ragnatech.se>", "References": "<20200305203808.536050-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 4/7] libcamera: V4L2BufferCache: Use\n\tthe entry reference", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 05 Mar 2020 20:38:22 -0000" }, "content": "Instead of looking up the index in the storage vector use the reference\nto it created at the beginning of the loop.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex d88cb0bd0771e545..268de60bc7965f58 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -216,7 +216,7 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n \t\t\tuse = index;\n \n \t\t/* Try to find a cache hit by comparing the planes. */\n-\t\tif (cache_[index] == buffer) {\n+\t\tif (entry == buffer) {\n \t\t\thit = true;\n \t\t\tuse = index;\n \t\t\tbreak;\n", "prefixes": [ "libcamera-devel", "v4", "4/7" ] }