Patch Detail
Show a patch.
GET /api/1.1/patches/2957/?format=api
{ "id": 2957, "url": "https://patchwork.libcamera.org/api/1.1/patches/2957/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2957/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200304232246.325384-2-niklas.soderlund@ragnatech.se>", "date": "2020-03-04T23:22:40", "name": "[libcamera-devel,v3,1/7] test: camera: buffer_import: Fix error messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4e2df824b9a36b10c6cbb34d8c890182e431231d", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2957/mbox/", "series": [ { "id": 701, "url": "https://patchwork.libcamera.org/api/1.1/series/701/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=701", "date": "2020-03-04T23:22:39", "name": "libcamera: V4L2BufferCache: Improve cache", "version": 3, "mbox": "https://patchwork.libcamera.org/series/701/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2957/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2957/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEEEF62826\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 5 Mar 2020 00:23:45 +0100 (CET)", "from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 31220227-5e6f-11ea-9f85-005056917a89;\n\tThu, 05 Mar 2020 00:23:44 +0100 (CET)" ], "X-Halon-ID": "31220227-5e6f-11ea-9f85-005056917a89", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 5 Mar 2020 00:22:40 +0100", "Message-Id": "<20200304232246.325384-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200304232246.325384-1-niklas.soderlund@ragnatech.se>", "References": "<20200304232246.325384-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/7] test: camera: buffer_import: Fix\n\terror messages", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 04 Mar 2020 23:23:46 -0000" }, "content": "The error message for when a device name can't be resolved to a video\ndevice is wrong and applies to the next operation below it. Move it to\nits correct location and add a new error message to highlight the\nresolution failure.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/camera/buffer_import.cpp | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\nindex ab6e74bd1671e6f5..6997ea78c9f608c9 100644\n--- a/test/camera/buffer_import.cpp\n+++ b/test/camera/buffer_import.cpp\n@@ -74,13 +74,16 @@ public:\n \n \t\tvideo_ = V4L2VideoDevice::fromEntityName(media_.get(), videoDeviceName);\n \t\tif (!video_) {\n+\t\t\tstd::cout << \"Failed to get video device from entity \"\n+\t\t\t\t << videoDeviceName << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (video_->open()) {\n \t\t\tstd::cout << \"Unable to open \" << videoDeviceName << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tif (video_->open())\n-\t\t\treturn TestFail;\n-\n \t\t/* Configure the format. */\n \t\tV4L2DeviceFormat format;\n \t\tif (video_->getFormat(&format)) {\n", "prefixes": [ "libcamera-devel", "v3", "1/7" ] }