Patch Detail
Show a patch.
GET /api/1.1/patches/2948/?format=api
{ "id": 2948, "url": "https://patchwork.libcamera.org/api/1.1/patches/2948/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2948/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200229164254.23604-31-laurent.pinchart@ideasonboard.com>", "date": "2020-02-29T16:42:53", "name": "[libcamera-devel,30/31] DNI: test: serialization: Serialize array controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8c66641eba95851f6dcd8f8d7e7211dd1540c1a1", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2948/mbox/", "series": [ { "id": 696, "url": "https://patchwork.libcamera.org/api/1.1/series/696/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=696", "date": "2020-02-29T16:42:23", "name": "libcamera: Add support for array controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/696/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2948/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2948/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B6A9627AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Feb 2020 17:43:33 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9758EA49;\n\tSat, 29 Feb 2020 17:43:32 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582994612;\n\tbh=8UKmWivj2LLmPXl2xn/4GadqVCsArv+M6txJNT5cBJw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PEtrAGi4yhjHgCoEqi9QLPNMGo3OLxi0inmxHhPrqiaz/UEuklts4eEvnxj73Yzb5\n\tOedN3kK5jceBbzDyOy5BVYTO5LIkNYGrTAL6O9yKDOZaKtQ6p3QSkrrbIzLvwbxo5w\n\t2eDvxqIxcrUPYOE0dDtwWW3lOm9uexMDC/JgC8rQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 29 Feb 2020 18:42:53 +0200", "Message-Id": "<20200229164254.23604-31-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>", "References": "<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 30/31] DNI: test: serialization: Serialize\n\tarray controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 29 Feb 2020 16:43:36 -0000" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nDepends on the fictional array control definition.\nNot for inclusion.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/serialization/control_serialization.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/serialization/control_serialization.cpp b/test/serialization/control_serialization.cpp\nindex 2989b52774fb..1de54a02c443 100644\n--- a/test/serialization/control_serialization.cpp\n+++ b/test/serialization/control_serialization.cpp\n@@ -38,13 +38,14 @@ protected:\n \t\tsize_t size;\n \t\tint ret;\n \n-\t\t/* Create a control list with three controls. */\n+\t\t/* Create a control list with several controls. */\n \t\tconst ControlInfoMap &infoMap = camera_->controls();\n \t\tControlList list(infoMap);\n \n \t\tlist.set(controls::Brightness, 255);\n \t\tlist.set(controls::Contrast, 128);\n \t\tlist.set(controls::Saturation, 50);\n+\t\tlist.set(controls::BayerGains, { 1.0f, 1.1f, 0.9f, 1.0f });\n \n \t\t/*\n \t\t * Serialize the control list, this should fail as the control\n", "prefixes": [ "libcamera-devel", "30/31" ] }