Patch Detail
Show a patch.
GET /api/1.1/patches/2921/?format=api
{ "id": 2921, "url": "https://patchwork.libcamera.org/api/1.1/patches/2921/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2921/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200229164254.23604-4-laurent.pinchart@ideasonboard.com>", "date": "2020-02-29T16:42:26", "name": "[libcamera-devel,03/31] libcamera: gen-controls: Fix documentation issue with <<", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7174766e0557665e9d6dde06a61e72a7d25070d5", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2921/mbox/", "series": [ { "id": 696, "url": "https://patchwork.libcamera.org/api/1.1/series/696/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=696", "date": "2020-02-29T16:42:23", "name": "libcamera: Add support for array controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/696/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2921/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2921/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44FE462789\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Feb 2020 17:43:23 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C91EAA28;\n\tSat, 29 Feb 2020 17:43:22 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582994603;\n\tbh=25QrjndSjN/tGA2KGr+Azbv20+Akchee2Dn86gYqtnw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o1VGzC2lN/v7t4f3yNoOZlA9XNvPAaMEamHJYPYQAuX+YMboSCHcGTq8KD2iMyN9A\n\tCO+F29Orl3CfVvmY+ERJcHZrlOl6raXTW4UNJRY8G2XaGSUqjXmh5VBr2wECvPFvKY\n\teFFFMdCRWoHUKJTxP/KDXASun56CuQjKhLwL4Fkg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 29 Feb 2020 18:42:26 +0200", "Message-Id": "<20200229164254.23604-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>", "References": "<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 03/31] libcamera: gen-controls: Fix\n\tdocumentation issue with <<", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 29 Feb 2020 16:43:24 -0000" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nDoxygen fails to parse entries with multiple << signs as, in example,\n\\var extern const Control<Span<int32_t>>\n\nRemove the type from the control documentation as unique control and\nproperties name should not need any additional information specified for\nDoxygen to correctly identify them.\n\nNot sure this patch is the right way to fix this, but it's mostly here\nto highlight an issue.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/gen-controls.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\nindex 773e9b5d170c..6f020a327827 100755\n--- a/src/libcamera/gen-controls.py\n+++ b/src/libcamera/gen-controls.py\n@@ -29,7 +29,7 @@ def generate_cpp(controls):\n enum_doc_value_template = string.Template(''' * \\\\var ${name}Values::${value}\n ${description}''')\n doc_template = string.Template('''/**\n- * \\\\var extern const Control<${type}> ${name}\n+ * \\\\var ${name}\n ${description}\n */''')\n def_template = string.Template('extern const Control<${type}> ${name}(${id_name}, \"${name}\");')\n", "prefixes": [ "libcamera-devel", "03/31" ] }