Patch Detail
Show a patch.
GET /api/1.1/patches/2919/?format=api
{ "id": 2919, "url": "https://patchwork.libcamera.org/api/1.1/patches/2919/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2919/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200229164254.23604-2-laurent.pinchart@ideasonboard.com>", "date": "2020-02-29T16:42:24", "name": "[libcamera-devel,01/31] libcamera: Add a C++20-compliant std::span<> implementation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d26150683461af2026e8d01f7ee1574c502e490a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2919/mbox/", "series": [ { "id": 696, "url": "https://patchwork.libcamera.org/api/1.1/series/696/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=696", "date": "2020-02-29T16:42:23", "name": "libcamera: Add support for array controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/696/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2919/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2919/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D14A62689\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Feb 2020 17:43:22 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1216DA28;\n\tSat, 29 Feb 2020 17:43:22 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582994602;\n\tbh=ptdAb66FWFDwGE6nwbpVByCYnUyXRaVwFUb9/1L+ctM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eeHqfBeA/vBGdD4Ile8vrAleDRfbqKya/yK4Nr3fKJpWX9Z13XuUaZH634tM/yGRy\n\tQwhnYU3i9jXEcna973HwJTK10kfchUOGqw/qfw8slM1/Tah2dZjmAYU16ZubB02IYr\n\trhiP6n85sJYewWrLGv3h0nSC5CgpxzSc0Ov7N5Cc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 29 Feb 2020 18:42:24 +0200", "Message-Id": "<20200229164254.23604-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>", "References": "<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 01/31] libcamera: Add a C++20-compliant\n\tstd::span<> implementation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 29 Feb 2020 16:43:22 -0000" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nC++20 will contain a std::span<> class that represents a contiguous\nsequence of objects. Its main purpose is to group array pointers and\nsize together in APIs.\n\nAdd a compatible implementation to the utils namespace. This will be\nused to implement array controls.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n Documentation/Doxyfile.in | 4 +-\n include/libcamera/meson.build | 1 +\n include/libcamera/span.h | 417 ++++++++++++++++++++++++++++++++++\n src/libcamera/meson.build | 1 +\n src/libcamera/span.cpp | 12 +\n 5 files changed, 434 insertions(+), 1 deletion(-)\n create mode 100644 include/libcamera/span.h\n create mode 100644 src/libcamera/span.cpp", "diff": "diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\nindex beeaf6d3cf48..457e23a086a2 100644\n--- a/Documentation/Doxyfile.in\n+++ b/Documentation/Doxyfile.in\n@@ -840,8 +840,10 @@ RECURSIVE = YES\n # Note that relative paths are relative to the directory from which doxygen is\n # run.\n \n-EXCLUDE = @TOP_SRCDIR@/src/libcamera/device_enumerator_sysfs.cpp \\\n+EXCLUDE = @TOP_SRCDIR@/include/libcamera/span.h \\\n+\t\t\t @TOP_SRCDIR@/src/libcamera/device_enumerator_sysfs.cpp \\\n \t\t\t @TOP_SRCDIR@/src/libcamera/device_enumerator_udev.cpp \\\n+\t\t\t @TOP_SRCDIR@/src/libcamera/span.cpp \\\n \t\t\t @TOP_SRCDIR@/src/libcamera/include/device_enumerator_sysfs.h \\\n \t\t\t @TOP_SRCDIR@/src/libcamera/include/device_enumerator_udev.h \\\n \t\t\t @TOP_SRCDIR@/src/libcamera/pipeline/ \\\ndiff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex f58c02d2cf35..f47c583cbbc0 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -14,6 +14,7 @@ libcamera_api = files([\n 'pixelformats.h',\n 'request.h',\n 'signal.h',\n+ 'span.h',\n 'stream.h',\n 'timer.h',\n ])\ndiff --git a/include/libcamera/span.h b/include/libcamera/span.h\nnew file mode 100644\nindex 000000000000..513ddb432405\n--- /dev/null\n+++ b/include/libcamera/span.h\n@@ -0,0 +1,417 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2020, Google Inc.\n+ *\n+ * span.h - C++20 std::span<> implementation for C++11\n+ */\n+\n+#ifndef __LIBCAMERA_SPAN_H__\n+#define __LIBCAMERA_SPAN_H__\n+\n+#include <array>\n+#include <iterator>\n+#include <limits>\n+#include <stddef.h>\n+#include <type_traits>\n+\n+namespace libcamera {\n+\n+static constexpr std::size_t dynamic_extent = std::numeric_limits<std::size_t>::max();\n+\n+template<typename T, std::size_t Extent = dynamic_extent>\n+class Span;\n+\n+namespace details {\n+\n+template<typename U>\n+struct is_array : public std::false_type {\n+};\n+\n+template<typename U, std::size_t N>\n+struct is_array<std::array<U, N>> : public std::true_type {\n+};\n+\n+template<typename U>\n+struct is_span : public std::false_type {\n+};\n+\n+template<typename U, std::size_t Extent>\n+struct is_span<Span<U, Extent>> : public std::true_type {\n+};\n+\n+} /* namespace details */\n+\n+namespace utils {\n+\n+template<typename C>\n+constexpr auto size(const C &c) -> decltype(c.size())\n+{\n+\treturn c.size();\n+}\n+\n+template<typename C>\n+constexpr auto data(const C &c) -> decltype(c.data())\n+{\n+\treturn c.data();\n+}\n+\n+template<typename C>\n+constexpr auto data(C &c) -> decltype(c.data())\n+{\n+\treturn c.data();\n+}\n+\n+template<class T, std::size_t N>\n+constexpr T *data(T (&array)[N]) noexcept\n+{\n+\treturn array;\n+}\n+\n+template<std::size_t I, typename T>\n+struct tuple_element;\n+\n+template<std::size_t I, typename T, std::size_t N>\n+struct tuple_element<I, Span<T, N>> {\n+\tusing type = T;\n+};\n+\n+template<typename T>\n+struct tuple_size;\n+\n+template<typename T, std::size_t N>\n+struct tuple_size<Span<T, N>> : public std::integral_constant<std::size_t, N> {\n+};\n+\n+template<typename T>\n+struct tuple_size<Span<T, dynamic_extent>>;\n+\n+} /* namespace utils */\n+\n+template<typename T, std::size_t Extent>\n+class Span\n+{\n+public:\n+\tusing element_type = T;\n+\tusing value_type = typename std::remove_cv_t<T>;\n+\tusing size_type = std::size_t;\n+\tusing difference_type = std::ptrdiff_t;\n+\tusing pointer = T *;\n+\tusing const_pointer = const T *;\n+\tusing reference = T &;\n+\tusing const_reference = const T &;\n+\tusing iterator = pointer;\n+\tusing const_iterator = const_pointer;\n+\tusing reverse_iterator = std::reverse_iterator<iterator>;\n+\tusing const_reverse_iterator = std::reverse_iterator<const_iterator>;\n+\n+\tstatic constexpr std::size_t extent = Extent;\n+\n+\ttemplate<bool Dependent = false,\n+\t\t typename = std::enable_if_t<Dependent || Extent == 0>>\n+\tconstexpr Span() noexcept\n+\t\t: data_(nullptr)\n+\t{\n+\t}\n+\n+\tconstexpr Span(pointer ptr, size_type count)\n+\t\t: data_(ptr)\n+\t{\n+\t}\n+\n+\tconstexpr Span(pointer first, pointer last)\n+\t\t: data_(first)\n+\t{\n+\t}\n+\n+\ttemplate<std::size_t N>\n+\tconstexpr Span(element_type (&arr)[N],\n+\t\t std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value &&\n+\t\t\t\t\tN == Extent,\n+\t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n+\t\t: data_(arr)\n+\t{\n+\t}\n+\n+\ttemplate<std::size_t N>\n+\tconstexpr Span(std::array<value_type, N> &arr,\n+\t\t std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value &&\n+\t\t\t\t\tN == Extent,\n+\t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n+\t\t: data_(arr.data())\n+\t{\n+\t}\n+\n+\ttemplate<std::size_t N>\n+\tconstexpr Span(const std::array<value_type, N> &arr,\n+\t\t std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value &&\n+\t\t\t\t\tN == Extent,\n+\t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n+\t\t: data_(arr.data())\n+\t{\n+\t}\n+\n+\ttemplate<class Container>\n+\tconstexpr Span(Container &cont,\n+\t\t std::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t!details::is_array<Container>::value &&\n+\t\t\t\t\t!std::is_array<Container>::value &&\n+\t\t\t\t\tstd::is_convertible<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value,\n+\t\t\t\t\tstd::nullptr_t> = nullptr)\n+\t\t: data_(utils::data(cont))\n+\t{\n+\t}\n+\n+\ttemplate<class Container>\n+\tconstexpr Span(const Container &cont,\n+\t\t std::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t!details::is_array<Container>::value &&\n+\t\t\t\t\t!std::is_array<Container>::value &&\n+\t\t\t\t\tstd::is_convertible<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value,\n+\t\t\t\t\tstd::nullptr_t> = nullptr)\n+\t\t: data_(utils::data(cont))\n+\t{\n+\t\tstatic_assert(utils::size(cont) == Extent, \"Size mismatch\");\n+\t}\n+\n+\ttemplate<class U, std::size_t N>\n+\tconstexpr Span(const Span<U, N> &s,\n+\t\t std::enable_if_t<std::is_convertible<U (*)[], element_type (*)[]>::value &&\n+\t\t\t\t\tN == Extent,\n+\t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n+\t\t: data_(s.data())\n+\t{\n+\t}\n+\n+\tconstexpr Span(const Span &other) noexcept = default;\n+\n+\tconstexpr Span &operator=(const Span &other) noexcept\n+\t{\n+\t\tdata_ = other.data_;\n+\t\treturn *this;\n+\t}\n+\n+\tconstexpr iterator begin() const { return data(); }\n+\tconstexpr const_iterator cbegin() const { return begin(); }\n+\tconstexpr iterator end() const { return data() + size(); }\n+\tconstexpr const_iterator cend() const { return end(); }\n+\tconstexpr reverse_iterator rbegin() const { return reverse_iterator(data() + size() - 1); }\n+\tconstexpr const_reverse_iterator crbegin() const { return rbegin(); }\n+\tconstexpr reverse_iterator rend() const { return reverse_iterator(data() - 1); }\n+\tconstexpr const_reverse_iterator crend() const { return rend(); }\n+\n+\tconstexpr reference front() const { return *data(); }\n+\tconstexpr reference back() const { return *(data() + size() - 1); }\n+\tconstexpr reference operator[](size_type idx) const { return data()[idx]; }\n+\tconstexpr pointer data() const noexcept { return data_; }\n+\n+\tconstexpr size_type size() const noexcept { return Extent; }\n+\tconstexpr size_type size_bytes() const noexcept { return size() * sizeof(element_type); }\n+\tconstexpr bool empty() const noexcept { return size() == 0; }\n+\n+\ttemplate<std::size_t Count>\n+\tconstexpr Span<element_type, Count> first() const\n+\t{\n+\t\tstatic_assert(Count <= Extent, \"Count larger than size\");\n+\t\treturn { data(), Count };\n+\t}\n+\n+\tconstexpr Span<element_type, dynamic_extent> first(std::size_t Count) const\n+\t{\n+\t\treturn { data(), Count };\n+\t}\n+\n+\ttemplate<std::size_t Count>\n+\tconstexpr Span<element_type, Count> last() const\n+\t{\n+\t\tstatic_assert(Count <= Extent, \"Count larger than size\");\n+\t\treturn { data() + size() - Count, Count };\n+\t}\n+\n+\tconstexpr Span<element_type, dynamic_extent> last(std::size_t Count) const\n+\t{\n+\t\treturn { data() + size() - Count, Count };\n+\t}\n+\n+\ttemplate<std::size_t Offset, std::size_t Count = dynamic_extent>\n+\tconstexpr Span<element_type, Count != dynamic_extent ? Count : Extent - Offset> subspan() const\n+\t{\n+\t\tstatic_assert(Offset <= Extent, \"Offset larger than size\");\n+\t\tstatic_assert(Count == dynamic_extent || Count + Offset <= Extent,\n+\t\t\t \"Offset + Count larger than size\");\n+\t\treturn { data() + Offset, Count == dynamic_extent ? size() - Offset : Count };\n+\t}\n+\n+\tconstexpr Span<element_type, dynamic_extent>\n+\tsubspan(std::size_t Offset, std::size_t Count = dynamic_extent) const\n+\t{\n+\t\treturn { data() + Offset, Count == dynamic_extent ? size() - Offset : Count };\n+\t}\n+\n+private:\n+\tpointer data_;\n+};\n+\n+template<typename T>\n+class Span<T, dynamic_extent>\n+{\n+public:\n+\tusing element_type = T;\n+\tusing value_type = typename std::remove_cv_t<T>;\n+\tusing size_type = std::size_t;\n+\tusing difference_type = std::ptrdiff_t;\n+\tusing pointer = T *;\n+\tusing const_pointer = const T *;\n+\tusing reference = T &;\n+\tusing const_reference = const T &;\n+\tusing iterator = T *;\n+\tusing const_iterator = const T *;\n+\tusing reverse_iterator = std::reverse_iterator<iterator>;\n+\tusing const_reverse_iterator = std::reverse_iterator<const_iterator>;\n+\n+\tstatic constexpr std::size_t extent = dynamic_extent;\n+\n+\tconstexpr Span() noexcept\n+\t\t: data_(nullptr), size_(0)\n+\t{\n+\t}\n+\n+\tconstexpr Span(pointer ptr, size_type count)\n+\t\t: data_(ptr), size_(count)\n+\t{\n+\t}\n+\n+\tconstexpr Span(pointer first, pointer last)\n+\t\t: data_(first), size_(last - first)\n+\t{\n+\t}\n+\n+\ttemplate<std::size_t N>\n+\tconstexpr Span(element_type (&arr)[N],\n+\t\t std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value,\n+\t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n+\t\t: data_(arr), size_(N)\n+\t{\n+\t}\n+\n+\ttemplate<std::size_t N>\n+\tconstexpr Span(std::array<value_type, N> &arr,\n+\t\t std::enable_if_t<std::is_convertible<std::remove_pointer_t<decltype(utils::data(arr))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value,\n+\t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n+\t\t: data_(utils::data(arr)), size_(N)\n+\t{\n+\t}\n+\n+\ttemplate<std::size_t N>\n+\tconstexpr Span(const std::array<value_type, N> &arr) noexcept\n+\t\t: data_(utils::data(arr)), size_(N)\n+\t{\n+\t}\n+\n+\ttemplate<class Container>\n+\tconstexpr Span(Container &cont,\n+\t\t std::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t!details::is_array<Container>::value &&\n+\t\t\t\t\t!std::is_array<Container>::value &&\n+\t\t\t\t\tstd::is_convertible<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value,\n+\t\t\t\t\tstd::nullptr_t> = nullptr)\n+\t\t: data_(utils::data(cont)), size_(utils::size(cont))\n+\t{\n+\t}\n+\n+\ttemplate<class Container>\n+\tconstexpr Span(const Container &cont,\n+\t\t std::enable_if_t<!details::is_span<Container>::value &&\n+\t\t\t\t\t!details::is_array<Container>::value &&\n+\t\t\t\t\t!std::is_array<Container>::value &&\n+\t\t\t\t\tstd::is_convertible<std::remove_pointer_t<decltype(utils::data(cont))> (*)[],\n+\t\t\t\t\t\t\t element_type (*)[]>::value,\n+\t\t\t\t\tstd::nullptr_t> = nullptr)\n+\t\t: data_(utils::data(cont)), size_(utils::size(cont))\n+\t{\n+\t}\n+\n+\ttemplate<class U, std::size_t N>\n+\tconstexpr Span(const Span<U, N> &s,\n+\t\t std::enable_if_t<std::is_convertible<U (*)[], element_type (*)[]>::value,\n+\t\t\t\t\tstd::nullptr_t> = nullptr) noexcept\n+\t\t: data_(s.data()), size_(s.size())\n+\t{\n+\t}\n+\n+\tconstexpr Span(const Span &other) noexcept = default;\n+\n+\tconstexpr Span &operator=(const Span &other) noexcept\n+\t{\n+\t\tdata_ = other.data_;\n+\t\tsize_ = other.size_;\n+\t\treturn *this;\n+\t}\n+\n+\tconstexpr iterator begin() const { return data(); }\n+\tconstexpr const_iterator cbegin() const { return begin(); }\n+\tconstexpr iterator end() const { return data() + size(); }\n+\tconstexpr const_iterator cend() const { return end(); }\n+\tconstexpr reverse_iterator rbegin() const { return reverse_iterator(data() + size() - 1); }\n+\tconstexpr const_reverse_iterator crbegin() const { return rbegin(); }\n+\tconstexpr reverse_iterator rend() const { return reverse_iterator(data() - 1); }\n+\tconstexpr const_reverse_iterator crend() const { return rend(); }\n+\n+\tconstexpr reference front() const { return *data(); }\n+\tconstexpr reference back() const { return *(data() + size() - 1); }\n+\tconstexpr reference operator[](size_type idx) const { return data()[idx]; }\n+\tconstexpr pointer data() const noexcept { return data_; }\n+\n+\tconstexpr size_type size() const noexcept { return size_; }\n+\tconstexpr size_type size_bytes() const noexcept { return size() * sizeof(element_type); }\n+\tconstexpr bool empty() const noexcept { return size() == 0; }\n+\n+\ttemplate<std::size_t Count>\n+\tconstexpr Span<element_type, Count> first() const\n+\t{\n+\t\treturn { data(), Count };\n+\t}\n+\n+\tconstexpr Span<element_type, dynamic_extent> first(std::size_t Count) const\n+\t{\n+\t\treturn { data(), Count };\n+\t}\n+\n+\ttemplate<std::size_t Count>\n+\tconstexpr Span<element_type, Count> last() const\n+\t{\n+\t\treturn { data() + size() - Count, Count };\n+\t}\n+\n+\tconstexpr Span<element_type, dynamic_extent> last(std::size_t Count) const\n+\t{\n+\t\treturn { data() + size() - Count, Count };\n+\t}\n+\n+\ttemplate<std::size_t Offset, std::size_t Count = dynamic_extent>\n+\tconstexpr Span<element_type, Count> subspan() const\n+\t{\n+\t\treturn { data() + Offset, Count == dynamic_extent ? size() - Offset : Count };\n+\t}\n+\n+\tconstexpr Span<element_type, dynamic_extent>\n+\tsubspan(std::size_t Offset, std::size_t Count = dynamic_extent) const\n+\t{\n+\t\treturn { data() + Offset, Count == dynamic_extent ? size() - Offset : Count };\n+\t}\n+\n+private:\n+\tpointer data_;\n+\tsize_type size_;\n+};\n+\n+}; /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_SPAN_H__ */\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 88658ac563f7..2448f0e96468 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -36,6 +36,7 @@ libcamera_sources = files([\n 'request.cpp',\n 'semaphore.cpp',\n 'signal.cpp',\n+ 'span.cpp',\n 'stream.cpp',\n 'thread.cpp',\n 'timer.cpp',\ndiff --git a/src/libcamera/span.cpp b/src/libcamera/span.cpp\nnew file mode 100644\nindex 000000000000..753104765cea\n--- /dev/null\n+++ b/src/libcamera/span.cpp\n@@ -0,0 +1,12 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2020, Google Inc.\n+ *\n+ * span.h - C++20 std::span<> implementation for C++11\n+ */\n+\n+#include <libcamera/span.h>\n+\n+namespace libcamera {\n+\n+} /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "01/31" ] }