Patch Detail
Show a patch.
GET /api/1.1/patches/2903/?format=api
{ "id": 2903, "url": "https://patchwork.libcamera.org/api/1.1/patches/2903/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2903/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200227200407.490616-22-nicolas.dufresne@collabora.com>", "date": "2020-02-27T20:04:01", "name": "[libcamera-devel,v2,21/27] gst: pad: Add method to store retrieve pending buffers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1cb185ee958daab80e50e1a2dee393e1f4f030f5", "submitter": { "id": 31, "url": "https://patchwork.libcamera.org/api/1.1/people/31/?format=api", "name": "Nicolas Dufresne", "email": "nicolas.dufresne@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2903/mbox/", "series": [ { "id": 693, "url": "https://patchwork.libcamera.org/api/1.1/series/693/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=693", "date": "2020-02-27T20:03:40", "name": "GStreamer Element for libcamera", "version": 2, "mbox": "https://patchwork.libcamera.org/series/693/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2903/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2903/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas.dufresne@collabora.com>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E96262730\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Feb 2020 21:04:28 +0100 (CET)", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 7A8A529654B" ], "From": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 27 Feb 2020 15:04:01 -0500", "Message-Id": "<20200227200407.490616-22-nicolas.dufresne@collabora.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>", "References": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 21/27] gst: pad: Add method to store\n\tretrieve pending buffers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 27 Feb 2020 20:04:31 -0000" }, "content": "These will be useful for streaming. The requestComplete callback will\nstore the buffers on each pads so that the _run() can pick them up\nand push them through the pads from a streaming thread.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 27 +++++++++++++++++++++++++++\n src/gstreamer/gstlibcamerapad.h | 4 ++++\n 2 files changed, 31 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 4f96546..8662c92 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -17,6 +17,7 @@ struct _GstLibcameraPad {\n \tGstPad parent;\n \tStreamRole role;\n \tGstLibcameraPool *pool;\n+\tGQueue pending_buffers;\n };\n \n enum {\n@@ -136,3 +137,29 @@ gst_libcamera_pad_get_stream(GstPad *pad)\n \n \treturn nullptr;\n }\n+\n+void\n+gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\tGLibLocker lock(GST_OBJECT(self));\n+\n+\tg_queue_push_head(&self->pending_buffers, buffer);\n+}\n+\n+GstFlowReturn\n+gst_libcamera_pad_push_pending(GstPad *pad)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\tGstBuffer *buffer;\n+\n+\t{\n+\t\tGLibLocker lock(GST_OBJECT(self));\n+\t\tbuffer = GST_BUFFER(g_queue_pop_tail(&self->pending_buffers));\n+\t}\n+\n+\tif (!buffer)\n+\t\treturn GST_FLOW_CUSTOM_SUCCESS;\n+\n+\treturn gst_pad_push(pad, buffer);\n+}\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 81d0d58..d928570 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -26,4 +26,8 @@ void gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool);\n \n libcamera::Stream *gst_libcamera_pad_get_stream(GstPad *pad);\n \n+void gst_libcamera_pad_queue_buffer(GstPad *pad, GstBuffer *buffer);\n+\n+GstFlowReturn gst_libcamera_pad_push_pending(GstPad *pad);\n+\n #endif /* __GST_LIBCAMERA_PAD_H__ */\n", "prefixes": [ "libcamera-devel", "v2", "21/27" ] }