Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2889,
    "url": "https://patchwork.libcamera.org/api/1.1/patches/2889/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/2889/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200227200407.490616-8-nicolas.dufresne@collabora.com>",
    "date": "2020-02-27T20:03:47",
    "name": "[libcamera-devel,v2,07/27] gst: libcamerasrc: Add camera-name property",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "20ff6986ef6f81a8f0c1b68cb4cfa0de8732cdd8",
    "submitter": {
        "id": 31,
        "url": "https://patchwork.libcamera.org/api/1.1/people/31/?format=api",
        "name": "Nicolas Dufresne",
        "email": "nicolas.dufresne@collabora.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/2889/mbox/",
    "series": [
        {
            "id": 693,
            "url": "https://patchwork.libcamera.org/api/1.1/series/693/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=693",
            "date": "2020-02-27T20:03:40",
            "name": "GStreamer Element for libcamera",
            "version": 2,
            "mbox": "https://patchwork.libcamera.org/series/693/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/2889/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/2889/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<nicolas.dufresne@collabora.com>",
        "Received": [
            "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 156896272D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Feb 2020 21:04:21 +0100 (CET)",
            "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 9FB1529654A"
        ],
        "From": "Nicolas Dufresne <nicolas.dufresne@collabora.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Thu, 27 Feb 2020 15:03:47 -0500",
        "Message-Id": "<20200227200407.490616-8-nicolas.dufresne@collabora.com>",
        "X-Mailer": "git-send-email 2.24.1",
        "In-Reply-To": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>",
        "References": "<20200227200407.490616-1-nicolas.dufresne@collabora.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH v2 07/27] gst: libcamerasrc: Add\n\tcamera-name property",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Thu, 27 Feb 2020 20:04:22 -0000"
    },
    "content": "This property will be used to select by name the camera to use.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 68 ++++++++++++++++++++++++++++++-\n 1 file changed, 67 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex fb403cf..55ed174 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -6,12 +6,19 @@\n  * gstlibcamerasrc.cpp - GStreamer Capture Element\n  */\n \n+#include \"gstlibcamera-utils.h\"\n #include \"gstlibcamerapad.h\"\n #include \"gstlibcamerasrc.h\"\n \n struct _GstLibcameraSrc {\n \tGstElement parent;\n \tGstPad *srcpad;\n+\tgchar *camera_name;\n+};\n+\n+enum {\n+\tPROP_0,\n+\tPROP_CAMERA_NAME\n };\n \n G_DEFINE_TYPE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT);\n@@ -28,6 +35,52 @@ GstStaticPadTemplate request_src_template = {\n \t\"src_%s\", GST_PAD_SRC, GST_PAD_REQUEST, TEMPLATE_CAPS\n };\n \n+static void\n+gst_libcamera_src_set_property(GObject *object, guint prop_id,\n+\t\t\t       const GValue *value, GParamSpec *pspec)\n+{\n+\tGLibLocker lock(GST_OBJECT(object));\n+\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(object);\n+\n+\tswitch (prop_id) {\n+\tcase PROP_CAMERA_NAME:\n+\t\tg_free(self->camera_name);\n+\t\tself->camera_name = g_value_dup_string(value);\n+\t\tbreak;\n+\tdefault:\n+\t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n+\t\tbreak;\n+\t}\n+}\n+\n+static void\n+gst_libcamera_src_get_property(GObject *object, guint prop_id, GValue *value,\n+\t\t\t       GParamSpec *pspec)\n+{\n+\tGLibLocker lock(GST_OBJECT(object));\n+\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(object);\n+\n+\tswitch (prop_id) {\n+\tcase PROP_CAMERA_NAME:\n+\t\tg_value_set_string(value, self->camera_name);\n+\t\tbreak;\n+\tdefault:\n+\t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n+\t\tbreak;\n+\t}\n+}\n+\n+static void\n+gst_libcamera_src_finalize(GObject *object)\n+{\n+\tGObjectClass *klass = G_OBJECT_CLASS(gst_libcamera_src_parent_class);\n+\tGstLibcameraSrc *self = GST_LIBCAMERA_SRC(object);\n+\n+\tg_free(self->camera_name);\n+\n+\treturn klass->finalize(object);\n+}\n+\n static void\n gst_libcamera_src_init(GstLibcameraSrc *self)\n {\n@@ -40,7 +93,12 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n static void\n gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n {\n-\tGstElementClass *element_class = (GstElementClass *)klass;\n+\tGstElementClass *element_class = GST_ELEMENT_CLASS(klass);\n+\tGObjectClass *object_class = G_OBJECT_CLASS(klass);\n+\n+\tobject_class->set_property = gst_libcamera_src_set_property;\n+\tobject_class->get_property = gst_libcamera_src_get_property;\n+\tobject_class->finalize = gst_libcamera_src_finalize;\n \n \tgst_element_class_set_metadata(element_class,\n \t\t\t\t       \"libcamera Source\", \"Source/Video\",\n@@ -52,4 +110,12 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n \tgst_element_class_add_static_pad_template_with_gtype(element_class,\n \t\t\t\t\t\t\t     &request_src_template,\n \t\t\t\t\t\t\t     GST_TYPE_LIBCAMERA_PAD);\n+\n+\tGParamSpec *spec = g_param_spec_string(\"camera-name\", \"Camera Name\",\n+\t\t\t\t\t      \"Select by name which camera to use.\", nullptr,\n+\t\t\t\t\t      (GParamFlags)(GST_PARAM_MUTABLE_READY\n+\t\t\t\t\t\t\t    | G_PARAM_CONSTRUCT\n+\t\t\t\t\t\t\t    | G_PARAM_READWRITE\n+\t\t\t\t\t\t\t    | G_PARAM_STATIC_STRINGS));\n+\tg_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n }\n",
    "prefixes": [
        "libcamera-devel",
        "v2",
        "07/27"
    ]
}