Patch Detail
Show a patch.
GET /api/1.1/patches/2848/?format=api
{ "id": 2848, "url": "https://patchwork.libcamera.org/api/1.1/patches/2848/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2848/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200218095959.5836-1-kieran.bingham@ideasonboard.com>", "date": "2020-02-18T09:59:59", "name": "[libcamera-devel,v2] qcam: Use standard PicturesLocation path for capture", "commit_ref": "1d80ed1febbd4560c13cb670672cb67befc850ea", "pull_url": null, "state": "accepted", "archived": false, "hash": "40971f89bd3ec7c1cadeb382e5d9f55a3f9eb006", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2848/mbox/", "series": [ { "id": 684, "url": "https://patchwork.libcamera.org/api/1.1/series/684/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=684", "date": "2020-02-18T09:59:59", "name": "[libcamera-devel,v2] qcam: Use standard PicturesLocation path for capture", "version": 2, "mbox": "https://patchwork.libcamera.org/series/684/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2848/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2848/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1EF861D61\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Feb 2020 11:00:03 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 336122F9;\n\tTue, 18 Feb 2020 11:00:03 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582020003;\n\tbh=8GTFx5D56RKlgytZbWnTUfFZM02ddMTFQHw6aYaej4I=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=n6ZVPAaoPdx4i1pDthv8x+RQgxgyL9vZzgU+FxBDpaZGA/ptW4P1LXNA0JF1QGdlp\n\t88jaUNgl+ezFfg8e4Qp+0lHweTq1L2N84Po75xV/gbH+FFsfjSHMUOO0j1QdfW9X84\n\trFgAlKWvmLU0Z4D0CqGhJpa/gp/X1YtNqh99CRYE=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 18 Feb 2020 09:59:59 +0000", "Message-Id": "<20200218095959.5836-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] qcam: Use standard PicturesLocation\n\tpath for capture", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 18 Feb 2020 10:00:03 -0000" }, "content": "Utilise the QStandardPaths::PicturesLocation as a starting point for\nsaving images from qcam.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 29eaba8454f8..ae1760dfd647 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -17,6 +17,7 @@\n #include <QImage>\n #include <QImageWriter>\n #include <QInputDialog>\n+#include <QStandardPaths>\n #include <QTimer>\n #include <QToolBar>\n #include <QToolButton>\n@@ -348,8 +349,9 @@ void MainWindow::stopCapture()\n void MainWindow::saveImageAs()\n {\n \tQImage image = viewfinder_->getCurrentImage();\n+\tQString defaultPath = QStandardPaths::writableLocation(QStandardPaths::PicturesLocation);\n \n-\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", \"\",\n+\tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n \n \tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;\n", "prefixes": [ "libcamera-devel", "v2" ] }