Patch Detail
Show a patch.
GET /api/1.1/patches/27342/?format=api
{ "id": 27342, "url": "https://patchwork.libcamera.org/api/1.1/patches/27342/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27342/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260708-libipa-algorithms-v5-33-0759d0359f52@ideasonboard.com>", "date": "2026-07-08T15:51:15", "name": "[v5,33/36] ipa: libipa: lsc: Rename sampleForCrop to resampleLscData", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f0fb1a8ee220efd2991dc6af11fa078cd71ac22a", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27342/mbox/", "series": [ { "id": 6048, "url": "https://patchwork.libcamera.org/api/1.1/series/6048/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6048", "date": "2026-07-08T15:50:42", "name": "ipa: libipa: Introduce libipa algorithms", "version": 5, "mbox": "https://patchwork.libcamera.org/series/6048/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27342/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27342/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31F6FC3329\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Jul 2026 15:51:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D869D6610F;\n\tWed, 8 Jul 2026 17:51:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ECF8660B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jul 2026 17:51:23 +0200 (CEST)", "from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 210624045;\n\tWed, 8 Jul 2026 17:50:33 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nFRDx2dN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783525833;\n\tbh=Gv1Zzsx5m30sFYdnWZws32iqLMjIF1ZPRqK2SkY9WcM=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=nFRDx2dNu6j7oSAUoExcjabZulTjdw7UEiCJpLTv3JDJ2ridjXZLZ2AuEHQm5FuFp\n\tPjVthufwRp/TykOUyaoYngYl197JNfLHn6flpafFa8kV4kDu/LcnuSUvBRqBjg5f/i\n\ta8P23gd0gTz2hs4J8EMSHhT4rrceN/VeFRs/gmVU=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 08 Jul 2026 17:51:15 +0200", "Subject": "[PATCH v5 33/36] ipa: libipa: lsc: Rename sampleForCrop to\n\tresampleLscData", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260708-libipa-algorithms-v5-33-0759d0359f52@ideasonboard.com>", "References": "<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>", "In-Reply-To": "<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4426;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=Gv1Zzsx5m30sFYdnWZws32iqLMjIF1ZPRqK2SkY9WcM=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqTnHtZ3d7O05pivQ2a/50JqUkhALCtBDb6kLl5\n\tvPCvsvSsMiJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak5x7QAKCRByNAaPFqFW\n\tPNd4D/kBhhI9X8fn6d47yDKYdNTEIu9QO7GVzQtUwok7JbnHjEgPaO1xt6yTyKl8iFDLz7dA4pP\n\tJWwsoI2v3OD7Jw/fIX11SbjygNkaLiEpvreeCSOqWlHkguu1NWVqv+bk7wUz1FIKag4ZVFVw98X\n\tqbcFTvmBjjVokkk5UzGYG4UClG8JHEgiYWELVFxUkNYWzbJmzKJ+3eIgb4Wd/+SvK3mMCDCn6wK\n\thGyZuWYTv9aynvjf0e2DqFHXJZmOYxrAHXXh5MdiVxXq8I5nQV7MrdOuA01hcKq9d/mHAhYh4wm\n\tZXUGn9fRmx2TcCDBPxc00lKi3nh6dcY6ynTvfKmnATgKoMNyuC7KbHfp8y7zChs2Bezg3TnctUI\n\tOpea2AaYi7AZ19qGbT587Now9mKHDGRnAmUwDcFc7HL51JjMQiAE0BKIl/Gt9Zec7w5vhqNV9yu\n\tEbVVJqoOzRnqbvVH7t2GMbY4bAh9UNMo8qKPuHj1eN1r23Q3RKqKzexkt0SsoP5rXL+SRxCAosR\n\tpmCutH2StRqKp8GGEAAbrHnTtm/VBUXU3uLuEmrTTBlJOb3FAuDkCWlIMqThWJ/0kazjl4eNyQF\n\tqvptcytfF6JtcA/V5LZjy00tXD2IksqCZIwwNXKmXQp+jnamenUVw5GvvVqXeKcpJHsnpovndhm\n\tXYhVYNPOPg8QsCA==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename the function to a more precise name.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc.cpp | 2 +-\n src/ipa/libipa/lsc.h | 2 +-\n src/ipa/libipa/lsc_base.cpp | 2 +-\n src/ipa/libipa/lsc_base.h | 4 ++--\n src/ipa/libipa/lsc_polynomial.cpp | 2 +-\n src/ipa/libipa/lsc_polynomial.h | 4 ++--\n src/ipa/libipa/lsc_table.h | 6 +++---\n 7 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex f5646937c60a..0ce40c09caed 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -269,7 +269,7 @@ void LscAlgorithmBase::process(lsc::FrameContext &context, ControlList &metadata\n * analogCrop on a grid specified by \\a xPos and \\a yPos. Re-sampling of\n * LSC data is currently supported by polynomial-based LSC tables.\n *\n- * \\sa LscImplementation::sampleForCrop\n+ * \\sa LscImplementation::resampleLscData\n *\n * \\return 0 on success, a negative error code otherwise\n */\ndiff --git a/src/ipa/libipa/lsc.h b/src/ipa/libipa/lsc.h\nindex 6dc76b6572b3..1f46555f9bf0 100644\n--- a/src/ipa/libipa/lsc.h\n+++ b/src/ipa/libipa/lsc.h\n@@ -98,7 +98,7 @@ public:\n \t{\n \t\tLOG(Lsc, Debug) << \"Sample Lsc data for \" << analogCrop;\n \t\tlsc::ComponentsMap<T> lscData =\n-\t\t\timpl_->sampleForCrop(analogCrop, xPos, yPos);\n+\t\t\timpl_->resampleLscData(analogCrop, xPos, yPos);\n \n \t\t/*\n \t\t * Retain a copy of the components table.\ndiff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex 235f11e8c53b..c87e2680d973 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -127,7 +127,7 @@ void Interpolator<lsc::Components<uint16_t>>::\n */\n \n /**\n- * \\fn LscImplementation::sampleForCrop\n+ * \\fn LscImplementation::resampleLscData\n * \\brief Re-sample the LSC components for \\a cropRectangle\n * \\param[in] cropRectangle The sensor analogue crop rectangle\n * \\param[in] xPos List of horizontal positions of the LSC grid nodes\ndiff --git a/src/ipa/libipa/lsc_base.h b/src/ipa/libipa/lsc_base.h\nindex 4edcb2637d1b..a25d951e8ddb 100644\n--- a/src/ipa/libipa/lsc_base.h\n+++ b/src/ipa/libipa/lsc_base.h\n@@ -74,8 +74,8 @@ public:\n \t\t\t\t const LscDescriptor &descriptor) = 0;\n \n \tvirtual lsc::ComponentsMap<typename U::QuantizedType>\n-\tsampleForCrop(const Rectangle &cropRectangle,\n-\t\t std::vector<double> xPos, std::vector<double> yPos);\n+\tresampleLscData(const Rectangle &cropRectangle,\n+\t\t\tstd::vector<double> xPos, std::vector<double> yPos) = 0;\n };\n \n } /* namespace ipa */\ndiff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex 060fba9826a0..aab45ab4f15c 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -190,7 +190,7 @@ int LscPolynomialBase::parseLscData(const ValueNode &sets,\n */\n \n /**\n- * \\fn LscPolynomial::sampleForCrop()\n+ * \\fn LscPolynomial::resampleLscData()\n * \\brief Re-sample the LSC components for \\a cropRectangle\n * \\param[in] cropRectangle The sensor analogue crop rectangle\n * \\param[in] xPos List of horizontal positions of the LSC grid nodes\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex a84a736734e1..00bbd068d537 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -78,8 +78,8 @@ public:\n \t}\n \n \tlsc::ComponentsMap<T>\n-\tsampleForCrop(const Rectangle &cropRectangle,\n-\t\t std::vector<double> xPos, std::vector<double> yPos) override\n+\tresampleLscData(const Rectangle &cropRectangle,\n+\t\t\tstd::vector<double> xPos, std::vector<double> yPos) override\n \t{\n \t\tlsc::ComponentsMap<T> components;\n \ndiff --git a/src/ipa/libipa/lsc_table.h b/src/ipa/libipa/lsc_table.h\nindex fe4e133060a6..c3d6c6b95dcd 100644\n--- a/src/ipa/libipa/lsc_table.h\n+++ b/src/ipa/libipa/lsc_table.h\n@@ -50,9 +50,9 @@ public:\n \t}\n \n \tlsc::ComponentsMap<T>\n-\tsampleForCrop([[maybe_unused]] const Rectangle &cropRectangle,\n-\t\t [[maybe_unused]] std::vector<double> xPos,\n-\t\t [[maybe_unused]] std::vector<double> yPos) override\n+\tresampleLscData([[maybe_unused]] const Rectangle &cropRectangle,\n+\t\t\t[[maybe_unused]] std::vector<double> xPos,\n+\t\t\t[[maybe_unused]] std::vector<double> yPos) override\n \t{\n \t\tLOG(LscTable, Warning)\n \t\t\t<< \"Tabular LSC data doesn't support resampling\";\n", "prefixes": [ "v5", "33/36" ] }