Patch Detail
Show a patch.
GET /api/1.1/patches/27340/?format=api
{ "id": 27340, "url": "https://patchwork.libcamera.org/api/1.1/patches/27340/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27340/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260708-libipa-algorithms-v5-34-0759d0359f52@ideasonboard.com>", "date": "2026-07-08T15:51:16", "name": "[v5,34/36] ipa: libipa: lsc: Specialize Interpolator for uint8_t", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8cc70f4d288768cb68f0ddf42e1226c4373ac2b1", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27340/mbox/", "series": [ { "id": 6048, "url": "https://patchwork.libcamera.org/api/1.1/series/6048/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6048", "date": "2026-07-08T15:50:42", "name": "ipa: libipa: Introduce libipa algorithms", "version": 5, "mbox": "https://patchwork.libcamera.org/series/6048/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27340/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27340/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0890CC3338\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Jul 2026 15:51:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3C8766111;\n\tWed, 8 Jul 2026 17:51:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5214C660D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jul 2026 17:51:23 +0200 (CEST)", "from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7309A4059;\n\tWed, 8 Jul 2026 17:50:33 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gw1M6ND6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783525833;\n\tbh=pKxxZ9cajwGg/4XFTEBKJ35/7Bmlg5h/GcltukR9A5Y=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=gw1M6ND6YIZtKzRMAqp7875ugVhah/zvvxb7lvadNtlXDub+XL0JQAWOe4rEFe3w1\n\tnufMYXkhJapRlmK/mcra+RQFZGK5jCs+QMRoSOHYk+DL4cEHc2ML6TvqdluO5Uniax\n\t3Swab3eNCbwrtAEFAKpBFxUxBPgQ9asIWbNyyf/A=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 08 Jul 2026 17:51:16 +0200", "Subject": "[PATCH v5 34/36] ipa: libipa: lsc: Specialize Interpolator for\n\tuint8_t", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260708-libipa-algorithms-v5-34-0759d0359f52@ideasonboard.com>", "References": "<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>", "In-Reply-To": "<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1736;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=pKxxZ9cajwGg/4XFTEBKJ35/7Bmlg5h/GcltukR9A5Y=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqTnHtJT9XBhcWqONPcXhgf4AAu/oHcL8TpuY5G\n\tqSQwB1qC0iJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak5x7QAKCRByNAaPFqFW\n\tPA/BEACbet4XP/rkUgrxopirdwDFiyhdtdhN4pN06m8DAV19t9qjfx7QHx39W604X9bPUG6ufsk\n\ttaf7jjGNOLYonk8I1UwprQl1AiOjXhx0c0swPNGlQuJtVT4DB88MCt2IHLISGOuBReJpffMLgfg\n\tpU9zJmUy44jgXjNu+768EEvzx1bHqV1p7sOFchbuXkdYzIsjXEeT63FfBKgfKi+SBxwjLBTj3/k\n\t0GkMbJqp2PNqyRKV1vu/gTnmEiRhMtuU+Q8i31HOIx99gxXw2/H9s8ysS4wHUq4qGY0LJ3qxzB6\n\tiIWTwRzwyslfV6r96XdZ1DS0v/u535enjPFIZ90CzaDbgUMtQAX7HZ4JPJstfIw7xSLWVMlA9lk\n\ti1tvAgFgIpYA64Y8mpxlGG/ZbC+ZptxQK72exo+r+iFyIpJ6swmuddaKRDa90WEHhZoqntV09X5\n\trNje8oiXnlnO4FSK2kUyf1g1c5cisVWPtV+V5QPjL18RNffCBRrFKBwi6vNPS3TnlVLkogUnWB0\n\txZCDLrBsofhWJ677egM0HVF/k+5iYlNMLK2U4Uzscvs3PSsgNup+Typqqdrp3snXtCvcGpmF6cp\n\t0MBilIIK4/wltPhJSG372+SSFtl7hwss8qy9dTtg8trb20Rvev26ujYVcw49l9VzKJiZ5V4Ctax\n\ttGVi1nBdvonW8fg==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Mali-C55 LSC algorithm uses 8-bit gain values.\n\nSpecialize Interpolator<lsc::Components>> for uint8_t to prevent the\nuint16_t specialization from being selected.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc_base.cpp | 11 +++++++++++\n src/ipa/libipa/lsc_base.h | 7 +++++++\n 2 files changed, 18 insertions(+)", "diff": "diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex c87e2680d973..a0b78ac5265b 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -63,6 +63,17 @@ namespace lsc {\n } /* namespace lsc */\n \n #ifndef __DOXYGEN__\n+template<>\n+void Interpolator<lsc::Components<uint8_t>>::\n+\tinterpolate(const lsc::Components<uint8_t> &a,\n+\t\t const lsc::Components<uint8_t> &b,\n+\t\t lsc::Components<uint8_t> &dest,\n+\t\t double lambda)\n+{\n+\tfor (auto const &[k, v] : a)\n+\t\tinterpolateVector(v, b.at(k), dest[k], lambda);\n+}\n+\n template<>\n void Interpolator<lsc::Components<uint16_t>>::\n \tinterpolate(const lsc::Components<uint16_t> &a,\ndiff --git a/src/ipa/libipa/lsc_base.h b/src/ipa/libipa/lsc_base.h\nindex a25d951e8ddb..51f3dd91f547 100644\n--- a/src/ipa/libipa/lsc_base.h\n+++ b/src/ipa/libipa/lsc_base.h\n@@ -49,6 +49,13 @@ void interpolateVector(const std::vector<T> &a, const std::vector<T> &b,\n \t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n }\n \n+template<>\n+void Interpolator<lsc::Components<uint8_t>>::\n+\tinterpolate(const lsc::Components<uint8_t> &a,\n+\t\t const lsc::Components<uint8_t> &b,\n+\t\t lsc::Components<uint8_t> &dest,\n+\t\t double lambda);\n+\n template<>\n void Interpolator<lsc::Components<uint16_t>>::\n \tinterpolate(const lsc::Components<uint16_t> &a,\n", "prefixes": [ "v5", "34/36" ] }