Patch Detail
Show a patch.
GET /api/1.1/patches/27295/?format=api
{ "id": 27295, "url": "https://patchwork.libcamera.org/api/1.1/patches/27295/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27295/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260708-libipa-algorithms-v4-30-f0e99f035294@ideasonboard.com>", "date": "2026-07-08T09:25:17", "name": "[v4,30/35] ipa: libipa: lsc_base: Describe the function of lsc_base", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "560ece815ff4611f5c72042e0eae5192cafc290a", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27295/mbox/", "series": [ { "id": 6046, "url": "https://patchwork.libcamera.org/api/1.1/series/6046/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6046", "date": "2026-07-08T09:24:47", "name": "ipa: libipa: Introduce libipa algorithms", "version": 4, "mbox": "https://patchwork.libcamera.org/series/6046/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27295/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27295/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D3D5C3330\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Jul 2026 09:25:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6D12660E9;\n\tWed, 8 Jul 2026 11:25:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F57566078\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jul 2026 11:25:14 +0200 (CEST)", "from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DA503FC6;\n\tWed, 8 Jul 2026 11:24:24 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D4FCh8DG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783502664;\n\tbh=2QvgZUzLDc2ja7R9EkinL3mS8x7xRAxO+EYGjrc7vbU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=D4FCh8DGdgA/1PwjmaokNcoJ3JzWo+nwgtqN9ABxikiG431cqcYDGUZ5tgb5U6sUP\n\tc+anVrNvJgsGJwfYu5OcLV0cWXxm/GA1S5UkIdRO3BF8jBK93Q5GKbWHCnqnsGJwkW\n\tPp124SF42EpY7C/SOhwpzguAjNsCWRbZLQD5rxT0=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 08 Jul 2026 11:25:17 +0200", "Subject": "[PATCH v4 30/35] ipa: libipa: lsc_base: Describe the function of\n\tlsc_base", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260708-libipa-algorithms-v4-30-f0e99f035294@ideasonboard.com>", "References": "<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>", "In-Reply-To": "<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1646;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=2QvgZUzLDc2ja7R9EkinL3mS8x7xRAxO+EYGjrc7vbU=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqThdvi3HVtADvi928wNehQ5TLvHMs5ugSBrCYu\n\tNxq3s2WSYWJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak4XbwAKCRByNAaPFqFW\n\tPGGgD/9AXFtm+AyTXz8Bq9ay8WaNaDBLHe2n2vh3IKJQBkBL+0Qgieh4XDm6bOFjsELXigTadtM\n\tbnw7Yas1qibuCBnpgqOD0ajEXU+BAo20U4iX5sifeYEH5qB2lTaaGgQU/Z4FOgGMvTrufCw87bR\n\t2LPrEIvKXh635GUVi7n9Dmr/2T69oyHthxHgqpGP1xKBVPB+Bg+K5Rk7w2nRWDrmzX9pwPvDn0P\n\tl4IdM55QBFFX/DaniPSgqd2GBgxvm9F3/fxg+bLq3/a8XU7A1VPyeE+sPMgZ0D4z9cq+iQi6A6r\n\tXfOq/XkBg7OykkoJnOFIFZoiRZu6RWBJKXntgFZzaqdwzbF3KDZmmXG7nl5fkrGLDdYq1cxdAqp\n\t4sWouyg/71VW3DjkgkO4x/0V8F1mg0gibuDJ0aKk0NVQaXlARFZ917zDFvw+4Y2CSHD8ra15isY\n\tKa3wbua4L2DzN/yOBU8rQuWOXub/5HnZeTerCpuHO2LHg86/qEHPl0D9PDfmM67gXwTcYJhmoih\n\tENx2P7ArkulnT0tjwPXpUQult7oqHtArBLwX9s4Xx7g6m+OjTOu0PdphzJLHqu2XBo3t/InJkx+\n\tE8F+lkppzft79JaQ/yirzXeZmzAVMhO3wihOdqTC6q9cXvWvNRQjLWhaCC7ePGkTtVaJWdpupZy\n\tZp8IBsek+su6kNg==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the class hierarchy is in place, describe the function\nof the lsc_base header in the file comment.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc_base.cpp | 16 +++++++++++++++-\n 1 file changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex b91da4e5be9d..dd2e1128a546 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -10,6 +10,19 @@\n /**\n * \\file lsc_base.h\n * \\brief Base types and definitions for LscImplementation class hierarchy\n+ *\n+ * Split the common classes and types definitions to a dedicated file to avoid\n+ * circular inclusions.\n+ *\n+ * Both LscTable and LscPolynomial inherit from LscImplementation and they are\n+ * instantiated from lsc.h as the LscAlgorithm::init() function is there inlined.\n+ *\n+ * For this reason lsc.h needs to include lsc_table.h and lsc_polynomial.h which\n+ * need the LscImplementation class definition themselves.\n+ *\n+ * Split the LscImplementation interface definition to this file so that it can\n+ * be included by both lsc_table.h and lsc_polynomial.h, which are then included\n+ * by lsc.h.\n */\n \n namespace libcamera {\n@@ -88,7 +101,8 @@ void Interpolator<lsc::Components>::\n * \\brief Pure virtual base class for LSC algorithm implementations\n * \\tparam U The fixedpoint LSC engine register format\n *\n- * Defines the interface for the LSC algorithm implementation.\n+ * Defines the interface for the LSC algorithm implementation. Currently\n+ * implemented by LscTable and LscPolynomial.\n */\n \n /**\n", "prefixes": [ "v4", "30/35" ] }